remove and refactor tax-related input files - #2175
Conversation
|
Thank you, @fbenke-pik, for cleaning up this part of the code!
I have checked the compare scenario PDFs and there happen to be larger effects in the concerned regions for all SSPs. IND, LAM and MEA are the strongly affected regions, and looking at calcFEtaxes, one sees that these are among the regions for which changes are applied. I do not know why these differences occur while your changes should in principle be equivalent to the previous implementation. It could be either (a) some error in the new implementation (unit conversion, values, etc.), or (b) that it is not equivalent to apply the changes in the preloop in GAMS or in the R input data pre-processing. Maybe @Renato-Rodrigues or @robertpietzcker can provide an input on (b). In more detail for SSP1:
|
|
Hey Laurin, thanks for taking a look.
Sorry, that was an incorrect statement. I indeed changed one thing that apparently affects the results. In mrremind, I removed a unit conversion from $2005 to $2017 applied to the tax limits (here), but I think the conversion should not be there in the first place. It was introduced by me when applying the unit conversion for all input data and in that particular case, it most likely does not make sense for So, it is ok if some of the trajectories look different. In theory, they should be more accurate due to the fix. The actual question is: are there any problematic changes? If so, the way forward would probably be adjusting the limits in mrremind. By removing the conversion, the max limits should be lower than before. |
|
Thanks for pointing this out, @fbenke-pik !
While I am definitely not an energy expert, the changes are problematic in my view because the new runs are much worse in matching (trends in) historical IEA data. For example, one sees this when looking at Am I correct that you did not re-calibrate the model, right? It might well be that re-calibration resolves the issue and brings the trajectories in historic timesteps back together. |
|
I could think of two things to do:
|
If the unit conversion should not be there, I believe it is worth re-calibrating and comparing the results. However, I would refer to @LaviniaBaumstark, @JakobBD, or @robertpietzcker for a more qualified judgement on how this change impacts calibration. |
|
Close in favour of #2207 |







Purpose of this PR
This PR removes corrections to taxes and subsidies done via three input input files:
f21_max_pe_sub.cs4rf21_prop_fe_sub.cs4rf21_max_fe_sub.cs4rAs these corrections apply to data in the input files only , they can be done directly in mrremind and do not have to happen in REMIND itself.
See the corresponding PR in mrremind: pik-piam/mrremind#714
These changes should have practically no effect on the run results. See comparison to latest AMTs for selected scenarios here:
/p/tmp/benke/model/remind_tax/compScen-SSP2corrected-2025-08-06_14.32.24-H12.pdf/p/tmp/benke/model/remind_tax/compScen-SSP1-2025-08-06_13.39.46-H12.pdf/p/tmp/benke/model/remind_tax/compScen-SSP3-2025-08-06_13.40.57-H12.pdfType of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)