Remove input files imposing limits on subsidies - #2207
Merged
Conversation
8 tasks
fbenke-pik
marked this pull request as ready for review
October 6, 2025 13:58
laurinks
approved these changes
Oct 6, 2025
laurinks
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thank you, @fbenke-pik, for making things more transparent and readable!
LaviniaBaumstark
left a comment
Member
There was a problem hiding this comment.
do you also need to have new input data?
Contributor
Author
Correct, this requires new input data and calibration. |
LaviniaBaumstark
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Follow-up to #2175
Remove input data file
f21_prop_fe_sub.cs4r, which is used to apply a factor forMEAandREFforfehosto limit subsidies. Instead, the proportional factor is now applied directly inmrremind::calcFETaxesas part of input data generation.Remove input data file
f21_max_fe_sub, which is used to apply absolute limits on subsidies forfegas,fehosandfesosfor various regions. Instead, the limit is no applied directly inmrremind::calcFETaxesas part of input data generation.Important: Applying the limits in calcFETaxes slightly changes the input data, as it is now done on ISO-country level before aggregation to regions and rounding. The factors were chosen to yield results close to the ones of the previous approach, but they will not be identical.
Related PR in mrremind: pik-piam/mrremind#741
Comparison runs can be found here:
/p/tmp/benke/model/remind_subsidy/compScen-ssp1-2025-10-06_11.26.30-H12.pdf/p/tmp/benke/model/remind_subsidy/compScen-ssp2-2025-10-06_11.29.31-H12.pdf/p/tmp/benke/model/remind_subsidy/compScen-ssp3-2025-10-06_11.30.09-H12.pdfPlots to take a look at (judging from a previous PR) are: 4.5.3, 5.1.7.2, 5.1.7.3, 5.3.4.2, 5.3.4.3
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)