Skip to content

fix(preonboarding) - fix sandbox bug when request fails#1117

Merged
gabrielseco merged 5 commits into
mainfrom
fix-onboarding-preonboarding
Jun 26, 2026
Merged

fix(preonboarding) - fix sandbox bug when request fails#1117
gabrielseco merged 5 commits into
mainfrom
fix-onboarding-preonboarding

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

First cause was endpoint removed in the API

Second bug when API failed the business logic failed

Third if we had put the feature flag first wouldn't have happened, two would have still be there, not a bad thing to find it


Note

Medium Risk
Changes when invite is allowed relative to pre-onboarding API failures and feature flags, which affects review-step onboarding behavior in production when the flag is enabled.

Overview
Pre-onboarding document requirements are now behind the pre_onboarding_requirements onboarding feature flag, so environments without the API (e.g. sandbox) no longer hit the requirements endpoint unless the flag is on.

Invite gating was adjusted: loading still disables invite; missing or empty requirements no longer block invite; API errors no longer force invite to stay disabled (cached requirement data is still evaluated when present). The same flag gates fetches in usePreOnboardingRequirements, and useOnboarding exposes options.features on the onboarding bag for components/tests.

Reviewed by Cursor Bugbot for commit a4268f6. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/flows/Onboarding/hooks.tsx
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 223.95 kB 223.9 kB +52 B (+0.0%) 🔴
Total (raw) 604.77 kB 604.6 kB +164 B (+0.0%) 🔴
CSS (gzip) 20.89 kB 20.89 kB 0 B (0%) 🟢
CSS (raw) 109.09 kB 109.09 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 223.95 kB / 250 kB (89.6%)
  • ✅ Total raw: 604.77 kB / 650 kB (93.0%)
  • ✅ CSS gzipped: 20.89 kB / 25 kB (83.5%)

Largest Files (Top 5)

  1. chunk-Y3CJRZLA.js - 14 kB (0 B (0%))
  2. styles.css - 10.44 kB (0 B (0%))
  3. index.css - 10.44 kB (0 B (0%))
  4. chunk-MQTRTRV6.js - 6.36 kB (0 B (0%))
  5. index.js - 6.33 kB (0 B (0%))
View All Files (341 total)
File Size (gzip) Change
chunk-Y3CJRZLA.js 14 kB 0 B (0%)
styles.css 10.44 kB 0 B (0%)
index.css 10.44 kB 0 B (0%)
chunk-MQTRTRV6.js 6.36 kB 0 B (0%)
index.js 6.33 kB 0 B (0%)
chunk-KWIWHDBS.js 6.08 kB 0 B (0%)
chunk-G2LZFGZA.js 5.31 kB 0 B (0%)
chunk-MBOKEWSX.js 4.76 kB 0 B (0%)
chunk-UAMKMIHP.js 4.57 kB 0 B (0%)
chunk-OVU2VJM6.js 3.89 kB 0 B (0%)

✅ Bundle size check passed

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 88.42% 88.41% +0.01% 🟢
Statements 87.83% 87.82% 0%
Functions 84.88% 84.88% 0%
Branches 79.70% 79.66% +0.04% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3842 / 4345
  • Coverage: 88.42%
  • Change: +0.01% (4 lines)
Statements Coverage
  • Covered: 3903 / 4444
  • Coverage: 87.83%
  • Change: 0% (3 statements)
Functions Coverage
  • Covered: 1044 / 1230
  • Coverage: 84.88%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 2403 / 3015
  • Coverage: 79.70%
  • Change: +0.04% (2 branches)

✅ Coverage check passed

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-bffx17spu-remotecom.vercel.app
Latest Commit:a4268f6

Deployed with vercel-action

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-5h2ae91d2-remotecom.vercel.app
Latest Commit:a4268f6

Deployed with vercel-action

@gabrielseco gabrielseco requested a review from cammellos June 26, 2026 17:21
@gabrielseco gabrielseco self-assigned this Jun 26, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5dcb561. Configure here.

Comment thread src/flows/Onboarding/hooks.tsx
@gabrielseco gabrielseco merged commit faf5456 into main Jun 26, 2026
11 checks passed
@gabrielseco gabrielseco deleted the fix-onboarding-preonboarding branch June 26, 2026 20:33
@gabrielseco gabrielseco mentioned this pull request Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants