fix(preonboarding) - fix sandbox bug when request fails#1117
Merged
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (341 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
cammellos
approved these changes
Jun 26, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5dcb561. Configure here.
cammellos
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

First cause was endpoint removed in the API
Second bug when API failed the business logic failed
Third if we had put the feature flag first wouldn't have happened, two would have still be there, not a bad thing to find it
Note
Medium Risk
Changes when invite is allowed relative to pre-onboarding API failures and feature flags, which affects review-step onboarding behavior in production when the flag is enabled.
Overview
Pre-onboarding document requirements are now behind the
pre_onboarding_requirementsonboarding feature flag, so environments without the API (e.g. sandbox) no longer hit the requirements endpoint unless the flag is on.Invite gating was adjusted: loading still disables invite; missing or empty requirements no longer block invite; API errors no longer force invite to stay disabled (cached requirement data is still evaluated when present). The same flag gates fetches in
usePreOnboardingRequirements, anduseOnboardingexposesoptions.featureson the onboarding bag for components/tests.Reviewed by Cursor Bugbot for commit a4268f6. Bugbot is set up for automated code reviews on this repo. Configure here.