Skip to content

handle active status for onboarding flow#1135

Merged
jordividaller merged 1 commit into
mainfrom
fix/pbyr-4213-handle-active-status
Jul 1, 2026
Merged

handle active status for onboarding flow#1135
jordividaller merged 1 commit into
mainfrom
fix/pbyr-4213-handle-active-status

Conversation

@jordividaller

@jordividaller jordividaller commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Fixed an issue where the SDK onboarding flow incorrectly handled active employmentIDs, causing a UI/API state mismatch during detail updates. The flow now correctly redirects users straight to the review step.

https://www.loom.com/share/4ce907707c5e46af8875305f83441c0e


Note

Low Risk
Small allowlist changes in onboarding utils plus tests; behavior is limited to active employment IDs and aligns UI with existing read-only review patterns.

Overview
Fixes SDK onboarding when an employment is already active: the flow no longer leaves users on editable steps that conflict with backend state.

Employee and contractor onboarding now include active in reviewStepAllowedEmploymentStatus, so loading an active employmentId auto-opens the review step (read-only), same as invited, initiated, etc.

Contractor onboarding also adds active to disabledInviteButtonEmploymentStatus, so the invite action stays disabled for already-active employments.

Tests cover auto-navigation to review when status is active.

Reviewed by Cursor Bugbot for commit ec7cf32. Bugbot is set up for automated code reviews on this repo. Configure here.

@jordividaller jordividaller requested a review from cammellos July 1, 2026 16:50
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 224.04 kB 223.99 kB +44 B (+0.0%) 🔴
Total (raw) 606.31 kB 606.28 kB +36 B (+0.0%) 🔴
CSS (gzip) 20.89 kB 20.89 kB 0 B (0%) 🟢
CSS (raw) 109.09 kB 109.09 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 224.04 kB / 250 kB (89.6%)
  • ✅ Total raw: 606.31 kB / 650 kB (93.3%)
  • ✅ CSS gzipped: 20.89 kB / 25 kB (83.5%)

Largest Files (Top 5)

  1. chunk-Y3CJRZLA.js - 14 kB (0 B (0%))
  2. styles.css - 10.44 kB (0 B (0%))
  3. index.css - 10.44 kB (0 B (0%))
  4. chunk-XCGCCYTF.js - 6.43 kB (new)
  5. index.js - 6.32 kB (0 B (0%))
View All Files (341 total)
File Size (gzip) Change
chunk-Y3CJRZLA.js 14 kB 0 B (0%)
styles.css 10.44 kB 0 B (0%)
index.css 10.44 kB 0 B (0%)
chunk-XCGCCYTF.js 6.43 kB new
index.js 6.32 kB 0 B (0%)
chunk-BYDNNJHZ.js 6.08 kB 0 B (0%)
chunk-G2LZFGZA.js 5.31 kB 0 B (0%)
chunk-I2F6TCSU.js 4.76 kB 0 B (0%)
chunk-TE2YVMXZ.js 4.57 kB new
chunk-S4QKVG2B.js 3.89 kB 0 B (0%)

✅ Bundle size check passed

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

⚪ Coverage unchanged

Metric Current Previous Change Status
Lines 88.42% 88.42% 0%
Statements 87.83% 87.83% 0%
Functions 84.88% 84.88% 0%
Branches 79.70% 79.70% 0%

Detailed Breakdown

Lines Coverage
  • Covered: 3842 / 4345
  • Coverage: 88.42%
  • Change: 0% (0 lines)
Statements Coverage
  • Covered: 3903 / 4444
  • Coverage: 87.83%
  • Change: 0% (0 statements)
Functions Coverage
  • Covered: 1044 / 1230
  • Coverage: 84.88%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 2403 / 3015
  • Coverage: 79.70%
  • Change: 0% (0 branches)

✅ Coverage check passed

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-hhpfaph61-remotecom.vercel.app
Latest Commit:ec7cf32

Deployed with vercel-action

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-lpn371wwb-remotecom.vercel.app
Latest Commit:ec7cf32

Deployed with vercel-action

@jordividaller jordividaller merged commit d2936c9 into main Jul 1, 2026
11 checks passed
@jordividaller jordividaller deleted the fix/pbyr-4213-handle-active-status branch July 1, 2026 17:22
@cursor cursor Bot mentioned this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants