handle active status for onboarding flow#1135
Merged
Merged
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (341 total)
✅ Bundle size check passed |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
cammellos
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the SDK onboarding flow incorrectly handled active employmentIDs, causing a UI/API state mismatch during detail updates. The flow now correctly redirects users straight to the review step.
https://www.loom.com/share/4ce907707c5e46af8875305f83441c0e
Note
Low Risk
Small allowlist changes in onboarding utils plus tests; behavior is limited to active employment IDs and aligns UI with existing read-only review patterns.
Overview
Fixes SDK onboarding when an employment is already
active: the flow no longer leaves users on editable steps that conflict with backend state.Employee and contractor onboarding now include
activeinreviewStepAllowedEmploymentStatus, so loading an activeemploymentIdauto-opens the review step (read-only), same asinvited,initiated, etc.Contractor onboarding also adds
activetodisabledInviteButtonEmploymentStatus, so the invite action stays disabled for already-active employments.Tests cover auto-navigation to review when status is
active.Reviewed by Cursor Bugbot for commit ec7cf32. Bugbot is set up for automated code reviews on this repo. Configure here.