Skip to content

Feat/onboard without contract#1139

Merged
jordividaller merged 9 commits into
mainfrom
feat/onboard-without-contract
Jul 3, 2026
Merged

Feat/onboard without contract#1139
jordividaller merged 9 commits into
mainfrom
feat/onboard-without-contract

Conversation

@jordividaller

@jordividaller jordividaller commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Add new step Contracts Options leading to choose "without an agreement" option which lead to review screen.

https://www.loom.com/share/4c9be8a23778445798fe5d9e365012ce

How to test:

  • Open example app
  • Create contractor
  • Select without an agreement and finish the flow

Note

Medium Risk
Alters contractor onboarding step ordering and branching tied to employment contract origin; incorrect visibility or API persistence could skip required contract steps or leave employments in the wrong state, though coverage includes the customer-provided shortcut path.

Overview
Adds a Contract options step after pricing plan so employers choose Remote’s contractor agreement or continue without an agreement (customer-provided contract).

Choosing without an agreement (provided_by_customer) drops eligibility questionnaire (when it would apply), contract details, and contract preview from the step list and advances to review after persisting the choice via POST /v1/employments/{employment_id}/contract-origin. The Remote-agreement path is unchanged aside from passing through the new step.

The SDK exposes ContractOriginStep, a JSON-schema radio form, and skipSteps now supports contract_origin. The example app wires a custom radio UI and styles for that step.

Reviewed by Cursor Bugbot for commit fc967e9. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 225.83 kB 224.03 kB +1.8 kB (+0.8%) 🔴
Total (raw) 610.85 kB 606.31 kB +4.54 kB (+0.7%) 🔴
CSS (gzip) 20.89 kB 20.89 kB 0 B (0%) 🟢
CSS (raw) 109.09 kB 109.09 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 225.83 kB / 250 kB (90.3%)
  • ✅ Total raw: 610.85 kB / 650 kB (94.0%)
  • ✅ CSS gzipped: 20.89 kB / 25 kB (83.5%)

Largest Files (Top 5)

  1. chunk-Y3CJRZLA.js - 14 kB (0 B (0%))
  2. styles.css - 10.44 kB (0 B (0%))
  3. index.css - 10.44 kB (0 B (0%))
  4. chunk-4RVJJ33G.js - 6.43 kB (new)
  5. index.js - 6.35 kB (+22 B (+0.3%))
View All Files (345 total)
File Size (gzip) Change
chunk-Y3CJRZLA.js 14 kB 0 B (0%)
styles.css 10.44 kB 0 B (0%)
index.css 10.44 kB 0 B (0%)
chunk-4RVJJ33G.js 6.43 kB new
index.js 6.35 kB +22 B (+0.3%)
chunk-BYDNNJHZ.js 6.08 kB 0 B (0%)
chunk-G2LZFGZA.js 5.31 kB 0 B (0%)
chunk-4LQDSIUG.js 4.82 kB new
chunk-A5SRPVT2.js 4.76 kB new
chunk-S4QKVG2B.js 3.89 kB 0 B (0%)

✅ Bundle size check passed

Comment thread src/flows/ContractorOnboarding/hooks.tsx Outdated
Comment thread src/flows/ContractorOnboarding/hooks.tsx Outdated
Comment thread src/flows/ContractorOnboarding/hooks.tsx
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-ktqyeld91-remotecom.vercel.app
Latest Commit:fc967e9

Deployed with vercel-action

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-ovlk9d5bc-remotecom.vercel.app
Latest Commit:fc967e9

Deployed with vercel-action

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit acfbe63. Configure here.

Comment thread src/flows/ContractorOnboarding/hooks.tsx Outdated
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 88.48% 88.42% +0.06% 🟢
Statements 87.89% 87.83% +0.06% 🟢
Functions 84.99% 84.88% +0.11% 🟢
Branches 79.78% 79.70% +0.08% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3879 / 4384
  • Coverage: 88.48%
  • Change: +0.06% (37 lines)
Statements Coverage
  • Covered: 3941 / 4484
  • Coverage: 87.89%
  • Change: +0.06% (38 statements)
Functions Coverage
  • Covered: 1053 / 1239
  • Coverage: 84.99%
  • Change: +0.11% (9 functions)
Branches Coverage
  • Covered: 2427 / 3042
  • Coverage: 79.78%
  • Change: +0.08% (24 branches)

✅ Coverage check passed

@jordividaller jordividaller requested a review from cammellos July 3, 2026 12:37
@jordividaller jordividaller merged commit 686f25a into main Jul 3, 2026
11 checks passed
@jordividaller jordividaller deleted the feat/onboard-without-contract branch July 3, 2026 13:08
@cursor cursor Bot mentioned this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants