Fix steps order bug#1147
Merged
jordividaller merged 3 commits intoJul 8, 2026
Merged
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (345 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1ee7a9d. Configure here.
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
cammellos
approved these changes
Jul 8, 2026
jordividaller
deleted the
fix/pbyr-4243-invert-questionnaire-and-contract-options-steps
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When selecting Contractor of record in pricing plan, eligibility questionnaire should be the next step and was after contract origin selection.
Other bug discovered when fixing that one
When selecting 'Contractor Management Plus' or 'Contractor of Record' pricing plans, the contract origin selection step is missing from the Remote platform (though it is present in the SDK). This creates a bug when attempting to complete the flow without an agreement on the 'Contractor of Record' plan, as the API requires contract details for this case.
What has been done
Now contract origin is considered after Eligibility Questionnaire (even if the two steps should never be displayed in the same flow).
Contract origin step is now displayed only if we are in 'contractor management' pricing plan.
How to test
With our example app in the SDK
Note
Medium Risk
Changes multi-step navigation and skip logic for pricing plans; incorrect gating could block or expose wrong steps in production onboarding.
Overview
Fixes contractor onboarding step order and which steps appear for each pricing plan.
Eligibility vs contract origin: In
buildSteps, Contract Options (contract_origin) now comes after Eligibility Questionnaire, so Contractor of Record goes pricing → eligibility → contract details instead of hitting contract origin first.Plan-specific contract origin: The contract origin step is shown only for Contractor Management (standard).
includeContractOriginis driven byselectedPricingPlan === contractorStandardProductIdentifier(andskipSteps), so Plus and COR skip it—matching platform behavior and avoiding broken “without agreement” flows on COR.“Without an agreement”: Treating the flow as customer-provided contract now also requires the standard product, so Plus/COR aren’t classified that way from stale origin alone.
Tests and
fillContractorSubscriptionhelpers are updated for the new order and plan gating, including switching from CM to CM+ mid-flow.Reviewed by Cursor Bugbot for commit c874153. Bugbot is set up for automated code reviews on this repo. Configure here.