Skip to content

Refactor to permit jsModify to work on contractOriginStep#1148

Merged
jordividaller merged 1 commit into
mainfrom
fix/pbyr-4244-contract-origin-step-jsmodify-available
Jul 8, 2026
Merged

Refactor to permit jsModify to work on contractOriginStep#1148
jordividaller merged 1 commit into
mainfrom
fix/pbyr-4244-contract-origin-step-jsmodify-available

Conversation

@jordividaller

@jordividaller jordividaller commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Description

jsmodify was not working to override title and description on the radio buttons in ContractOriginStep


Note

Low Risk
Localized to contract-origin UI and schema customization; no auth or persistence logic changes beyond passing existing jsfModify through.

Overview
Contract origin step now honors options.jsfModify.contract_origin the same way other onboarding steps do: the hook passes that block into useGetContractOriginSchema, and the flow options type includes contract_origin?: JSFModify.

The example app stops hardcoding step headings and radio copy (CONTRACT_ORIGIN_CONTENT and the contract_origin case layout). ContractOriginRadio renders the field title/description from fieldData and each option’s label/description from the schema, so overrides from jsfModify (including oneOf titles) actually show up.

Default France-facing copy in the demo is moved into jsfModify.contract_origin on ContractorOnboardingFlow. A test asserts a custom contract_origin field title replaces the default “Contract options” text.

Reviewed by Cursor Bugbot for commit 1abbf24. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 226.57 kB 226.56 kB +7 B (+0.0%) 🔴
Total (raw) 612.55 kB 612.5 kB +50 B (+0.0%) 🔴
CSS (gzip) 21.45 kB 21.45 kB 0 B (0%) 🟢
CSS (raw) 110.5 kB 110.5 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 226.57 kB / 250 kB (90.6%)
  • ✅ Total raw: 612.55 kB / 650 kB (94.2%)
  • ✅ CSS gzipped: 21.45 kB / 25 kB (85.8%)

Largest Files (Top 5)

  1. chunk-Y3CJRZLA.js - 14 kB (0 B (0%))
  2. styles.css - 10.73 kB (0 B (0%))
  3. index.css - 10.73 kB (0 B (0%))
  4. chunk-Q5OFEWTH.js - 6.43 kB (0 B (0%))
  5. index.js - 6.34 kB (+1 B (+0.0%))
View All Files (345 total)
File Size (gzip) Change
chunk-Y3CJRZLA.js 14 kB 0 B (0%)
styles.css 10.73 kB 0 B (0%)
index.css 10.73 kB 0 B (0%)
chunk-Q5OFEWTH.js 6.43 kB 0 B (0%)
index.js 6.34 kB +1 B (+0.0%)
chunk-BYDNNJHZ.js 6.08 kB 0 B (0%)
chunk-G2LZFGZA.js 5.31 kB 0 B (0%)
chunk-ZR7OIZWE.js 4.83 kB new
chunk-A5SRPVT2.js 4.76 kB 0 B (0%)
chunk-S4QKVG2B.js 3.89 kB 0 B (0%)

✅ Bundle size check passed

@jordividaller jordividaller requested a review from cammellos July 7, 2026 16:53
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

⚪ Coverage unchanged

Metric Current Previous Change Status
Lines 88.45% 88.45% 0%
Statements 87.86% 87.86% 0%
Functions 84.83% 84.83% 0%
Branches 79.83% 79.83% 0%

Detailed Breakdown

Lines Coverage
  • Covered: 3882 / 4389
  • Coverage: 88.45%
  • Change: 0% (0 lines)
Statements Coverage
  • Covered: 3944 / 4489
  • Coverage: 87.86%
  • Change: 0% (0 statements)
Functions Coverage
  • Covered: 1051 / 1239
  • Coverage: 84.83%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 2438 / 3054
  • Coverage: 79.83%
  • Change: 0% (0 branches)

✅ Coverage check passed

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-ia19pz1tf-remotecom.vercel.app
Latest Commit:1abbf24

Deployed with vercel-action

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-gpu7yzuth-remotecom.vercel.app
Latest Commit:1abbf24

Deployed with vercel-action

@jordividaller jordividaller merged commit 7f0e0f8 into main Jul 8, 2026
11 checks passed
@jordividaller jordividaller deleted the fix/pbyr-4244-contract-origin-step-jsmodify-available branch July 8, 2026 15:06
@cursor cursor Bot mentioned this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants