Skip to content

fix(employment-agreements) - fix the step when devs skip country#1184

Merged
gabrielseco merged 6 commits into
mainfrom
pbyr-4316-new-linear-issue-created-in-triage
Jul 23, 2026
Merged

fix(employment-agreements) - fix the step when devs skip country#1184
gabrielseco merged 6 commits into
mainfrom
pbyr-4316-new-linear-issue-created-in-triage

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

We didn't check that the feature worked when devs use skipSteps=['select_country']

Fix that and also fix examples to allow reuse, some tests testing the behavior and reorder a bit the stucture of the folder to allow reusage a bit

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 256.66 kB 256.62 kB +33 B (+0.0%) 🔴
Total (raw) 704.16 kB 704.03 kB +128 B (+0.0%) 🔴
CSS (gzip) 21.69 kB 21.69 kB 0 B (0%) 🟢
CSS (raw) 112.66 kB 112.66 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 256.66 kB / 350 kB (73.3%)
  • ✅ Total raw: 704.16 kB / 850 kB (82.8%)
  • ✅ CSS gzipped: 21.69 kB / 25 kB (86.7%)

Largest Files (Top 5)

  1. chunk-Y3CJRZLA.js - 14 kB (0 B (0%))
  2. styles.css - 10.84 kB (0 B (0%))
  3. index.css - 10.84 kB (0 B (0%))
  4. chunk-AVIZTG4K.js - 8.54 kB (0 B (0%))
  5. index.js - 6.56 kB (+1 B (+0.0%))
View All Files (400 total)
File Size (gzip) Change
chunk-Y3CJRZLA.js 14 kB 0 B (0%)
styles.css 10.84 kB 0 B (0%)
index.css 10.84 kB 0 B (0%)
chunk-AVIZTG4K.js 8.54 kB 0 B (0%)
index.js 6.56 kB +1 B (+0.0%)
chunk-746NEWTS.js 6.44 kB 0 B (0%)
chunk-AS7SJDU5.js 6.4 kB 0 B (0%)
chunk-G2LZFGZA.js 5.31 kB 0 B (0%)
chunk-3JPCU7VV.js 4.86 kB new
chunk-43FMKELR.js 4.77 kB 0 B (0%)

✅ Bundle size check passed

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

✅ Coverage increased! 🎉

Metric Current Previous Change Status
Lines 83.48% 83.46% +0.03% 🟢
Statements 82.86% 82.83% +0.03% 🟢
Functions 81.41% 81.40% +0.01% 🟢
Branches 75.72% 75.59% +0.13% 🟢

Detailed Breakdown

Lines Coverage
  • Covered: 3978 / 4765
  • Coverage: 83.48%
  • Change: +0.03% (3 lines)
Statements Coverage
  • Covered: 4042 / 4878
  • Coverage: 82.86%
  • Change: +0.03% (3 statements)
Functions Coverage
  • Covered: 1073 / 1318
  • Coverage: 81.41%
  • Change: +0.01% (1 functions)
Branches Coverage
  • Covered: 2486 / 3283
  • Coverage: 75.72%
  • Change: +0.13% (8 branches)

✅ Coverage check passed

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-hfxby04nu-remotecom.vercel.app
Latest Commit:7e31cbf

Deployed with vercel-action

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-9himsmn58-remotecom.vercel.app
Latest Commit:7e31cbf

Deployed with vercel-action

@gabrielseco gabrielseco changed the title Pbyr 4316 new linear issue created in triage fix(employment-agreements) - fix the step when devs skip country Jul 23, 2026
@gabrielseco gabrielseco self-assigned this Jul 23, 2026

@jordividaller jordividaller left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reordering example folders it is really better like this :).

@gabrielseco
gabrielseco merged commit 3b60784 into main Jul 23, 2026
10 checks passed
@gabrielseco
gabrielseco deleted the pbyr-4316-new-linear-issue-created-in-triage branch July 23, 2026 09:50
@gabrielseco gabrielseco mentioned this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants