Skip to content

Ship tests and docs with tarball.#91

Merged
Lukasa merged 1 commit intorequests:masterfrom
ralphbean:master
Nov 1, 2013
Merged

Ship tests and docs with tarball.#91
Lukasa merged 1 commit intorequests:masterfrom
ralphbean:master

Conversation

@ralphbean
Copy link
Contributor

Please. :)

@Lukasa
Copy link
Member

Lukasa commented Oct 31, 2013

Hmm. I need to be convinced that doing this is a good idea. If you desperately want them, I tag every release on GitHub, so a tarball from here will include them. Why should I force everyone who downloads from the cheeseshop to download the docs and the tests?

@ralphbean
Copy link
Contributor Author

I need to be convinced that doing this is a good idea.

I can't be that convincing.. but I'm packaging this for Fedora. We like to run the test suite during our build process if we can (and so it needs to be included in the tarball).

I could just get the tarball from github, but:

  • PyPI is the "canonical" upstream (this is up for debate, I guess)
  • It is kind of a pain to automate grabbing the tagged tarballs from github.

I'm fine with whatever you decide. ;)

@sigmavirus24
Copy link
Contributor

I'm 👍 even though I don't contribute much here. It makes all package maintainers' lives easier. If requests-oauthlib is packaged for Debian they'll likely ask for the same. I can't speak to Arch though.

@Lukasa
Copy link
Member

Lukasa commented Nov 1, 2013

Alright then, that suits me fine. I don't object strongly, so let's do it. =D

Lukasa added a commit that referenced this pull request Nov 1, 2013
Ship tests and docs with tarball.
@Lukasa Lukasa merged commit 0fb9b7d into requests:master Nov 1, 2013
@ralphbean
Copy link
Contributor Author

Hooray! \ó/

Thanks @Lukasa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants