refactor: clean up shared feature helpers - #340
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jderochervlk
force-pushed
the
codex/option5-helper-cleanup
branch
from
August 4, 2026 17:31
6aad67b to
105cdfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 30 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #339.
Summary
src/storage/CacheTypes.resWebWorkersTypesto the Workers folderDOM.resBaseFilehelper while preservingFileTypes.blobandFileTypes.filealiasesWhy this cleanup is last
Earlier PRs temporarily kept
WebWorkersTypeswith Storage andBaseFilein core so folder moves could remain mechanical. With the complete graph in place, the ownership directions are now explicit: Workers depends on Storage, and File aliases the small foundational identities in DOM.Resolved temporary state
BaseFilemodule is removedReview focus
Verification
node_modules/.bin/rescript build --prod --features WebAPI.DOMnode_modules/.bin/rescript build --prod --features WebAPI.Storagenode_modules/.bin/rescript build --prod --features WebAPI.Workersnode_modules/.bin/rescript build --prod --features WebAPI.Windownpm run buildnpm testnpm run format:checkgit diff --check