test: guard the public feature graph - #341
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1091517f92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const runRescript = (args) => | ||
| spawnSync(rescriptExecutable, args, { | ||
| cwd: repoRoot, | ||
| encoding: "utf8", | ||
| }); |
There was a problem hiding this comment.
Launch the Windows ReScript shim through cmd.exe
On Windows, this selects rescript.cmd but passes it directly to spawnSync without shell: true or cmd.exe /c. Windows batch shims cannot be executed directly this way, so npm run check:features fails before the first feature build; invoke the shim through the command shell or use a cross-platform executable resolution strategy.
Useful? React with 👍 / 👎.
1091517 to
987fa29
Compare
Tracking issue: #342
Stack context
Part 31 and final PR of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #340.
Summary
npm run check:featuresto validate the exact 27 supported public featuresWebAPI.*feature independentlyrescript.jsonpublic module listsGuardrails
The new check fails when:
Documentation update
The old documentation pipeline still read the pre-Option-5 migration taxonomy and expected nested interface routes. API pages and navigation now follow the actual flat public surface, producing one page per public interface module.
Temporary state
None from the Option 5 migration remains. Future feature changes should update the explicit contract and pass the per-feature compiler checks in this PR.
Review focus
Verification
npm run check:features(all 27 supported features)npm run buildnpm testnpm run build:docs(303 static pages)npm run format:checkgit diff --check