fix(viewer): export evaluation set links to canonical test_set.jsonl and Inference capitalise - #135
Merged
Conversation
The `Export evaluation set` button on the suite page linked to `/api/download/{suite}/seeds.jsonl`. The catch-all download handler enforces a basename allowlist and `seeds.jsonl` is not on it, so every click returned 403 and no file ever reached the user. The legacy `seeds.jsonl` artifact was also renamed to `test_set.jsonl` long ago by scripts/migrate_artifacts_to_pr23_vocab.py; the button never got the memo.
Point the anchor at the canonical `test_set.jsonl` (already in ALLOWED_FILES) and pin both filenames via the HTML `download` attribute. Add tests/test_viewer_export_evaluation_set.py that asserts (a) the button URL matches an allowlisted basename, (b) test_set.jsonl stays in the allowlist, (c) the legacy `seeds.jsonl` name never reappears in the allowlist.
Fixes #103.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
RUN_STAGE_LABELS mapped a stale stage key 'rollout' to 'Inference', but real manifests emit 'inference', so the pipeline panel rendered the raw lowercase label while 'Scoring' next to it was capitalized. Update the label and tooltip keys to match what the runner actually writes to manifest.stages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AaronAspinwall123
changed the title
tangym
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Export evaluation setbutton on the suite page linked to/api/download/{suite}/seeds.jsonl. The catch-all download handler enforces a basename allowlist andseeds.jsonlis not on it, so every click returned 403 and no file ever reached the user. The legacyseeds.jsonlartifact was also renamed totest_set.jsonllong ago by scripts/migrate_artifacts_to_pr23_vocab.py; the button never got the memo.Point the anchor at the canonical
test_set.jsonl(already in ALLOWED_FILES) and pin both filenames via the HTMLdownloadattribute. Add tests/test_viewer_export_evaluation_set.py that asserts (a) the button URL matches an allowlisted basename, (b) test_set.jsonl stays in the allowlist, (c) the legacyseeds.jsonlname never reappears in the allowlist.Fixes #103.