Hygiene: finish public terminology cleanup - #266
Merged
Conversation
Replace remaining user-facing seed terminology with test set/test case wording and capitalize the Inference stage consistently, while preserving intentional overrefusal and internal legacy keys. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 53766e86-ef96-4fd8-b3d9-ed60ac272fcf
Use test set for collections, test case for individual rows, scenario for multi-turn scores, and Inference only when naming the pipeline stage, following PR #23. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 53766e86-ef96-4fd8-b3d9-ed60ac272fcf
changliu2
approved these changes
Jul 23, 2026
changliu2
left a comment
changliu2
left a comment
Collaborator
There was a problem hiding this comment.
Approving — clean, tightly-scoped public-terminology pass.
Verified:
- Canonical #23 vocab applied consistently:
Seed Generation→Test Set Generation,seed id→test case ID, and "policy + seeds" → "a behavior and its test set" on the new-run screen. overrefusalcorrectly preserved — the diff never touches it, and flagging #152 as partially stale is right: it's an intentional built-in judge dimension now, not a rename target.- Legacy internal keys untouched — only the
seeds:label changes; the object key stays, so no route/stage behavior changes. Inferencecapitalized only as the pipeline-stage noun, consistent with #135. Thecsv/[suite_id]404 "No scenario scores found" reads correctly for the audit/scenario export path.- CI green (viewer-build + CodeQL); label-only diff, no logic changes.
changliu2
added a commit
that referenced
this pull request
Jul 24, 2026
Merging main into this branch surfaced a pre-existing mismatch: #266 capitalized the viewer label to 'Refused before Inference' (pipeline-stage noun) but test_viewer_server_artifacts.py still asserted the lowercase form in three places (previewTesterLabel / previewDrawerLabel / scoredTesterLabel). #266 was viewer-only so Tier 1 unit tests never ran on it. Align the assertions with the intentional capitalized label. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d429caee-f2da-4fb0-8b2c-d0eff7cf40a3
AaronAspinwall123
added a commit
to ricfog/ASSERT
that referenced
this pull request
Jul 28, 2026
The viewer stop-reason label is 'Refused before Inference' (capital I, result-view.ts:20), but three assertions in test_load_run_page_data_exposes_refusal_stop_reason_display still expected lowercase 'inference'. This mismatch is inherited from main (present at base 7a6e95b, from responsibleai#266's terminology cleanup) and fails Tier 1 unit tests. Align the test to the code label; mirrors the fix in a403385. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ef089fbc-c563-427f-b8e1-f87370e98c76
AaronAspinwall123
added a commit
that referenced
this pull request
Jul 29, 2026
* Fix permissibility-split policy violation metrics * test(viewer): align inference stop-reason label expectation The viewer stop-reason label is 'Refused before Inference' (capital I, result-view.ts:20), but three assertions in test_load_run_page_data_exposes_refusal_stop_reason_display still expected lowercase 'inference'. This mismatch is inherited from main (present at base 7a6e95b, from #266's terminology cleanup) and fails Tier 1 unit tests. Align the test to the code label; mirrors the fix in a403385. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ef089fbc-c563-427f-b8e1-f87370e98c76 * fix(export): derive not_permissible_policy_violation_rate from node split export_suite_results.py still computed not_permissible_policy_violation_rate by row-filtering on the originating permissibility label and reading the row-level policy_violation verdict - the overrefusal-contaminated approach issue #272 calls out. Reuse compute_policy_violation_by_permissibility so the export matches the CLI/results and viewer definition: one vote per conversation over non-permissible nodes only. Keeps permissible_overrefusal_rate on the ok-filtered permissible rows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ef089fbc-c563-427f-b8e1-f87370e98c76 --------- Co-authored-by: Aaron Aspinwall <94419331+AaronAspinwall123@users.noreply.github.com> Co-authored-by: AaronAspinwall123 <aaron.aspinwall@gmail.com> Copilot-Session: ef089fbc-c563-427f-b8e1-f87370e98c76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Set Generationand test case terminology defined in refactor(p2m): terminology migration to maximize broad-developer recognition #23Inferenceonly when referring to the pipeline stage, consistent with fix(viewer): export evaluation set links to canonical test_set.jsonl and Inference capitalise #135overrefusalterminology and legacy internal route/stage keysIssue #152 is partially stale:
overrefusalis now an intentional built-in judge dimension. This PR applies only the remaining valid public terminology cleanup and follows the canonical vocabulary established in #23.Closes #152