Skip to content

Save Check Answer progress and fix Enter handling#1294

Merged
jaykim1213 merged 7 commits into
devfrom
jay/refactorCheckAnswerOnEnter
Jul 16, 2026
Merged

Save Check Answer progress and fix Enter handling#1294
jaykim1213 merged 7 commits into
devfrom
jay/refactorCheckAnswerOnEnter

Conversation

@jaykim1213

@jaykim1213 jaykim1213 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Give a longer description of what this PR addresses and why it's needed

  • Saves Check Answer progress, including attempts used and correctness, so it does not reset
  • Moves Enter handling into NextButton, so Enter runs Check Answer first when available, then falls back to Next

Documentation

Tracking issue: revisit-studies/reVISit-studies.github.io#238

  • Done
  • N/A

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

🪓 PR closed, deleted preview.

@jaykim1213 jaykim1213 changed the title Refactor Check Answer Enter handling Save Check Answer progress and fix Enter handling Jul 9, 2026

@JackWilb JackWilb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes because the new Check Answer progress state is only persisted when advancing, so refresh can reset limited training attempts.

Comment thread src/components/response/ResponseBlock.tsx
Base automatically changed from jay/checkAnswerBug to dev July 13, 2026 19:51

@JackWilb JackWilb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the persistence issue. I verified that each Check Answer attempt is now saved immediately, refresh restores both partial and terminal training state, and the focused tests, typecheck, lint, and build pass. I did not find any new actionable issues in the follow-up changes.

@jaykim1213
jaykim1213 merged commit b6d1527 into dev Jul 16, 2026
6 of 7 checks passed
@jaykim1213
jaykim1213 deleted the jay/refactorCheckAnswerOnEnter branch July 16, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants