- report typo on RV asm site
- auditing MIT 6.004 Computation Structures class
- https://6004.mit.edu/web/fall19/
- pretty great so far, starts with basics of binary and asm for RISC-V, goes through desiging a simple CPU
- reading through RISC-v asm manual
- https://rv8.io/asm.html
- noticed typo in "Section Header", "Section Headers provice size [...]"
- https://rv8.io/asm.html
- starting reading Tock real-time OS manual
- https://www.tockos.org/
- written in Rust
- uses type system to provide safety since there's no MMU on most embedded platforms
- event driven execution model that uses no heap allocation, so the kernel won’t run out of memory
- has interesting model to protect programs from each other and only allow them to talk to the peripherals they should have access to
- no resource overhead
- process memory isolated using MPU
- seamlessly put the hardware into the lowest possible sleep state based on application requirements
- No explicit power-management is required from the application
- supports only Cortex-M so far (I think?)
- caught up on older hackerrank "30 days of code"
- linked list, ugh
- still 4 days behind :)
- started learning about new RISC-V open-source CPU
- got linux built and running in qemu
- https://risc-v-getting-started-guide.readthedocs.io/
- started exploring Zephyr (RTOS) vs. FreeRTOS
- FreeRTOS has AWS support which is interesting:
- https://aws.amazon.com/freertos/
- Amazon has been contributing quite a bit for the past few years, including RISC-V support
- FreeRTOS code is pretty small and simple, Zephyr seems like a more modern project but not as mature. Going to check out both.
- FreeRTOS has AWS support which is interesting:
- continued Hackerrank "30 days of code"
- Day 20, although I need to go back and pick up a few I've missed
- Signed up for Coursera Algorithms course
- still on week 1, going well so far.
- worked on proposals
- preparing to land omnijar/system add-on corruption patch
- https://bugzilla.mozilla.org/show_bug.cgi?id=1515712
- try run, more local testing, etc.
- slightly modified data collection request
- decided to expire in 71 and then re-evaluate
- manual test for xpi/jar corruption patch with test signed ommnijar
- https://bugzilla.mozill a.org/show_bug.cgi?id=1515712
- worked on upcoming system add-on
- reviewed patch to remove prio pilot ping
- https://phabricator.services.mozilla.com/D26004
- the actual libprio and PrioEncoder implementations remain, this is just the test data we put in the main ping.
- meetings
- reviewed bdanforth's WIP devtools patch
- reviewed a few upcoming SAO extensions
- advised on architecture for upcoming experiment
- testing signed omni jar
- landed version 1.5 of libprio in m-c
- meetings
- worked on proposals
- meetings
- worked on proposals
- checking out c2rust, tried converting libprio
- https://github.com/mozilla/libprio/compare/master...rhelmer:rust?expand=1
- links and compiles, test suite close to passing
- meetings
- worked on proposals
- meetings
- some upstream Prio work
- merged PR to remove precomputed table of roots
- mozilla/libprio#69
- also tagged release 1.5 and filed bug + review request to vendor in m-c
- PTO (half-day)
- proposal writing
- proposal writing
- started tracking down intermitten in prio tests, but Henry found it first
- mozilla/libprio#71
- deferred further questions to Franziskus
- proposal writing
- some upstream Prio work
- started reviewing PR to remove precomputed table of roots
- noticed an existing intermittent in the prio tests
- meetings
- reviewed import of WebCompat
- responded to needinfo about removing Prio pilot ping
- finished "make PrioEncoder usable from C++" review
- consulted with folks for a few issues
- mozilla-signed extensions
- addon updater timer frequency and testing
- reviews
- rename price-wise to price-tracker
- make PrioEncoder usable from C++
- consulted about potential issues with upcoming experiments
- responded to questions on upcoming experiment
- research for upcoming project
- worked on moving shield-addon-utils in-tree
- showed preliminary patch to Rehan who has been looking at this too
- https://gist.github.com/rhelmer/b18f50f668b0d6336997c30f6727dcfd
- starts up OK, could use help testing it though.
- quick meeting about omni jar corruption, manual test being run
- worked on moving shield-addon-utils in-tree
- going pretty well, should be able to re-use quite a bit. Was hoping to be able to load the existing commonjs modules from JSMs but there just isn't great support for that for window-less code like this.
- pre-review of Prio+Telemetry integration
- PTO
- finished reviewing latest federated learning experiment PR
- https://github.com/mozilla/federated-learning-v2-study-addon/pull/5/files
- lgtm,just a few nits
- discussed devtools issues w/ bdanforth
- followed along on some existing and upcoming experiments
- it's working now, need to see if this can land pre-Fission
- drive-by look at upcoming Telemetry Origin (uses Prio)
- continued reviewing latest federated learning experiment PR
- discussed devtools issues w/ bdanforth
- need this for inspecting the built-in, and better, k/v storage for extensions (
browser.storage.local
) - currently prefs are used for generic k/v which is bad and wrong
- these get automatically wiped on extension uninstall too which is nice
- experiments extensions will still need to be able to flip prefs, but at least this way we'll have to hardcode and limit the prefs it has access to at build/packaging time
- need this for inspecting the built-in, and better, k/v storage for extensions (
- followed along on some existing and upcoming experiments
- responded to another incoming outreachy request
- chatted with outreachy person (via email) working on bug 1230688 about build failure problems
- reviewed bdanforth's experiments extension storage proposal
- started reviewing federated learning extension
- reviewed new search extension code
- mainly just a question about whether these should be considered "system add-ons" or not
- https://bugzilla.mozilla.org/show_bug.cgi?id=1496075#c49
- planned transition for current system add-on update (Firefox Monitor) to built-in default
- asked to review part of a change to how search extensions will be loaded as built-in add-ons
- good opportunity to evolve the "system add-on" support we have now
- https://phabricator.services.mozilla.com/D17212#578569
- responded to mentor request on good-first-bug I filed on an add-ons manager test:
- landed fix for bug to stop public export of C++ symbols from msgpack (libprio dependency) from libxul.dll
- stuck inside all day from flooded roads
- put up patch to clean up msgpack build so we can stop exporting symbols from libxul.dll
- currently, libprio's
moz.build
just reaches into msgpack's vendored dir - new patch makes it so msgpack gets built separately and exports header files properly
- https://bugzilla.mozilla.org/show_bug.cgi?id=1523312
- currently, libprio's
- figured out a path forward for exposing debugging UI for experiments extensions to devs/QA
- doing some self-triage on open bugs
- ask chutten if he is planning to use
libprio
directly in a few bugs so I could potentially just close out a fewPrioEncoder
-specific bugs - managed to close out this old "off-train updates should get perf/correctness testing" bug \o/
- (finally) followed up on old bug about improving feedback mechanisms for experiments
- untangled some build issues with
libprio
andmsgpack
so we can stop exportingmsgpack
inxul.dll
- unassigned a bunch of old non-critical Add-ons Manager related bugs and set myself as mentor
- ask chutten if he is planning to use
- spent some time watching a talk from All Hands about upcoming Fission changes and how they impact working on frontend Firefox
- followed up on omni jar/xpi corruption bug
- commented in bdanforth's proposal to use options page and browser storage instead of prefs
- biancadanforth/webextensions-examples#2
- lgtm overall, have a few questions/suggestions to see if we can not have to bundle anything with extension
- planning upcoming work landing shield utils in-tree
- opened PR for libprio security fix
- mozilla/libprio#65
- had to fix a bug causing travis failures
- mozilla/libprio#66
- need to make this more robust, although it's just an occasional annoyance so not the biggest deal. tl;dr is that libprio needs a newer NSS than Travis-CI's ubuntu distro (trusty) provides, so the latest packages are downloaded and installed, and these URLs can change over time.
- client impl guidelines for experiments PR up for review
- mozilla/data-docs#248
- this includes bdanforth's work on using Mozilla CI to test extensions, mentioned previously in this status doc
- testing optimizations for tryserver+extension tests
- minimal set of perf tests
- leak tests
- use artifact builds for above if all possible ^
- commented on Prio+Telemetry implementation
- chatted w/ chutten a bit, leaving ultimate decisions up to him and Telemetry client folks, but I am available to chat whenever they need. Discussed some C++ vs. JS implementation details
- libprio is flexible enough to accomodate both, probably this will be behind the nsITelemetry (C++) and Prio will then be behind Telemetry, Prio probably does not need to be exposed to any other components.
- chatted w/ chutten a bit, leaving ultimate decisions up to him and Telemetry client folks, but I am available to chat whenever they need. Discussed some C++ vs. JS implementation details
- reached out to folks implementing upcoming experiments, making them aware of above and also answering questions and concerns from folks running it.
- catching up after flu
- reviewed an upcoming extension
- reviewed bdanforth's github+taskcluster integration for testing extensions
- followed up on omni.jar signing bug
- COSE signatures for langpack doesn't seem to be working, needinfo'd aswan
- followed up on a few Prio issues and emails
- details on signing
- responded to needinfos about moving Prio from main ping to its own in Telemetry
- reviewed doc for upcoming proposal
- still recovering from sickness somewhat
- attached patch to bug to stop exporting msgpack outside of libxul
- working on defining Q2 goals
- PTO (out sick)
- looked at potential bug
- landed old bug about hiding system add-ons from
about:addons
during updates - started reviewing bdanforth's PR for github+tc support
- experiments-related meeting
- started sharing the experiments client impl guidelines with folks
- requested review on libprio update in Firefox to pick up 1.4 release
- prepared document for experiments engineering guidelines.
- filed bug to check omni jars and system add-on XPIs for corruption
- bug 1515712
- reviewed bdanforth's work getting TC+GH integration working with extensions, so mozilla tryserver pushes can be triggered from github PRs
- reviewed security bug in proof-checking code for libprio
- mozilla/libprio#60
- also fixed minor CI issue mozilla/libprio#61
- filed mozilla bug to pull in latest libprio
- https://bugzilla.mozilla.org/show_bug.cgi?id=1518728
- we're not using it on release or beta yet, but should be uplifted to beta just in case.
- filed mozilla bug to pull in latest libprio
- reviewed UA spoofing system add-on update
- worked with bdanforth on using Mozilla CI for testing experiments extensions
- biancadanforth/taskcluster-integration-poc#2
- discussing w/ taskcluster folks how we could satisfy our requirements for having a smooth extensions workflow
- all-hands
- reviewed indexedDB shield study
- Prio-related meetings and planning
- H1 '19 experiments infra planning
- build problems w/
baldrdash
crashing on m-c w/ macOS Mojave- https://bugzilla.mozilla.org/show_bug.cgi?id=1495610#c13 seemed to do the trick
- triaged one-off-system-add-ons GH repo open PRs
- reviewed libprio PR to fix bool limit
- Prio Pilot launched
- published on hacks blog
- filed + fixed a followups to make it easier for other folks to add more data from Telemetry
- reviewed JESTER pioneer study
- provided review/feedback on putting search plugins in omni jar
- reviewed Block Autoplay study
- reviewed Side View study
- looked into problems with old test_system_update_fail test
- investigated feature gate C++ suppport
- looked at review feedback for using base64 for prio-encoded data
- filed bug to allow
PrioEncoder.encode()
to accept public keys in constructor
- meetings
- finished reviewing webcompat fennec webextension conversion
- landed coverage ping in-tree
- responded to comments in client experiments engineering plan
- meetings, 1:1
- first draft at experiments engineering plan
- responded to comments
- figured out problem w/ privileged code in shield study
- only when in XPI form, the panel in the content loads slower from XPI than from file apparently, so need to listen for
DOMContentLoaded
or so
- only when in XPI form, the panel in the content loads slower from XPI than from file apparently, so need to listen for
- followup to pref off Prio telemetry tests if
prio.enabled
is false, so it doesn't bust beta- prio is on by default for Nightly, off everywhere else.
- filed bug
- testing Prio, good initial results for Telemetry shutdown ping
- looks like we have a problem handling subsession splits
- helping out w/ Telemetry patch to fix
- https://bugzilla.mozilla.org/show_bug.cgi?id=1497365
- landed on m-c \o/ will verify tomorrow, once it goes to Nightly.
- looks like we have a problem handling subsession splits
- helping out with shield study extension issues
- shipped Telemetry Coverage SAO to Fx 45-60
- reviewed change to bump GMP (video and DRM plugins)
- looked into webcompat WE conversion android build problems
- got coverage ping ready to land in-tree
- https://bugzilla.mozilla.org/show_bug.cgi?id=1492656
- doing secondary data review just to make sure
- reviewed autoplay shield study
- re-visited issue about having so many different client- and server-side update mechanisms
- looked into providing telemetry http fallback (after discussion in slack)
- https://bugzilla.mozilla.org/show_bug.cgi?id=1494571
- considered providing a generic mechanism for this in ServerRequest.jsm, but it's probably too special-purpose to worry too much about it.
- chatted w/ motin re: openwpm experiment
- sent some examples, will put together something more illustrative
- Prio-related
- looked into automated Windows tests
- mozilla/libprio#42
- bit of a slog, flagged issue as "good first issue" though
- filed issue about setting up macOS tests
- mozilla/libprio#43
- also a "good first issue"
- filed issue about replacing msgpack
- mozilla/libprio#41
- low-priority
- met w/ Henry CG, chatted generally and also about maybe Rust for libprio 2.0
- reviewed PRs
- landed PRs
- filed bug about moving libprio init out of static method, to make cleanup simpler
- worked w/ Telemetry server folks on documentation
- looked into automated Windows tests
- followed up on active projects
- NSS bug blocking Prio on Windows fixed \o/
- https://bugzilla.mozilla.org/show_bug.cgi?id=1489691
- will be vendored into m-c soon
- NSS bug blocking Prio on Windows fixed \o/
- fielded questions internally on Telemetry Coverage projet
- https://blog.mozilla.org/data/2018/08/20/effectively-measuring-search-in-firefox/
- responded to folks on HN, reddit forums seem largely OK
- looking at how we can communicate more effectively in future.
- shipped Telemetry Coverage \o/
- https://bugzilla.mozilla.org/show_bug.cgi?id=1487578
- going to do a post-mortem on where we can invest and move faster / estimate better next time
- more advice for JAWS-ESR project
- since ESR is about to do a point-release, going to just land in-tree so advised on that.
- also reviewed https://phabricator.services.mozilla.com/D6191
- Telemetry Coverage extension passed QA, all ready to ship:
- rewriting PrioEncoder standalone manually-run browser-test as unit test
- https://bugzilla.mozilla.org/show_bug.cgi?id=1485620
- turned out to be quite easy to do as a googletest
- https://bugzilla.mozilla.org/show_bug.cgi?id=1485620#c5
- waiting for review
- having Travis-CI
- helped with JAWS-ESR SAO update
- reviewed planned back-out of Fennec GWS/FB UA spoofing SAO
- looked at why Fedora builds are failing w/ libprio enabled
- https://bugzilla.mozilla.org/show_bug.cgi?id=1491289
- just include header path shenanigans... would be nice to re-vendor libprio anyway
- met w/ bdanforth re: experiment perf testing in the field
- we could probably do an experiment just around this and help Firefox out as a whole
- let mobile folks know about libprio and size impact
- attached patch to fix PrioEncoder crash on bad public keys in prefs
- https://bugzilla.mozilla.org/show_bug.cgi?id=1491737
- these are in prefs so we can set remotely, PrioEncoder is supposed to be able to handle it but the problem is that it is a singleton and it fails correctly the first time, but it instantiates the singleton too soon. added a test as well not that we have a basic gtest for it.
- chatted w/ ted re: replacing msgpack dependency on libprio
- libprio only uses it internally for serializing binary data, not used on the wire
- msgpack doesn't support aarch64 at least, probably other bugs / missing things we'll need to fix if we stick with it
- using Rust + Serde from C is an option! We might even be able to move libprio's build system over to Cargo and away from SCons which'd be super cool
- responded to reviewer comments for telemetry coverage extension
- mozilla/one-off-system-add-ons#123
- confirmed that we don't need to send a special UUID or anything, might do this later if we add retry ability
- rewriting this to work on 64+ (webextension-only) and also for old releases will be tricky... maybe factor out the common stuff into scripts that can be run with content privileges. Really only things that need to be privileged are:
- the pref read to see if Telemetry is enabled and
- to grab the update channel and
- the Telemetry UUID (to pass to the sampling function The actual sampling function and the connection to mozilla servers could all be done from content and script could be shared across legacy/webextension+experiments
- rewriting this to work on 64+ (webextension-only) and also for old releases will be tricky... maybe factor out the common stuff into scripts that can be run with content privileges. Really only things that need to be privileged are:
- landed PrioEncoder + Telemetry client patch \o/
- https://bugzilla.mozilla.org/show_bug.cgi?id=1465251
- jumped the gun a little on Telemetry review; talked w/ reviewer and worked it out, Telemetry folks want more formal review process for their module which is totally reasonable, will wait for explicit r+ next time (I had addressed the comments and then landed with a secondary reviewer's r+)
- only macOS and Linux for now, will start sending data as soon as Nightly goes out around 10 PM Pacific
- windows blocked on https://bugzilla.mozilla.org/show_bug.cgi?id=1489691
- I am helping out with this, getting everything going on Windows to test has been a bear..
- instructions are very outdated: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/Building
- readme is a little more modern but build.sh requires a lot of variables to be set up which is really obnoxious
- turns out https://bugzilla.mozilla.org/show_bug.cgi?id=1434943 has a nice patch for Windows + MSVC!
- libprio requires clang though, MSVC C compiler is too old (C90 vs. C99 standard)
- might have to figure out how to get standalone nss+nspr building w/ clang-cl on Windows. This is how the mozilla-central build system does it though so must be doable :)
- I am helping out with this, getting everything going on Windows to test has been a bear..
- windows blocked on https://bugzilla.mozilla.org/show_bug.cgi?id=1489691
- server work happening in https://bugzilla.mozilla.org/show_bug.cgi?id=1465252
- chatted w/ server folk to make sure they know it will be coming in
- looked into snag for open-wpm
- firefox-devtools/har-export-trigger#13 (comment)
- this is... pretty involved. I think we'll probably need to lean on devtools and addons folks for help here.
- Holiday (Labor day)
- PTO
- created public bug for Telemetry Coverage project
- https://bugzilla.mozilla.org/show_bug.cgi?id=1487578
- we now have a way for users to opt-out, and sent instructions to QA with this info.
- Finished up some little PRs to move standalone libprio to Clang (turned out to be a lot of work because Travis uses Ubuntu Trust which is super old! I ended up setting up a local Travis docker install which was worth it), fix opt/debug build config in SCons, and to clean up some undefined behavior in an ASCII version of a stdlib function I added.
- that dang MSVC PrioEncoder patch caused prio to not be built on all platforms, because apparently I forgot how to python
- https://bugzilla.mozilla.org/show_bug.cgi?id=1485946
- easy fix, just embarassing
- PTO rest of the day
- super busy the last few weeks, catching up:
- landed libprio + PrioEncoder, shipped in Nightly \o/
- some followup work
- provided easy way to disable building libprio + PrioEncoder, via MOZ_LIBPRIO flag
- hit this issue with MSVC which is tier-2 and which we will almost certainly never ship again,has an ancient C compiler (C90). Encouraging upstream to make Clang the first-class compiler, since folks like Firefox and Chromium are moving that way anyway.
- set up travis-ci for upstream libprio, so we don't have to wait until we re-vendor the thing into Firefox to find problems.
- re-implemented some ASCII-only versions of std functions like toupper/isxdigit, due to these being locale-dependent
- started looking at moving the libprio (manually run) browser-test over to a proper Firefox unit test
- https://bugzilla.mozilla.org/show_bug.cgi?id=1485620
- asking for advice from DOM folks, thinking that we'll probably want to expose this to JS (for the xpcshell unit test runner) via some new DOM functions which are behind a test-only pref.
- browser-test is C code that invokes xpcshell, but for Firefox what we need is for xpcshell to be able to invoke the native code.
- provided easy way to disable building libprio + PrioEncoder, via MOZ_LIBPRIO flag
- passed the ball over to Telemetry folks
- client integration should be simple, provided sample code
- server integration + analysis probably a bit more involved, pointed to some example code there as well but likely we'll want to build some standalone tools using libprio. I don't think this should be a blocker on getting the client code shipped and starting to collect the data.
- some followup work
- working on Telemetry Coverage
- https://blog.mozilla.org/data/2018/08/20/effectively-measuring-search-in-firefox/
- taking a bit more time than expected but trying to do it right
- investigated problems with OpenWPM study
- mozilla/OpenWPM-WebExtension-Experiment#4
- reached out to rpl and devtools folks, they just missed their GH mentions, on the case now
- landed libprio + PrioEncoder, shipped in Nightly \o/
- reviewed WebCompat GoFaster extension to Fennec
- I think I've ironed out the last of the blockers for the Prio prototype landing in Firefox
- https://bugzilla.mozilla.org/show_bug.cgi?id=1421501
- have a good cross-platform try run now
- put up example usage of Prio for client
- starting rewriting prio integration test for latest API
- mozilla/libprio#7
- got some nice modern JS digs in too
- focused on libprio+firefox cross-platform build issues w/ help from Henry and Franziskus
- reviewed OpenWPM-WebExtension-Experiment
- https://github.com/mozilla/OpenWPM-WebExtension-Experiment/pull/4/files
- don't see anything concerning, will take another look tomorrow
- pushed new patch, few questions for DOM reviewer but feeling close now
- started working on linux/windows build problems for libprio
- worked through build integration problems from last friday:
- vendored msgpack + integrated
- used in-tree NSS mpi lib
- need to do a few supporting changes in libprio but nothing major
- getting further on tryserver, hitting some cross-platform issues like:
- linux is unhappy with multiple main functions, this is because we're building an NSS mpi file that we just don't need, this can be fixed in the libprio moz.build integration in my patch
- windows doesn't provide
<strings.h>
but does provide<string.h>
, if that's not enough for libprio then I'll need to make some further changes but initial results on macOS (which is my primary dev environment) look good
- got back prio review responses
- little more work to do on the DOM bit
- turned up some build system integration problems (one turned up by tryserver and one found by NSS reviewer):
- need to vendor msgpack
- need to use in-tree private NSS mpi lib not the copy in libprio
- got buy-in on prio plan mentioned yesterday
- pushed latest patches for review
- I wasn't able to resolve some of the DOM concerns (was crashing trying to use suggested Mozilla string libraries when passing to C etc) so asked for help on those
- pushed latest patches for review
- started working through Prio DOM review
- going to try to land current approach and then follow-up with new requirements from the meeting a few weeks ago
- followed up on github mentions
- worked on adding ArrayBuffer support for PrioEncoder
- this is more important now, since we're talking about sending way more Telemetry through.
- getting hung up on silly issue with
nsCOMPtr<nsIGlobalObject>
being easily available but not theJSContext
(which would be accessible from the global passed to the constructor viaaGlobal.Context()
).- this is one of those issues where it's easy to fix (keep a reference to the JS context around) but more about trying to figure out how the existing code does it so it's more likely to pass review
- responded to bug about making Normandy use ServiceRequest vs
raw fetch
- https://bugzilla.mozilla.org/show_bug.cgi?id=1471946#c19
- I filed this because I noticed Normandy wasn't doing NSS beConservative, since we're using it for hotfixes and we only serve signed content
- I wrote up a patch to wrap XHR (which is what ServiceRequest is built on top of) but expose it with a fetch-like API, however per comment above I think we should just go a few levels deeper and
- expose underlying network channel from fetch to system JS
- expose simple fetch wrapper from
ServiceRequest.jsm
that sets all the right network channels - get sec review on this
- back after being out w/ flu for a week
- reviewed+merged outstanding libprio PRs
- https://github.com/mozilla/libprio/ is now the official upstream \o/
- followed up on TLS 1.3 fallback-limit roll-out
- there's a hotfix we might want to block on to make the analysis cleaner, unsure.
- emailed nika about prio review
- sought out engineering design/architecture advice
- responded to henry's email re: recent prio PR
- reviewed idle callback patch for nsUpateTimerManager
- waaay simpler than I thought it was going to be
- https://bugzil.la/1373408
- shipped TLS fallback limit to 25%
- did a little telemetry notebook debugging first
- got back to henry re: hex-to-bin library
- had looked into it last (holiday) week but not followed up yet
- tl;dr nothing easily reusable, just utility functions in skia / nss
- henry is going to do it in prio and expose function to import hex-encoded keys
- rebased prio client against latest m-c
- PTO (still out sick)
- pushed TLS fallback limit to release 61 at 10%
- didn't get as much done as I'd like, starting feeling sick
- met w/ mreid re: prio telemetry
- worked on prio client
- US holiday
- went to MV for meetings
- figured out plan for landing prio client
- prio sec review (client-side)
- filed bug + submitted patch for normandy to use ServiceRequest instead of raw fetch()
- so many meetings
- prio RRA (server side stuff mostly, little early for it)
- telemetry for normandy pref-flip roll-outs
- other follow up from yesterday
- kept working through review feedback for prio impl
- worked on review feedback for prio impl
- more meetings than usual
- investigated update history
- helped w/ florian's study
- finished reviewing new TAAR study
- set up mozilla repo for libprio, so henrycg can do a PR and get NSS peer to look at it that way
- some confusion in the bug because upstream lib has both client and server parts, would be better to resolve all of this in the repo, and have a mozilla-controlled upstream repo anyway
- https://github.com/mozilla/libprio
- fwd'd review for libprio-specific bits to henrycg
- helped out w/ intern shield study
- reviewed shield pref flip study patch
- https://bugzil.la/1465195
- nothing really for me to do here
- reviewed new TAAR study
- took a look w/ chutten at TLS 1.3 telemetry notebooks
- chatted w/ bdanforth about testing strategy for study extensions, ahead of test infra meeting
- met w/ intern working on prio
- started exploring on better experiments + firefox integration for shield study needs
- chatted w/ relman re: tls roll-out plans for next few releases
- need to send intent-to-ship emails for next round soon
- put prio prototype patches up for review \o/
- PTO in morning
- working on generating test private/public keypairs for this prio code so I can get it up for review
- found it easiest to just make a little python script use libsodium for generating CURVE25519 keypairs
- this is fine for testing purposes but will make sure the sec folks generate and handle this key as part of review for the version we actually ship.. can put the public key in a pref
- still working on that python telemetry notebook too
- mythmon helped with this so now have the basic query working at least
- chatted w/ add-ons and experiments folks about upcoming shield study
- tl;dr is that it's been prototyped as a legacy extension, I actually already chatted in person w/ folks last week about converting this over to bundled webext experiment, should be nbd
- sent some docs and examples to interested folks
- reviewed patch to re-enable temporary extension unit tests on windows followin race condition fix
- worked on python telemetry notebook for tracking TLS fallback-limit via normandy on beta
- talked w/ henry @ stanford re: prio next steps
- henry suggested putting public key somewhere we can easily change; using a pref or passing to the C++ constructor would work
- henry is working on command-line encrypt/decrypt tools for Telemetry server's use
- sent prio status to ekr's intern
- meeting set up later in the week
- mozilla all-hands
- debugged why my local build is broken
- some XPI generation issue, both artifact and full builds
- landed savant bug for bdanforth
- autoland kicked back due to merge issue
- she looked into and was an issue where hg bookmark needed to be updated
- moved my prio work from git over to hg
- old moz-git-tools repo has a handy tool for taking a git format-patch output to something hg import can handle
- talked to ursula re: split up work for prio
- suggested reviewer for my part, contacted and lined that up
- pushed new version of TLS 1.3 roll-out to bug (for release)
- met about new shield utils webext experiments review
- glind already split out commits for me, should be done reviewing today
- meeting next week to talk about engineering, not going to sweat the details or block them shipping right now
- looked at results of beta fallback-limit push, so far so good
- kicked off perf+correctness testing for new shield study utils, as part of reviewing
- pushed TLS 1.3 fallback-limit on release (SAO) and beta (normandy)
- 1:1
- filed bugs splitting up prio work, so I can land the DOM bit sooner
- helped out bdanforth w/ savant study-related questions
- PTO (US Holiday)
- reviewed bug for bdanforth's Savant shield study
- needs to ship w/ Firefox behind a pref
- started working on testing for Fennec system add-on update bug
- reviewed bug about divorcing SAO update from app.update.enabled pref
- https://bugzil.la/1428459
- second round, r+
- responded to needinfo about signing built-in extensions
- corresponding w/ henrycg about using the prio API correctly
- I wasn't collecting all of the output from
PrioClient_encode
, getting closer to the expected result except the number of elements in the "forServerA" array is larger than "forServerB"... clarifying whether this is expected or a sign I am doing something wrong
- I wasn't collecting all of the output from
- merged AES removal from libprio vendoring
- https://github.com/rhelmer/gecko-dev/pull/1
- fixed some merge conflicts
- made sure that henry landed the same change in the upstream libprio github repo, as we're probably going to automate vendoring and checking for updates etc. in Firefox eventually.
- sent some questions from prelim review to henrycg
- pointer ownership and cleanup questions
- quick question about simplifying the JS API
- helped bdanforth test the easier XPI loading integration for mochitest
- seems to work
- needinfo'd folks on bug about whether SAO updates should be active in safe-mode
- https://bugzil.la/1459186
- built-ins are not deactivated, and updates are. this was done on purpose, but
worth reconsidering.
- ended up wontfix'ing, not worth changing as it matches current user expectation
- reviewed SAO for UA override on Fennec
- https://bugzil.la/1453691
- patch lgtm; made some suggestions for bullet-proofing it more, like the ability to sync data and not require a code update just to add/remove domains/UA strings
- needinfo'd kmag because I know he's working on some build system cleanup which should be reused by this, so they will either wait for him to land or take that part of his patch now.
- decided to just return array-of-arrays from
PrioEncoder.encode()
for now, since we're only encoding two 8-bit bytes right now. Will bring this up in code review, but don't think it should block testing. - clarified the use of the release-sysaddon test channel for QA
- looked into push of Google search fix SAO update, working overall but not seeing
it in super old versions like Firefox 43
- https://bugzil.la/1454443
- looking into the history of system add-on feature, looks like we have built-in extensions working in this timeframe but not updates, so won't work for this version
- pushing a classic Hotfix add-on would work if this is important enough to bother
- looked into why espr study isn't seeing as many pings as expected
- wondering if it's due to a missing
await
on anasync
function that gets called during early return ofstartup()
... - mozilla/esper-pioneer-shield-study#26 (comment)
- wondering if it's due to a missing
- looked into sentry exception coming from activity stream
- reviewed bug about moving dictionaries into the omni jar
- https://bugzil.la/1457321
- r+'d with a question about why this even needs to use the terrible build system hack I put in for system add-ons in 57 to generate a list of acceptable add-on IDs, versus just using the index of the JAR...
- hooked up error checking for PrioEncoder and pushed to github
- promise rejects now if there's any error in underlying libprio calls
- spent the rest of the day on wrapping libprio's output in an Array of ArrayBuffers. Having unexpected problems with the ToJSValue() template
- figured out my libprio string problem, batchID is passed to libprio correctly now \o/
- helped bdanforth figure out where to start up their code
- https://searchfox.org/mozilla-central/source/browser/components/nsBrowserGlue.js is probably the best place - this is per-session rather than per-window, like browser.js
- the trick is to init after the observer notification you want is observed, ideally as late in browser startup as possible: https://developer.mozilla.org/en-US/docs/Observer_Notifications
- by-the-by, that page would probably be a good candidate to move to https://firefox-source-docs.mozilla.org/ and use autodoc to generate
- attended Normandy brain-dump meeting, took notes
- put together beginning of architecture doc based on normandy notes
- chatted w/ bdanforth re: integration of the savant study
- going to land it in-tree vs. using an extension
- spent most of the day trying to figure out how strings work in mozilla C++ code
- https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Guide/Internal_strings
- context is needing to convert an
nsString
toconst unsigned char*
to use w/ libprio C code
- spent the morning dealing with aftermath of MBP upgrade
- got my apple ID working and downloading xcode so I could actually build firefox locally again
- hacked on prio and reported status to group
- imported latest prio and start working with the newest API
- todo:
- hooking up the right public keys
- adding some error checking that's compatible with the way our C++/JS bindings work
- some simple tests to make sure the integration is working
- actually return
ArrayBuffers
in thePromise
thatencode()
returns- right now it is just a pair of strings
- hacked on prio integration
- henrycg pushed new version w/ some API changes that needed to be imported
- pretty close to feature complete!
- prepared TLS 1.3 system add-on updates
- met re: updates
- attended github integration meeting
- other than vendoring from upstream projects, mostly interested in how test integration should work for things like studies and system add-ons that never land in m-c but nevertheless get shipped to some subset of users
- reviewed re-launch of ESPR study
- made plans re: Normandy arch docs
- firefox-source-docs.m.o (built from m-c source) is probably the most discoverable right now
- GH pages or google docs also an option, maybe linked from above
- good support for diagrams (ideally something like graphviz) might make the choice for us
- regardless of actual hosting would be ideal to have an authoritation mozilla.org URL or at least link to it from one
- reviewed bug cleaning up Cert.jsm exports
- hacked on prio dom integration
- made closer to mozilla c++ style guide
- starting working on testing
- adding a JS test for the
PrioEncoder
DOM method should be easy, but actually testing that prio is returning the right result is trickier... might just do that bit in C++ so I can use the verification code that's already in libprio
- adding a JS test for the
- upgraded MBP to high sierra, had to re-install a bunch of build tools (xcode, rust, etc)
- out most of afternoon getting iphone repaired and new cord for MBP
- review normandy client related bug
- chatted w/ henrycg re: prio
- libprio should do its own (de)serialization in C, so callers don't have to deal with it
- henry suggested a few third-party libs like msgpack and flatbuffers, I think the licenses are probably OK
- henry decided on msgpack
- henry suggested a few third-party libs like msgpack and flatbuffers, I think the licenses are probably OK
- also asked henry if it's easy enough to relicense libprio as MPL 2.0 to make our legal review smoother
- he will do so!
- libprio should do its own (de)serialization in C, so callers don't have to deal with it
- so many meetings
- read PHD docs for upcoming study
- updated gradual TLS 1.3 release channel roll-out for 50%
- https://bugzil.la/1442042
- verified XPIs and asked relman for sign-off
- reviewed normandy pref flip
- walked QA through testing the beta TLS fallback-limit (beta) pref flip
- finished review on pioneer news study 2
- followed up on GH issue re: browser console warnings when installing extension
- needinfo'd relman on TLS 1.3 for beta
- followed up w/ activitystream folks on availability of API for messaging in newtab
- worked more on prio prototype
- turns out there's a location in-tree for chrome-only webidl, allows for slightly nicer webidl
- opened a PR to wrap
extern C {}
around prio's header file, so I can get it out of moz code (already put this in the vendored version too) - https://github.com/mozilla/gecko-dev/compare/master...rhelmer:bug1421501-prio-prototype
- TLS 1.3 release channel roll-out shipped at 20%
- pretty close to an actual working prio impl now! most of the right types are wired up now,
and the prio code actually runs when you call
.encode()
- reviewed pioneer news study 2
- sent (late) intent-to-ship emails for TLS roll-outs
- asked for TLS 1.3 release roll-out to ship
- emailed about prio
- have the actual prio code running inside the PrioEncoder DOM method now
- https://github.com/mozilla/gecko-dev/compare/master...rhelmer:bug1421501-prio-prototype
- got basic Prio example working \o/
- https://github.com/mozilla/gecko-dev/compare/master...rhelmer:bug1421501-prio-prototype
- vendoring and linking libprio, using it from webidl impl code
- emailed folks
- chatted w/ rdalal re: pioneer
- chrome manifest resource:// registration removed on nightly
- use current approach + test on unbranded builds for 59+60
- work on webextension approach for 61
- chrome manifest resource:// registration removed on nightly
- chatted w/ rstrong re: pref flip on older Fx
- sysaddon support first landed in 43 so might be enough, need to test
- rstrong to file bug
- reviewed testing strategy for shield studies w/ bdanforth
- we both took copious notes
- tl;dr - we want to make dev workflow the basic github workflow - add-ons are developed using normal add-on tools, and the mozilla TaskCluster CI bits are integrated via GH webhooks etc. as in CircleCI/Travis
- followup action items
- bdanforth to set up meeting w/ jmaher and myself also, invite me to shield dev workflow meeting next week
- I will contact myk melez re: github working group
- done, will catch up on their progress and attend
- we both took copious notes
- Updated TLS 1.3 release channel roll-out add-on to 10%
- Created new bug to roll out TLS 1.3 fallback-limit to Beta
- https://bugzil.la/1448176
- this is basically the same as above, but different pref and targeted at Beta only. Beta already has TLS 1.3 enabled, this stops fallback.
- Worked a bit on Prio webidl
- looked into issue w/ TP study not working on restart
- bug in Firefox (RecentWindow.jsm), appears to be fixed in 60+
- study is running on 59
- bdanforth changed add-on to use RecentWindow.jsm consistently which works around it
- study paused while we looked at it and will be relaunched shortly
- bug in Firefox (RecentWindow.jsm), appears to be fixed in 60+
- followed up w/ QA re: TLS 1.3 gradual roll-out
- put together telemetry query to track
- attached v5 for signing, which bumps from 1% to 5% per ekr
- also tested, hosted and needinfo'd relman
- 1:1
- discussed topics from TODO.md
- followed up w/ QA re: TLS 1.3 gradual roll-out
- https://bugzil.la/1442042
- shipped to release \o/
- putting together telemetry report, both to check uptake of add-om
and also to measure effect more directly
- ekr has an ipython notebook from previous experiments that can be adapted for this purpose
- reviewed bug re: directory service overrides for add-ons manager tests
- followed up w/ QA re: TLS 1.3 gradual roll-out
- https://bugzil.la/1442042
- tried shipping but no relman support available
- also QA
- updated ekr on status, ETA for shipping monday
- made decision on Prio prototype
- taking the original course - webidl
- followed up w/ QA re: TLS 1.3 gradual roll-out
- https://bugzil.la/1442042
- working correctly now
- ekr asked if we can use 1% instead of 10% for initial roll-out, should be fine but will require the add-on to be modified and re-signed
- attached new XPI to bug for testing and ping'd QA
- followed up w/ QA re: TLS 1.3 gradual roll-out
- https://bugzil.la/1442042
- full test instructions used this time
- add-on itself works, but logic that chooses 10% of profiles does not seem to be working for QA when creating new profiles. I'll try it again myself today
- met w/ bdanforth re: final tryserver result review for TP study
- followed up w/ QA re: TLS 1.3 gradual roll-out
- looked into build problems w/ bdanforth on TP study
- followed up w/ QA re: TLS 1.3 gradual roll-out
- https://bugzil.la/1442042
- need to make instructions more explicit.. maybe host on balrog test channel
- worked a bit on getting built-in add-ons into the omni jar
- emailed followup re: system add-on compat to dev-firefox/platform
- PTO
- added steps for QA for TLS 1.3 gradual roll-out
- https://bugzil.la/1442042
- looks like we're still waiting on the pref to be rolled back on beta...
- did some testing for ulfr
- tested standalone prio
- got building on macOS and sent PR etc.
- chatted w/ QA re: TLS 1.3 gradual roll-out
- took a look at latest prio work
- packaged up XPI and put in PI request for TLS 1.3 gradual roll-out
- last-minute TAAR help + review
- went over options to exclude private browsing windows
- specifically, any open browser windows, not just the most recently active
- mozilla/taar-experiment-v2-shield-study#18
- https://bugzil.la/1428308
- went over options to exclude private browsing windows
- attended TP study review meeting / demo
- addressed review comments on add-on for TLS 1.3 gradual roll-out
- figured out plan w/ add-on folks for moving built-in add-ons to omni jar
- https://bugzil.la/1357205
- going to start moving away from "system add-on" naming
- something like "built-in"
- updates in the future will come as normandy-installed hidden add-ons, again moving away from "system add-on" nomenclature
- met w/ benson
- finished up review changes on add-on for TLS 1.3 gradual roll-out
- worked on add-on for TLS 1.3 gradual roll-out
- attended update meeting
- caught people up on system add-on, gmp, normandy, etc. plans
- also mentioned ServiceRequest so folks know it exists
- advised prio folks on technical issues integrating w/ Firefox
- C vs. C++, memory allocation, etc.
- filed bug for TLS 1.3 gradual roll-out
- worked on exposing
fetch
interface from ServiceRequest.jsm- first attempt was to polyfill w/ already-subclassed XHR
-
original bug just subclasses XHR
-
however,
fetch
cannot be subclassed, as it is just a function and not a class such as XMLHttpRequest. providing a proxy function which calls it is probably the way to go.The only problem with this is that built-in
fetch
does not expose the underlying network channel (for settings things such as conservative TLS settings), so Fetch.webidl would need to be modified to do so (XHR has a chrome-only mechanism for doing this)
-
- first attempt was to polyfill w/ already-subclassed XHR
- looked at panel issue with TP study, where it is staying open due to
the
blur
event acting on panels as well as regular windows (panels are a type ofChromeWindow
) - bdanforth is looking at how to detect these, so the intro panel gets closed only if users either accept or explicitly switch windows
- looked at window-closing panel issue on TP study
- re-investigated and commented on bug about moving built-in add-ons to omni jar
- worked on wrapping fetch for ServiceRequest.jsm
- this is so we use consistent settings for requests coming from Firefox
- original bug just subclasses XHR
- discussed slow roll-out for a few features w/ folks
- normandy not ready til ~61
- system add-on probably the way to go in the meantime
- finished review for system add-on enterprise policy
- out for part of day with vet emergency
- chatted w/ tor folk re: system add-ons on fennec
- https://bugzil.la/1440789
- tl;dr - moz build folks would prefer a better packaging mechanism such as https://bugzil.la/988938
- responded to willkg question regarding hive ADI socorro fetcher
- looked at quirk of lazy-loading in TP shield study
- reviewed one of the patches on bug about controlling system add-ons with enterprise policies
- chatted w/ tor folks about porting legacy add-on to mobile
- tl;dr - might be OK in the short-term, not really the right thing long-term. maybe either make native messaging work on mobile, or switch to something android-specific
- chatted w/ bdanforth re: final unit test failure for TP study
- doesn't happen during manual testing
- test only happens when WebRequest is being used
- tl;dr - shouldn't block, but worth investigating (would be
interesting to see if webextension using
browser.webRequest
triggers it as well)
- chatted w/ prio folks re: firefox integration
- going to do it as a standalone library and server/client examples
- we can either ship this inside Firefox or possibly as an add-on via shield
- could either js-ctypes or (maybe safer) just call the standalone client executable
- chatted w/ bdanforth re: channel testing requirements for shield studies
- investigating ActivityStream's TC/github integration per Standard8
- solicited feedback on off-train perf/correctness testing
- chatted w/ mythmon re: the taskcluster/github integration and testing work he did for shield-recipe-client
- worked on email re: deprecating bootstrapped add-ons
- r? aswan
- chatted w/ bdanforth re: tryserver
- referred her to other folks to dig into memory leaks, not sure what the most expedient way to track them down is
- met w/ bdanforth re: tryserver results
- tracked down why artifact builds weren't working for release branches
- looked into leaked windows and remaining perf issues
- trying one last tweak to improve perf, some small known regressions are expected since this is not the same approach as the final feature will take
- gave moar explicit r+ on TAAR shield study
- tested fix for browserAction + webext API bustage
- put some thoughts on SAO update automated testing bug, based on bdanforth's work so far
- super-blue-blood-moon edition
- met w/ bdanforth and figured out tryserver test plan for TP study
- running all unit+func+perf tests
- quickly found a few issues
- TP study add-on makes outbound connections
- TP study randomly picks control or treatment branches
- bdanforth will land workarounds in hg.m.o/try for both
- prio progress
- enough C++ implemented to compile + show up in Browser Console
- https://github.com/mozilla/gecko-dev/compare/master...rhelmer:bug1421501-prio-prototype?expand=1
- need to figure out constructor and show stanford folk where to plug into
- enough C++ implemented to compile + show up in Browser Console
- push meeting
- prio
- sent quick-start Firefox+github instructions to Stanford folk
- worked on prio webidl c++ boilerplate
- worked up SQL query for tracking system add-ons on main summary
- tested and reviewed TP study
- setting up GH repo for prio
- tested and reviewed TP study
- meeting w/ stanford folks
- rhelmer to follow up:
- w/ NSS folks on crypto_box and fast polynomial libs
- set up github to collab
- rhelmer to follow up:
- finished testing and landing patch for system add-on updates on Fennec
- met w/ bdanforth re: TP shield study
- put up patch for review enabling system add-on updates on Fennec
- chatted w/ glind re: shield experiment reviews and moving to webextensions
- chatted w/ mythmon more about normandy client as Firefox component
- set up meeting w/ bdanforth re: tracking protection study
- chatted w/ mythmon about how to start up normandy Firefox component
- will live in toolkit/
- probably started up in nsBrowserGlue.js for desktop, browser.js for fennec
- worked on enabling system add-on updates on Fennec
- holiday (MLK)
- PTO (out sick)
- worked on enabling system add-on updates on Fennec
- responded to review request about flipping the
app.update.enabled
pref to false when updater is disabled at build time- https://bugzil.la/1427471
- r+'d after a few questions to make sure we wouldn't bust blocklist or SAO updates for desktop or fennec (distro builds do their own thing but I think we'll be OK in this case too)
- responded to feedback request in bug from cliqz about how we're using built-in list of system-addons
- responded to review request about removing all hotfix code from Firefox
- https://bugzil.la/1356331
- I think we need to get Fennec to system add-on updates first
- worked on enabling system add-on updates on Fennec
- advised on tracking protection study
- start working on enabling system add-on updates on Fennec
- 1:1
- q1 normandy client planning
- spent some time breaking out various update proposals
- short-term Q1/Q2 move SAO from balrog to normandy
- medium-to-long-term allow update of omni jar
- medium-to-long-term move normandy client to Rust
- went over feedback from faster feature update proposal
- solicted feedback about out-of-process updater concept
- meeting possibility of using push for triggering updates
- met w/ bdanforth about TP study
- met w/ bdanforth who is taking over the TP study
- prototyping
- meetings
- started working on prototype
- pushed old bug w/ cleanup of issues found in AddonsManager found with Flow over the finish line
- wrote firefox-dev post about jsdoc+sphinx integration
- review for high-priority telemetry/addons manager crash
- aswan is out and kmag is busy
- https://bugzil.la/1381633
- learned a bit more about constructing proofs using arithmetic circuits and multi-party computation, for a prototype
- reviewed one-off experiment
- looked into how to enable legacy add-ons in local beta build
ac_add_options "MOZ_ALLOW_LEGACY_EXTENSIONS=1"
- waiting for unbranded builds to be fixed
- coordinated w/ relman about shipping hotfix color distortion in video on AMD
- landed jsdoc+sphinx+firefox integration \o/
- investigated options for calling standalone rust code
- Firefox subprocess module can call standalone binaries
- jsctypes can load a library into an existing process
- can introduce stability problems and other weird bugs...
- launching rust when Firefox starts, and IPCing to it
- launching rust as OS process, and IPCing to it
- investigated using nacl in rust code
- the crypto lib aka "salt", via the libsodium fork
- https://cr.yp.to/highspeed/naclcrypto-20090310.pdf
- prepared hotfix for color distortion in video on AMD cards for 57
- discussed signing options for XPIs
- in-app vs. profile dir
- read/responded to email
- met w/ aswan, discussed webextension and shield/system add-ons/etc.
- read/responded to email
- followed up on sandboxing bug that might prevent some system add-ons from updating out-of-cycle on 57.0
- followed up on sandboxing bug that might prevent some system add-ons
from updating out-of-cycle on 57.0
- https://bugzil.la/1376814
- specifically would affect framescripts and contentaccessible chrome/resource URLs
- mythmon is running a test today to see if shield about: page works correctly after an update on 57 beta
- discussed tor meeting minutes w/ add-ons folks
- https://lists.torproject.org/pipermail/tbb-dev/2017-November/000652.html
- tl;dr - they might not need to be an extension at all; if they do,
it might not be as complex as it appears (Tor works over HTTPS AFAICT,
and there are APIs for the proxy stuff).
- native connect to a standalone app is also doable
- or, not be an extension at all and spin up a separate firefox process...
- filed bug to remove client-side Telemetry Experiments support
- reviewed system add-on update to fix search engine geo prefs
- discussed w/ shield and AMO folks which suffix to use for shield addon IDs
- AMO blocks @mozilla.org/com, probably want @*.mozilla.org/com as well
- 1:1
- helped francois test system add-on update to roll back TP UI changes, if needed
- discussed removing telemetry experiments w/ add-ons folks
- reviewed system add-on update (TLS middlebox experiment)
- worked on tests for tracking protection study
- filed bug about page action icons being too restrictive
- https://bugzil.la/1414966
- this would make tracking protection study much easier to do as a webext
- highlights from the last few weeks:
- tracking protection study
- this is on hold til post-57, still working on tests
- webrequest onBeforeRequest doesn't seem to be firing for the local test page
- this is on hold til post-57, still working on tests
- trying determine what the post-57 future of bootstrapped add-ons will be
- thinking about how to make gofaster less of a niche and more of a basic part of mozilla
- soliciting mozillian's opinions on what they'd like to see in etherpad
- looking at what we can remove post-57 from addons manager
- old-style hotfix
- telemetry experiments
- ???
- tracking protection study
- highlights from the last few weeks:
- only load system add-ons from a built-in list
- https://bugzil.la/1348981
- list is generated at build time and packaged into omni jar
- required some C++ changes, mostly to test properly
- only load system add-ons from a built-in list
- tracking protection study
- rewrote as legacy-style bootstrapped add-on, using XUL etc
- not really possible to get the desired UX via webextensions, yet
- page action restrictions for example (image only, 16x16)
- blending in with the Firefox UI becomes much simpler
- it is possible to share enough underlying code with webextension impl that there isnt an advantage to having the overhead of communicating with an embedded webext
- not really possible to get the desired UX via webextensions, yet
- started developing this in-tree so mochitest can be used and mozilla "try" infra can produce builds
- probably can't use shield since this needs to run so early in startup to be useful... funnelcake will work here and we can test builds from the "try" infra (see above)
- rewrote as legacy-style bootstrapped add-on, using XUL etc
- reviews on add-ons manager, shield, helped out with various studies
- highlights from the last few weeks:
- fixed addon manager bug when user has unicode in profile names
- https://bugzil.la/1389160
- turns out we don't test this case at all! filed a few test harness bugs
- put up patch to pass Flow null check violations Mossop found
- https://bugzil.la/1395425
- nice opportunity to rewrite to async/await to make this sort of bug less likely
- worked on tracking protection study
- https://github.com/rhelmer/tracking-protection-study/
- refactored existing study to make more configurable at runtime
- used embedded webextension for UI
- requires message passing to bootstrap.js
- https://github.com/rhelmer/tracking-protection-study/tree/master/extension/webextension
- https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Embedded_WebExtensions
- found some problems with current tracking protection impl for our purposes:
- onSecurityChange is only sent if the nsIChannel is connected to the document loaded in the currently-focused tab. This means that we can get an accurate count of blocked resources only if the tab is focused - otherwise the onSecurityChange event is only observed once per focus
- https://bugzil.la/1388916 is filed to fix this
- lots of known breakage on real-world sites
- API isn't very amenable to adding a WE API, but I think that's the right thing to do long-term.
- onSecurityChange is only sent if the nsIChannel is connected to the document loaded in the currently-focused tab. This means that we can get an accurate count of blocked resources only if the tab is focused - otherwise the onSecurityChange event is only observed once per focus
- resurrected old sphinx-js patches to land in mozilla-central, now that Mozilla infra can handle building and hosting sphinx docs
- fixed addon manager bug when user has unicode in profile names
- bisected regression range for unwanted system add-on first-run behavior
- https://bugzil.la/1386295
- was broken by one of the perf improvements in 55
- causes brand-new system add-ons to not appear on first-run in a new profile
- meetings at SF office
- investigated temporary add-on loading issue
- happens when temp installing an add-on over an existing one, then uninstalling
- aswan agreed to take a look
- https://bugzil.la/1359558
- reviews
- highlight legacy pane when showing details for legacy add-on
- mentored bug about moving error codes to public AddonManager class
- https://bugzil.la/553869
- running into lots of bustage on m-c :/
- landed work on making shield download+run recipes in early post-startup
- https://bugzil.la/1383338
- also uplifted to beta (55)
- meetings
- worked on making shield download+run recipes in early post-startup
- mozilla/normandy#895
- I think it's just about done
- will have to uplift this into the intended release... 55?
- reviewed + landed patch to hide telemetry experiments from legacy menu in about:addons
- worked on making shield download+run recipes in early post-startup
- mozilla/normandy#895
- addressed review feedback
- investigated spurious system add-on related issue found by QA
- worked on making shield download+run recipes in early post-startup
- reviews
- don't show optional legacy pane in about:addons if no disabled legacy add-ons
- legacy page shows an experiment
- worked on making shield download+run recipes in early post-startup
- reviewed pre-publication browser-arch docs
- Attended browser-arch meeting
- reviewed update-only tls measurement add-on
- started review on moving blocklist into addons DB
- https://bugzil.la/1377538
- this should keep the (expensive!) blocklist service from being parsing the whole blocklist at startup
- worked on moving system add-ons to omni jar
- https://bugzil.la/1357205
- figuring out exactly where Addon Path Service is used, and if passing omni.ja to it is appropriate...
- looked at addons background update check that fails when new RCWN feature is enabled
- https://bugzil.la/1358038
- posted with some thoughts on where the problem might be, needinfo'd network folks offering help making a minimal test case if my suggestions don't pan out
- took over cache invalidation patch when using embedded webextensions for aswan (pto)
- filed bug about showing permissions UI on about: pages
- investigated disappearing system add-ons in artifact (dev) build
- https://bugzil.la/1371273
- turned out to be profile switching which isn't really well supported :/
- might disable or strongly encourage profile switching instead...
- probably will fix it anyway
- participated in browser-arch discussion around multi-process and updates
- worked on bug where system add-on and hotfix updates show up in about:addons
if it is open during update
- https://bugzil.la/1367800
- users still can't disable or remove, so not harmful just looks glitchy
- again, simple code fix, complex test :/
- worked on refining updates proposal
- reviewed bug showing unsigned legacy extensions in legacy section
- https://bugzil.la/1371752
- this is only for builds that allow disabling signing so pretty minor impact
- worked on bug about race in addons manager module
- https://bugzil.la/1371363
- this only happens for firefox-internal callers doing it in the wrong order
- telemetry was bit by this but fixed it in their code
- it's a footgun we should remove
- have it done other than the dang xpcshell test :/
- reviewed change to always show flash preferences button in about:addons
- https://bugzil.la/1357300
- r+'d after a few rounds
- worked on bug involving race condition between uninstall and add-on initialization
- this is only a problem for internal code using the AddonManager API
- https://bugzil.la/1371363
- worked on hotfix/system add-ons showing up during update
- landed string change in time for beta
- Worked on update proposal
- Resolved bug that was blocking screenshots being enabled by default
- Responded to QA needinfo on captive portal detection hotfix for 52
- Reviewed test change to enable privileged add-ons
- Things like Test Pilot will need this post-57 to install
- https://bugzil.la/1357948
- too busy to keep on this lately, some highlights from the last few weeks:
- lots of perf-related addons manager reviews
- helping to get crash reporting going for extension process
- Firefox arch review meetings and discussion
- helped out w/ Screenshots landing
- also helping to look into perf issues - there are some perf problems with using a WebExtension, they may put a bit more of the add-on into the bootstrap.js side to mitigate
- worked on update proposal
- learning how to better use the gecko profiler
- finally able to reproduce screenshots bug
- https://bugzil.la/1355998
- looks like it only happens on win7 opt, nowhere else
- also it's in the about:addons windowed code, which is known to be buggy and we've announced support to remove anyway \o/
- PTO in afternoon
- reviewing https://bugzil.la/1356826
- has a controversial bit that I was holding off on while discussing
- further work to re-enable test that started breaking for screenshots when
enabled
- https://bugzil.la/1355998
- taking lots of time due to waiting for tryserver...
- more investigatory work on moving system add-ons into omni jar
- https://bugzil.la/1357205
- this will help startup perf and make malware dropping in a new XPI less trivial.
- made suggestions for shipping mortar and pdf.js side-by-side
- tried to re-enable test that started breaking for screenshots when enabled
- https://bugzil.la/1355998
- not able to repro, standard8 thinks it might be due to broken tests on m-c, going to try rebasing tmrw,
- r+ on adding whether add-on is a webextension to telemetry
- looked into why screenshots loaded as temp addon does not seem to
override the built-in
- mozilla-services/screenshots#2704
- turned out this was due to the webextension not being shut down by bootstrap shutdown()
- working on adding whether add-on is a webextension to telemetry
- more reviews
- so, so many AddonManager perf-related reviews
- lazy-loading, eliminating directory scanning, etc.
- ex. https://bugzil.la/1356826
- helped track down screenshots bustage on nightly
- https://bugzil.la/1357137
- also chatted w/ screenshots folks about more testing to catch this
- reviewed and answered addons-related questions for shield-recipe-client
- closed bug about revealing system add-ons in about:addons
- reasoning in https://bugzil.la/1231202#c9
- worked on bug to validate built-in system add-ons against list of known IDs
- https://bugzil.la/1348981
- this will eliminate one of the dirs we need to scan at startup, which we are trying to eliminate from AddonManager for 55.
- landed unregister for update timer manager
- https://bugzil.la/1350471
- this is for shield-recipe-client and other add-ons
- pushed patch to add unregister method for update timer manager
- https://bugzil.la/1350471
- needed because currently there's no way for add-ons to unregister
- will likely uplift for shield-recipe-client use -mozilla/normandy#588
- doing some self-triage, lots of old bugs hanging around.
- started working on refactoring to reduce the amount of code needed for new install locations in addons manager
- https://bugzil.la/1314177
- tl;dr move to ES6 class and use extends, instead of current approach which has a fair amount of duplication.
- helped w/ review and push of tls-comparison system add-on update
- pushed fix for system add-on update regression in 52
- https://bugzil.la/1350064
- tl;dr - updates are not removed on app update
- took a look at Telemetry and minimal impact, easy to work around but good to be aware of.
- sent intent-to-remove standalone about:addons UI to dev-platform list
- pointed felipe at place to add preferences button for Flash in about:addons
- chatted w/ ekr about system add-on experiments
- put up patch to send old version along with upgrade data for temporary add-on reloads
- worked on sphinx+jsdoc integration
- PTO
- PTO
- pushed PR with proposed fix for tls 1.3 add-on
- mozilla/one-off-system-add-ons#20
- listens for "loadend"
- also sets deadman timer per ekr's suggestion
- reviews
- r+ on system add-on update test which is timing out in moz infra
- looked into tls 1.3 data w/ ekr and felipe
- small percentage of users keeping 1.3 on longer than expected
- was able to reproduce using theory from felipe - "load" listeners are not called on timeout but they are on "loadend".
- used xcode "link conditioner" to simulate super lossy connection
- ckprice setting up post-mortem
- reviews
- converted tls1.3 telemetry experiment to system add-on
- wrote better docs on system add-ons, waiting for gecko.rtd push
- investigated building+hosting jsdocs somewhere (probably GH pages, RTD can't do it :/)
- helped QA test restartless system addon patch on beta (52)
- looked at SHA1 deprecation issue QA was seeing
- got them to send profile, couldn't repro
- turns out to be using unexpected builds
- worked w/ Telemetry team to vet (and correct) system add-on uptake graphs
- reviews
- PageShot meeting
- discussed toolkit/browser split for discopane
- update messages must be loaded into browser
- reviews
- discussed PageShot shipping options w/ ianbicking
- discussed Active Stream shipping on fx-dev list
- investigated omni-jar improvements
- looks doable to move system add-ons into here
- should yield startup time improvement + partial patch reduction
- refining telemetry dashboards to track system add-on rollout
- https://sql.telemetry.mozilla.org/queries/2654#4910
- https://sql.telemetry.mozilla.org/queries/2683#4994
- looking into refining query
- excluding clients that have not reported since the update was made available.
- looking into refining query
- tested various omni.ja compression improvements
- https://bugzil.la/1231379
- catlee re-opening bug to ship uncompressed omni.ja, which:
- reduces partial diff size (Windows, Release) by ~40%
- improves startup time by ~2-3%
- known downsides are
- seems to cost about ~8 MB RAM
- investigated other omni.ja improvements
- working on telemetry dashboards to track system add-on rollout
- https://sql.telemetry.mozilla.org/queries/2654#4910
- https://sql.telemetry.mozilla.org/queries/2683#4994
- looking into refining query
- excluding clients that have not reported since the update was made available.
- looking into refining query
- working on telemetry dashboard to track system add-on rollout
- responded to review request on webextensions-themes add-on manager integration
- looked into telemetry for low uptake of hotfix
- working on telemetry dashboard to track hotfix uptake
- shipped system add-on diagnostics update
- https://bugzil.la/1307568
- working on telemetry dashboard to track system add-on rollout
- worked on system add-on diagnostics update
- https://bugzil.la/1307568
- for the update-only, re-submitted fixed version for signing+QA
- worked on system add-on diagnostics add-on
- https://bugzil.la/1307568
- built-in version got almost-final-r+
- update-only version, QA tested and found an issue
- reviewed data from telemetry/metrics regarding hotfix uptake
- 10% of main summary (instead of longitudinal) shows 90% uptake
- longitudinal only showed ~55% shortly after release, up to ~77%...
- 10% of main summary (instead of longitudinal) shows 90% uptake
- chatted w/ devtools
- quick chat about graduating add-on to built-in
- put doc up for data review for diagnostic system add-on
- worked on diagnostic system add-on
- https://bugzil.la/1307568
- general approach is:
- measure first
- ship simple update-only version ASAP
- sent "intent to ship" email to r-d and gofaster lists
- land more complete version in the tree
- quick followup review on "your add-on is ready" pop-up
- caught up on review and feedback requests
- post-install notification for mozAddonManager installs
- "use strict" violations only logged at LOG level
- started working on breaking up test that intermittently times out
- chatted w/ felipe about diagnostic add-on
- https://bugzil.la/1307568
- plan is to
- ship as an update and track uptake
- ship built-in and look at diagnostic telemetry
- re-ship update once restartless system add-ons go out in 52
- caught up on reviews and feedback requests
- mostly out due to storm knocking out internet connection
- responded to review/feedback requests
- reviewed the first half of webext permission prompt patches
- chatted w/ devtools team about upcoming plans
- fixed even more test failures for ServiceRequest (TLS 1.3 disabling XHR replacement) onto beta
- https://bugzil.la/1325501
- mostly just minor stuff like imports that haven't made it to beta yet
- looks like it stuck this time \o/
- re-ran try for browser.runtime.oninstalled temporary add-on fix
- https://bugzil.la/1323938
- should be ready, but hopefully try is less busted now
- investigated using re:dash for tracking distribution of system add-on versions
- investigated using re:dash for crashes involving specific add-ons
- fixed test failures for ServiceRequest (TLS 1.3 disabling XHR replacement) onto beta
- reviewed shield addon change (startup pref check shouldn't throw first time)
- vouched for level 3 access for mythmon
- catching up from PTO
- rebased ServiceRequest (TLS 1.3 disabling XHR replacement) onto beta
- https://bugzil.la/1325501
- s/rebased/rewrote/ is more like it :/
- feedback on aswan removing support for multiple installs via InstallTrigger
- feedback on markh's work on getting sync to reliably tell which addons
came from AMO and are therefore eligible for syncing
- https://bugzil.la/1285866
- tl;dr - we should keep the list of add-ons installed from AMO more consistent, AFAICT we only populate this "DB" (really a JSON file) once per day along with the addons check.
- 1:1
- skipped out on addons manager triage due to plumbing-related issues :O
- swapped PTO day to look into conservative TLS settings bug
- https://bugzil.la/1323538
- tl;dr - bleeding edge features like TLS 1.3 are breaking some updates
- instead of playing whack-a-mole patching every place in Firefox chrome code that does XHR, consulted w/ ehsan about doing it in the XHR implementations instead. put up patch with f?ehsan
- finished review for shield system add-on
- https://bugzil.la/1308656
- was landed this evening \o/
- AddonManager triage
- reviewed patch to promisify AddonManager
- https://bugzil.la/987512
- can optionally handle callbacks which is cool
- one-off gofaster meeting to talk about uptake investigation
- pretty sure we're having the same problem as GMP and Hotfix have before
- diagnostic addon and better telemetry dashboard should give a starting point
- worked on new diagnostic system add-on to ship with Firefox to determine why all System Add-on (incl. GMP) updates are not making it to all users
- filed bugs
- track uptake of all Firefox updates
- https://bugzil.la/1323547
- followup from meeting during workweek
- use conservative TLS settings for add-on updates
- https://bugzil.la/1323538
- related to recent concerns about App Update over TLS 1.3
- followup about rebuilding missing or corrupt Addon DB (JSON)
- track uptake of all Firefox updates
- reviews
- finished with patch removing support for multipackage XPIs
- started on patch to remove support for multiple XPIs with one InstallTrigger
- needinfo
- started looking at restored session sync bug
- PTO
- PTO for most of the day
- set up a test scenario for QA and restartless system add-ons
- minor fallout for uplift request for e10srollout-supporting change
- https://bugzil.la/1272446
- I had forgotten to
hg add
the unit test on the beta branch, so it didn't appear in the diff /o\- also, was wrong that Aurora didn't need its own patch
- attached new patches for beta and aurora which stuck \o/
- did some addons manager triage of existing open bugs w/ aswan
- responded to webextensions concerns on dev-addons list
- blogged about a few side projects
- uplift request for e10srollout-supporting change
- reviews
- remove string generics
- e10srollout target all addons not explicitly marked non-multiprocess-compatible
- checked in with Gijs and mythmon regarding SHIELD client
- mythmon is porting over tests and removing SDK, all systems go
-
helped out w/ getting shield recipe client system add-on build+test in moz-central working
-
GoFaster meeting
-
Felipe ran into an issue with AddonManager and e10srollout where he wants to identify whether add-ons explicitly opted out of multiprocess compatibility, but currently only a boolean is stored after the manifest is parsed.
Worked on providing a way to cause all manifests to be re-read when the addons DB schema version is bumped - this way Felipe could add a new property to the DB which is set based on the presence of the multiProcessCompatible property, and all add-on manifests will be re-read when a schema version bump comes with the next app update.
- started chatting w/ folks about felipe's idea for update experiment
- https://bugzil.la/1307568
- tl;dr we suspect MITM proxies are breaking different updates, including but not limites to system add-ons, due to cert pinning requirements
- looked into what happens when balrog sends 404 to GMP/SystemAddon update
- currently HTTP status is ignored :/ so XML is read, but will throw if
can't be parsed
- TODO file bug
- currently HTTP status is ignored :/ so XML is read, but will throw if
can't be parsed
- responded to some needinfos
- Firefox for Android sending bad versions in GMP updates
- Addons manager does not store difference between unset multiprocess and
set xplicitly false in manifest
- https://bugzil.la/1314429
- we should be able to do this by bumping the schema version and adding a new property to store this. the schema bump should cause all addon manifests to be re-read.
- landed restartless system add-on patch \o/
- reviewed AddonInstall refactoring patch
- worked on refactoring all of AddonManager to es6 classes
- want to increase use of subclasses and tighten design, this is first part
- worked on issue with sync addon DB loading throwing exception when
dev edition theme is the default
-
the issue of why we are doing sync load here is a tricky one... for now going to settle for making the exception go away (seems to just be a case of a programmer error+no test around interrupting async load when sync load has completed in the meantime.
Going to split out the "how to make this right" issue from the "make it work as intended"
- addressed review comments on restartless system addon patch
- chatted w/ rdalal on what needs doing in morgoth
- AddonManager triage w/ aswan
- filed bug to remove install.rdf and replace w/ manifest.json
- basically make all bootstrap.js addons "hybrid" type
- https://bugzil.la/1314710
- got Rust compiling to wasm working locally
- maybe can use for Firefox eventually
- better type safety/correctness than JS
- no GC w/ memory correctness
- no parallelism yet, but SharedArrayBuffer coming
- maybe can use for Firefox eventually
- took a look at error message from theme selector
- caught up on email/bugmail
- met w/ rdalal about https://github.com/mozilla/morgoth/issues/41
- reviews
- mozAddonManager should use frame manager, to work w/ e10s
- fix for unsafe CPOW warnings in xpinstall tests
- starting working on https://github.com/mozilla/morgoth/issues/41
- read through morgoth data model
- reviewed bug regarding bad interaction between Addon SDK and e10srollout
- reviewed bug: install addons permanently using proxy file from about:debugging
- morgoth working locally
- worked more on restartless system addon install+update
- patch working locally
- going through test failures
- so many meetings
- started working on morgoth
- worked on separating system add-on components in about:support
- landed patch for about:crashes to separate un/submitted entries
- started watching the "ES6 For Everyone" training videos
- a kind mozillian gifted me a pass
- fixed bug in onUpdateAvailable that was causing test failures
- revived patch for about:crashes to separate un/submitted entries
- https://bugzil.la/512479
- had more tests already than I realized, mostly working through those
- meetings
- gofaster
- system addons
- addonmanager triage
- landed webcompat system add-on consistency
- restartless install+update for system add-ons
- https://bugzil.la/1204156
- chatted w/ aswan, going to need to move the postponed AddonInstall state
- so many meetings
- made webcompat system add-ons more consistent
- In Portland office for meetings
- figured out plan for automating system add-on update signing
- helped w/ crash collector transition planning
- restartless install+update for system add-ons
- https://bugzil.la/1204156
- working patch locally, needs more testing
- looked at patch backed out of autoland
- https://bugzil.la/557710
- the test code I refactored is used in more places than I realized
- going to refactor this and all callers first
- put up patch for review on prereq to install+update for system add-ons
- https://bugzil.la/557710
- filed a few followup bugs
- improve testing functions for programmatically creating addons
- temporary add-ons do not reveal overridden add-ons in the correct order
- helped merge updates-only system add-ons patch to aurora+beta
- worked on prereq to restartless install+update for system add-ons
- started working again on restartless install+update for system add-ons
- https://bugzil.la/1204156
- posted plan to bug
- addons triage
- picked up bug about distribution add-ons not working on Fennec
- https://bugzil.la/1296563
- turns out was a documentation bug
- reviewed bug to expose canUninstall flag for AOM-exposed content
- landed feature to leave built-in system add-ons alone, only specify updates
- https://bugzil.la/1295732
- requested uplift to aurora+beta
- landed delayed update for webextensions
- working on prereq to system add-on changes
- reviewed moving AddonManager test helpers to shared module
- this is so it can be easily used by webextensions too
- https://bugzil.la/1294811
- r+ on delayed update for webextensions \o/
- https://bugzil.la/1279012
- can't land yet, seems to be some mozreview bug :/
- started working on prereq to system add-on changes
- PTO
- helped with system add-on roll-out
- Pocket had some l10n issues
- xpi shipped w/ Firefox only has en-US, need one with all locales
- Pocket had some l10n issues
- fixed bugs from try run on onUpdateAvailable
- https://bugzil.la/1279012
- re-ran try build
- took older bug to add better tests for same add-onmultiple install locations
- https://bugzil.la/557710
- need this for avoiding re-downloading (and signing+hosting) for default system add-ons
- addressed review feedback for onUpdateAvailable
- https://bugzil.la/1279012
- added better test for browser.runtime.reload()
- re-ran try build
- helped out with "out of date notification" system add-on
- addressed review feedback for onUpdateAvailable
- https://bugzil.la/1279012
- added better test for browser.runtime.reload()
- re-ran try build
- looked into issues testing system add-on for Firefox 44 on Windows XP
- https://bugzil.la/
- turned out AMO was serving a bad update, now fixed
- almost done addressing review feedback for browser.runtime.onUpdateAvailable
- https://bugzil.la/1279012
- should add better test for browser.runtime.reload() too
- in SF office, meetings etc.
- check if bad manifest (loaded from XPI) is cached
- e.g. "strict version" is set then later removed
- worked on monotonically-increasing revision for system add-ons
- https://bugzil.la/1292031
- have a patch, needs tests
- Existing JS scoping bug was fixed, which caused a system add-on test to fail
- https://bugzil.la/1291569
- turns out it wasn't running the tests we thought it was, fortunately only one minor feature had a legit broken test (empty add-on set means to remove all updates and to disable all built-in add-ons) - will probably just remove the feature.
- Added a few bugs to Osmose's system add-on revision tracking bug
- Ensure that all default system add-ons are present in Balrog response
- Use monotonically-increasing revision number from Balrog for each update set
- worked on postponed support for webextensions
- https://bugil.la/1279012
- pushed patch for review
- worked on making WebExtension tests better
- https://bugzil.la/1290617
- merged to inbound (needed for https://bugzil.la/1279012)
- worked on postponed support for webextensions
- https://bugil.la/1279012
- basically done, making tests nicer
- things like message passing from AddonManager -> WebExtension are hard
- lots of divergence across AddonManager/WebExt tests
- worked on making WebExtension tests better
- https://bugzil.la/1290617
- patch is pushed, waiting for review
- looked into QA results for "delayed add-on" patch
- worked on postponed support for webextensions
- added file extension feature to web-ext
- mozilla/web-ext#392
- this is making it painful to work on postponed support for webextensions
- meeting w/ mixedpuppy about gofaster
- worked on postponed support for webextensions
- review
- made sure we can re-enable disabled hidden/system add-ons via update
- they can no longer be disabled as of https://bugzil.la/1281077 but wanted to ensure that they will be re-enabled
- was working on https://bugzil.la/1283963 but maybe not needed?
- worked on ensuring system add-ons are enabled during updates
- worked on postponed upgrade support for system add-ons
- review for lock down on mozAddonManager.install()
- worked on ensuring system add-ons are enabled during updates
- PTO in the afternoon
- helped flesh out dynamic theming API for web extensions
- worked on allowing system add-ons to upgrade w/o restart
- reviewed bug to treat corrupt addons.json in AddonRepo as if it were missing
- drafted+sent email about DETH proto progress
- chatted w/ ddurst+willkg about what it'd take to fix snappy
- follow up on backout on patch landed for aswan
- https://bugzil.la/1287125
- he is back and can finish investigating
- chatted about symbolapi woes with various folks
- chatted about webextensions dynamic theming in #webextensions
- reviewed patch to further lock down navigator.mozAddonManager
- responded to standard8's gofaster email with more details about process changes/improvements in-progress
- chatted w/ Osmose about r-
- just mozreview misunderstanding
- https://bugzil.la/1284564
- chatted w/ markh about "only sync AMO hosted add-ons" woes
- https://bugzil.la/1285866
- going to do something like
addon.isHosted
in AddonManager API probably
- did a little symbolapi investigation
- looking at strace output w/ ddurst, race condition with files seems possible
- concurrency model is a bit baffling - there's tornado and concurrent.futures in use, and there are two processes. Need to figure this out before we can determine the problem for sure and make appropriate fix.
- PTO in the afternoon
- reviewed add-on manager sync bug
- responded to needinfo (testing needed) on new balrog throttle feature
- looked at snappy service strace output we added to watchdog script last week
- looks like it is stuck trying to read past the end of a cache file...
- started fleshing out DETH prototype
- https://github.com/rhelmer/deth-proto
- basic GET, DELETE, POST now work with local zone file
- early morning telemetry meeting
- starting reviewing patch to avoid syncing hidden/system add-ons
- https://bugzil.la/1275139
- chatted w/ markh about this in London, plan is to only sync add-ons in the profile, and have an isSyncable getter in the AddonManager API for Sync to use.
- filed bug with doc fix for system add-on spec
- https://bugzil.la/1284564
- also tested this and noticed a potential bug in the "default" case, may need a followup - see https://bugzil.la/1284564#c2
- investigated and added patch for reloading temporary web extensions
- worked on allowing system add-ons to delay upgrade
- landed bug preventing users from disabling hidden/system add-ons
- worked on allowing system add-ons to delay upgrade
- https://bugzil.la/1204156
- this requires making them install more like normal add-ons, and removing a lot of the current hard-coding.
- mostly working now, getting tests to pass and need to make some decisions like what to do if a set fails to upgrade. Also, one add-on delaying needs to delay upgrade for the whole set...
- looked into about:debugging temporary add-on loader issue w/ billm and kmag
- https://bugzil.la/1283676
- this is really a platform bug in nsIFilePicker, filed a bug to look into
that
- https://bugzil.la/1283680
- looks dead easy on Mac: https://developer.apple.com/library/mac/documentation/Cocoa/Reference/ApplicationKit/Classes/NSOpenPanel\_Class/index.html
- Windows (Vista+) and GTK would need more work, might be more than this feature warrants :/
- given that, might make sense to have a better workaround in the UI
- https://bugzil.la/1283680
- worked on bug preventing users from disabling hidden/system add-ons
- PTO
- pushed willkg's patch for snappy symbolication server
- mostly out sick
- a few small reviews
- Helped out w/ Brotli system add-on hotfix
- https://bugzil.la/1273547
- lack of XPI provider debugging made this harder than it should be
- filed https://bugzil.la/1281547 and pushed patch for review
- about:performance allows disabling system add-ons
- attached patch to https://bugzil.la/1260450, needs tests
- AddonManager should just ignore userDisabled state too, for system addons
- 1:1
-
chatted w/ add-on author nt1m about extending an API to control themes, so extensions can do dynamic theming in a way that will work for themes like CTR, VivaldiFox, Colorful Tabs, etc.
- Mozlondon
- pushed review for stub for webcompat fix system add-on
- https://bugzil.la/1268197
- landed
- pushed request for feedback for delaying add-on upgrade patch
- reviewed stackwalker changes to expose symbol URLs
- reviewed adding telemetry count for addon compat dialog
- looking into converting hello and pocket to web extensions
- reviews
- filling in for mossop
- in MV for the day
- reviews
- finished review for bug exposing addons to web content
- meetings
- chatted w/ luke about tracking protection
- chatted with bbell about UX for tracking protection addon
- Go Faster meeting
- 1:1
- pushed latest UX changes for stop-tracking addon
- review bug exposing addons to web content (for AMO only)
- worked on providing AddonManager API to support delaying restartless updates
- looked into Socorro issue since everbody else is out today
- worked on tracking protection add-on
- https://github.com/rhelmer/stop-tracking
- quick informal UX review from bwinton
- finished reviews
- https://bugzil.la/1246151
- fixed heroku token so auto-land works for symbols.m.o again
- https://bugzil.la/1244357
- https://bugzil.la/1244302
- https://bugzil.la/1246151
- r+ on telemetry environment bug
- https://bugzil.la/1232222
- addressed final review suggestions
- added "checkin-needed" keyword, as autoland is disabled at the moment
- PTO
- put telemetry environment patch up for review
- now blocking pocket/hello, needs uplift
- https://bugzil.la/1232222
- reviews
- continued working on telemetry environment patch up for review
- need to inject system add-on before startup
- https://bugzil.la/1232222
- reviews
- starting reviewing cert DB shim
- worked on adding test to telemetry side of https://bugzil.la/1232222
- gave some guidance in symbolapi outage bug
- https://bugzil.la/1244589
- vladan was managing this and has left
- shout-out to my rust replacement
- https://github.com/rhelmer/symbolapi
- works on heroku!
- reviews
- worked on adding test to telemetry side of https://bugzil.la/1232222
- meeting
PTO
- worked on adding test to telemetry side of https://bugzil.la/1232222
- the way telemetry tests add-ons makes this a little more difficult than what we do for add-ons manager, as there's no simple way to restart the AddonManager and the system add-on must be present in the features dir when the add-ons manager starts up
- 1:1
- addressed review comments on bug adding system add-on status to telemetry
- reviewed sideloading bug
- learned more about service workers
- researched Electron (the shell Atom and Brave use)
- uses node.js and brightray (not CEF)
- "thin shim over Chromium's Content module"
- https://github.com/atom/brightray
- not if it has process separation, or at least chrome/content distinction
- looks like the chromium content module embedding supports sandboxing
- uses node.js and brightray (not CEF)
- Put up review for adding system add-on status to telemetry environment
- https://bugzil.la/1232222
- addressed first round of review comments
- reviewed bug tracking whether a user has been offered side-loaded add-on
- informal code review for mythmon
- PTO
- PTO except for:
- early-morning Balrog+Hello meeting
- took misbehaving laptop to SF office
- Rust meetup in SF office 2016-01-20
- landed Object.values() removal, asked for approval to uplift to aurora
- worked on providing AddonManager API to support delaying restartless updates
- took a look at https://github.com/brave/browser-laptop
LICENSE.txt
says MPL, uses http://electron.atom.io/
- Object.values() isn't riding the trains, put up a review request to modify some ESLint-related refactoring
- worked on providing AddonManager API to support delaying restartless updates
- gofaster meeting
- worked on providing AddonManager API to support delaying restartless updates
- portland meetings
- flew to portland for meetings
- worked on providing AddonManager API to support delaying restartless updates
- worked on providing AddonManager API to support delaying restartless updates
- prep for portland trip
- worked on providing AddonManager API to support delaying restartless updates
- https://bugzil.la/1231172
- web extensions need this too, e.g. https://bugzil.la/1213473
- responded to question about real-time telemetry for system add-ons
- PTO
- Meetings in SF
- made some progress on https://bugzil.la/1232222 and https://bugzil.la/1230688
- Go Faster meeting
- Landed Bug 1209344 - Link to about:debugging from about:addons
- Mozlando
- reviewed a bunch of patches
- gofaster meeting
- restartless add-on patch merged to fx-team
- worked on Hello-as-addon blockers
- r+ on restartless add-on patch \o/
- reviewed signature verification for hotfixes
- reviewed removal special casing of experiments
- working with Hello team on landing Hello-as-addon
- discussed Socorro Fennec problem w/ peterbe
- reviewed+merged peterbe's fix https://bugzil.la/1221624
- all but one review comments done on unsigned restartless add-on patch
- started addressing review comments from Standard8 on Hello-as-addon
- https://github.com/mozilla/system-addons/tree/bug1186172-loop-as-addon
- a few more to go...
- work through review comments on unsigned restartless add-on patch
- met w/ phrawzty
- met w/ Hello team about landing add-on
- discussed what it would take to land, planned a few followups:
- pinged glandium about moz-central add-on packaging
- worked on rebasing system-addons repo against master
- chatted w/ mixedpuppy regarding pocket-as-addon
- put up "loading unsigned restartless add-ons at runtime" patch for review
- https://bugzil.la/1209341
- a few FIXME/TODOs in there, expect to have to resolve before landing
- worked on skinning problem with loop add-on
- toolbar icon is 36px but needs to be resized to 24px
- now a user stylesheet, used to be done in browser.css somewhere
- finally figured this out, thanks to gijs and dolske in #fx-team
- toolbar icon is 36px but needs to be resized to 24px
- more work on loading unsigned restartless add-ons at runtime
- more work on loading unsigned restartless add-ons at runtime
- https://bugzil.la/1209341
- tests work OK but not working from actual runtime yet
- more work on loading unsigned restartless add-ons at runtime
- https://bugzil.la/1209341
- made substantial progress - working through some test failures
- PTO in the afternoon
- worked on loading unsigned restartless add-ons at runtime
- PTO in the afternoon
- pushed latest loop-as-addon changes to system-addons fork
- https://github.com/mozilla/system-addons/pull/6
- only outstanding issue is toolbar icon size
- mbanner is going to help take a look
- worked on loading unsigned restartless add-ons at runtime
- took a look at current Places UI
- chrome uses (much simpler) separate UIs for bookmarks, history, etc.
- implemented in HTML
- chrome uses (much simpler) separate UIs for bookmarks, history, etc.
- figured out Socorro permissions problem
- crashmover was not running as proper user, if it ran first it'd create a directory that socorro user could not write to
- PTO afternoon (out sick)
- met w/ mossop regarding system-addon build+deploy pipeline
- looked at Socorro collector permissions problem a bit more
- just started happening on staging, jp to file bug if it keeps happening
- probably a bug in RPM packaging
- made progress on porting over loop skin
- wrestling with CSS - used CPP #include in ./browser :/
- helped look at Socorro collector permissions problem
- discussed build/release strategy for system-addons
- planning on installing system add-on unpacked in appdir
- shipping xpi in final build for startup/runtime perf
- this seems to work already \o/
- Go Faster meeting
- finished reviewing "purge outdated system add-ons" bug
- rebased system-addons fork, tested loop
- works but requires signing currently
- met w/ dmose in SF about Hello
- TAG meeting
- reviewed bug for purging outdated system add-ons
- discussed config/secrets mgmt w/ peterbe for socorro
- tryserver run for jgriffin to review
- started working on loading unsigned restartless add-ons at runtime
- let devtools folks know about "system add-ons" plans
- met with jgriffin/catlee/jp about build + test
- reviewed https://bugzil.la/1193973
- rebased loop add-on prototype for mbanner to review
- put on gh to make it easier
- met with mbanner re: loop-as-addon
- investigated allowing unsigned restartless add-ons for dev purposes
- Go Faster meeting
- PTO in the afternoon
- finished reviewing remaining system-addons bugs
- reviewed remaining system-addons bugs
- loop add-on passes validation, but still no automated signing :/
- working with folks in #addons
- turned out to be a bug in the display of errors+warnings
- started google doc to describe/track system-addons build pipeline status
- working on reviewing several new system add-on features
- graded more python tests
- worked on Loop theme issues
- figured out w/ mossop's help, missing trailing / in manifest :/
- got working x-platform firefox desktop builds w/o built-in loop
- wrestled with getting loop through the AMO validator
- put aside taskcluster-github for now
- it'll be really handy, when it supports x-platform firefox desktop builds
- worked on getting my patch going under try server
- got a working desktop build from taskcluster-github
- standard firefox-desktop docker image not quite working
- symbol upload failing etc.
- standard firefox-desktop docker image not quite working
- worked on build pipeline prototype for Go Faster
- using taskcluster-github integration
- pushed my repo + patch to https://github.com/mozilla/system-addons
- TAG meeting
- advised on reports monitoring
- started working on getting my moz-central fork building under taskcluster
- 1:1
- helped out w/ Socorro reporting and monitoring
- monitoring set up before the AWS move is being phased out
- making more things that work under simple third-party monitoring svcs
- still getting over cold
- helped out with Socorro reports problem
- graded more python tests
- Go Faster meeting
- reviewed system add-on update patch
- out sick in afternoon
- sick today, sort-of working
- worked w/ jp on build pipeline
- graded python tests
- reviewed patch to fix themes being disabled after addon update/install
- PTO
- Started helping out with system add-on build pipeline prototype
- worked on getting loop tests working in browser/extensions/loop
- looked into what we want taskcluster to do:
- regular firefox build + upload
- run loop marionette tests
- if test pass:
- upload to AMO for signing+hosting
- update balrog with update info
- Took a look at crash correlations
- Worked on Hello prototype add-on
- moved themes into add-on
- still some OS-specific work to do, seems OK on Mac now
- pushed to bitbucket
- updated bug
- moved themes into add-on
- cleaned up local hg workspace
- worked on bug about Firefox deleting invalid proxy add-ons
- Go Faster meeting
- helped out with Socorro correlations reports being late
- came up with plan for monitoring w/ peterbe+jp
- discussed getting deploy steps right on stage
- backfilling ongoing
- review for system add-on signing
- ported a test add-on to Web Extensions API
- noticed panel is in the wrong place, same as current Add-on SDK
- https://bugzil.la/1199052
- discussed w/ billm in IRC - probably should make opening in menu the default for browserAction API if the button has been moved into the menu, with an optional argument to have a custom panel
- found bug with browserAction API (missing context menu entries)
- noticed panel is in the wrong place, same as current Add-on SDK
- started working on bug about Firefox deleting invalid proxy add-ons
- PTO
- Done with system add-ons review
- https://bugzil.la/1192921
- r+, nothing serious, testing all went fine
- Reviewed Socorro symbol re-encoding PR
- Still working on system add-ons review
- https://bugzil.la/1192921
- finished reviewing code, mostly testing
- Still working on system add-ons review
- https://bugzil.la/1192921
- re-read PRD, following update discussion
- testing with a dumb simple add-on
- going to test w/ the prototype Loop add-on once that's working
- Go Faster meeting
- 1:1
- Worked on review for system add-ons changes
- PTO
- Updated Loop prototype bug with progress
- Worked on moving final bits from ./browser to add-on
- browser/theme/loop
- mostly done, need to put in a bunch of OS version-specific overrides
- about:loop page registration
- getting a crash in about:loopconversation :/
- generated symbols and got a stack, may have to bust out lldb
- getting a crash in about:loopconversation :/
- browser/theme/loop
- finally got around to making a test case and filing max-tabs add-on crash
- Loop Add-on totally working \o/
- shared a video with interested folks
- spent most of the day testing
- sent and responded to email on go-faster list
- Go Faster meeting
- Loop Add-on button works, panel opens
- something still off about the about: -> chrome:// hookup
- circulated doc on challenges of Loop-as-addon
- lots of follow-up discussion
- put up patch for removing #ifdefs from UITour.jsm
- https://bugzil.la/1195962
- r+ and landed!
- worked on moving loop code to add-on, monorepo-style
- https://bitbucket.org/rhelmer/mozilla-central
- no longer using SDK
- re-using pretty much all the existing code
- button appears but doesn't quite work yet
- just need to inject mozLoopAPI
- patch for install.rdf preference landed
- first patch in mozilla-central/toolkit authored by me \o/
- https://bugzil.la/1196301
- backfill for correlations being broken
- discussed monitoring options w/ jp, maybe consul service check?
- worked on removing loop from browser, reimplementing as add-on
- I think this is a better approach than the "chrome override" add-on
- updated https://bugzil.la/1186172#c6 with latest thoughts
- started google doc exploring external libraries/frameworks/etc.
- found some preliminary answers about react.js in particular
- looked into why MozReview didn't work for https://bugzil.la/1196301
- was because I uploaded patch view review board web interface
- set up hg tools like mozreview/bugzilla plugins
- crash correlations not running
- https://bugzil.la/1196598
- turned out that analysis node is under-spec'd, causing other troubles
- patch for add-on manager bug (prefer install.rdf to manifest.json)
- worked on setting up hg+bz+rb integration
- self-triage (unassigned and closed old self-assigned bugs)
- investigated add-on manager bug (possible signing bug w/ proxy add-on)
- Go Faster meeting
- helped out w/ symbols/reprocessing for Firefox iOS crashes
- reprocessed Thunderbird crashes for missing symbols
- helped out w/ Socorro bugs
- got peterbe access to run ./manage.py
- ADI now works on stage \o/
- restored prod DB snapshot on stage
- crash-analysis node needed some attention
- moar stage Socorro ADI work
- hopefully the last of it - socorro-adi needs code update
- this is RHEL6 and can't use the standard Socorro RPM :/
- hopefully the last of it - socorro-adi needs code update
- Socorro meeting
- urgent symbols bug https://bugzil.la/1193841
- temp fix for bad cert on crash-analysis https://bugzil.la/1193946
- Go Faster meeting
- 1:1
- reviewed mozilla-services/socorro#2945
- investigated what's needed to get prototype loop add-on totally working
- can we override about: handlers?
- if not:
- chrome overrides
- replace button
- I think this is needed, to inject mozLoopAPI
- filed Socorro bug 1192869
- looked into Socorro stage issues, blocking ADI work
- Django just needed to allow crash-stats.allizom.org
- ADI still not working for Socorro stage
- checked on Socorro ADI - working for prod, not for stage still
- manually copied ADI over for now
- helped out with a few urgent Socorro bugs
- meeting about go faster + l10n
- basic chrome override approach working in loop prototype
- doesn't work yet for JS which expects navigator.{mozLoop, L10n}
- Socorro stage ADI push still not working, loaded config for peterbe
- worked on loop prototype, uploaded to github
- Socorro meeting
- Go Faster meeting
- add-ons manager review for https://bugzil.la/1190966
- PG disk space getting low in Socorro, commented in https://bugzil.la/1191006
- chatted w/ standard8 and mossop about loop prototype
- Socorro meeting
- went over AWS migration and current PHX production issues
- tested RDS migration (production)
- fought fires
- bug 1156961 - put up PR, so ftpscraper handles 38.0.5b99
- tested RDS migration (production)
- fought fires
- bug 1168511 - bad JSON causing trouble in Postgres, blocking crontabber
- bug 1156961 - put up PR, so ftpscraper handles 38.0.5b99
- landed a few socorro-infra PRs
- went into office, replaced Macbook power adapter
- reviewed phrawzty's ES AWS PR
- practiced RDS migration (stage)
- going to turn off access until "core" transfer is done
- current partitions are now part of "core"
- PHX processors can write to AWS rabbitmq when datastores are sync'd enough
- going to turn off access until "core" transfer is done
- progress on S3 symbol storage
- packaged snappy (symbolapi.m.o)
- tested S3 symbol upload on stage w/ ted
- found small % of crashes not being processed
- bug 1118269
- reviewed fix mozilla-services/socorro#2549
- looked into FTP scraping problem
- bug 1118224
- filed bug(s) to move Socorro to AWS
- tracking bug 1118288
- shut down hbase, on S3 only now \o/
- shipped release to fix logging issue that was breaking nagios monitor
- tracked down date-dependent unittest bug
- bug 1117250
- worked on Socorro HBase-to-S3 move
- pushed production config live
- pushed graphserver update
- bug 1021842
- worked on Socorro HBase-to-S3 move
- production sync finished
- PTO
- worked on Socorro HBase-to-S3 move
- worked on Socorro HBase-to-S3 move
- worked on Socorro HBase-to-S3 move
- configured Socorro staging to use HBase as crash source
- bug 1108974
- configured Socorro prod to store in S3 alongside hbase
- bug 1108977
- asked tmary to start sync/backfill (ETA ~1 week)
- worked on test plan+scripts for when backfill is complete
- configured Socorro staging to use HBase as crash source
- PTO
- mozlandia workweek
- reviewed AUS patch
- bug 1102283
- skipped elmo meeting
- socorro meeting
- tested new "missing symbols" table on stage
- still a few followups, bug 948644
- PTO
- tested S3 sync w/ tmary
- Socorro expects a "dump names" object as well
- researched compression options
- interviewed potential DXR interns
- discussed S3 sync w/ tmary
- helped review+test AUS patch in bug 1102283
- first had to spin up new staging box, bug 1102413
- moar reviews+discussion on S3 for socorro blockers
- elmo meeting
- pushed bbot-ES change live \o/
- socorro meeting
- continued work on blockers to making S3 live
- reviewed bug 1093888 to get middleware+S3 working
- worked on related config
- reviewed bug 1093888 to get middleware+S3 working
- continued work on blockers to making S3 live
- bug 948644 PR# 2487
- bug 1098954 PR# 2485
- worked with cyliang on using knapsack to copy l10n ES indexes
- now working \o/
- reviewed graphserver patch to enable geometric mean in UI
- bug 1077177
- deployed graphserver code for above
- bug 1101156
- worked on blockers to making S3 live
- bug 948644
- bug 1098954
- collection + processing using S3 is live on socorro stage
- worked on debugging socorro S3 stage
- looked into why ES knapsack plugin isn't working for l10n
- looks like zeus timeouts
- worked on getting S3 going on socorro stage
- look into a10n hang (prod)
- ended up restarting, should try debugging w/ gdb next time
- elmo meeting
- worked out plan for pushing ES live today/tomorrow
- socorro meeting
- starting working on enabling S3 in Socorro stage (bug 1097916)
- met with ted/lonnen about symbol storage in S3
- decided to tackle crashstorage this q, symbols next
- symbols have longer, more complex dependency chain
- decided to tackle crashstorage this q, symbols next
- worked on and withdrew Socorro encryption class
- boto should be able to handle encryption in transit
- worked on graphserver issue w/ jmaher
- data problem, jmaher fixed
- graphserver no longer blows up on invalid data, bug 1094029
- pushed in bug 1094308
- finished up bug 1093289
- 1:1
- took on encrypt/decrypt blobs bug
- graphserver blow-up, bug 1094029
- worked on broken correlations (broken by pipe-dump-to-JSON switch)
- bug 1093289
- Socorro meeting
- watched lars make the collector config transition
- Elmo meeting
- helped w/ graphserver reviews+release
- moving bbot to a10n workers
- elmo meeting (canceled)
- helped test bouncer innodb transition
- socorro reviews
- elmo meeting
- roll back raven on a10n
- intro to inventory from uberj
- looked into why some b2g signatures have empty reports tab
- started working on adu-by-signature followup
- started working on middleware for new correlations tables
- reviewed raven rollback bug
- filed follow on adu-by-signature bug
- migrated a10n to new database
- fixed bug in correlations
- more progress on getting tests going for tuxedo/bouncer
- landed correlations
- landed adu-by-signature middleware
- start of releng workweek
- start of webeng workweek
- l10n/elmo meeting
- fix logging in a10n https://bugzil.la/987203
- look on/work on http://pike.github.io/a10n/design/
- socorro
- fix regression in topcrasher-by-bug report
- socorro
- landed UI fixes for topcrasher-by-bug report
- elmo
- followed up w/ jd about new a10n server
- posted more detailed into to bug
- followed up w/ jd about new a10n server
- socorro
- fixed TCBS cache problem
- dashcon
- socorro
- fixed correlation reports
- dashcon
- class
- etherpad
- shipping bug unblocked
- finding out if current sec review is sufficient to skip
- socorro
- looking into correlations problems
-
etherpad
- waiting for sec/ops clearance to launch
-
socorro
- meeting
- decided to take PR 1762
- needs moar testing
- decided to take PR 1762
- reviews
- meeting
- bouncer
- more work on tuxedo tests
- most API test failures seem to be due to auth problem
- fixed issue w/ unreadable API docs
- missing markup
- vendor lib needs some work, pretty out of date
- more work on tuxedo tests
- etherpad-lite
- got ep+mysql working on stackato stage
- soft-launch empty install on prod?
- bouncer
- got access to prod data snapshot
- got bouncer+tuxedo working locally
- reviewed/merged tuxedo patch from rail to set SSL via API
- currently on stage
- etherpad-lite
- updated stackato stage/prod to latest release
- worked on getting to mysql (only supported prod option right now)
- bouncer
- worked on getting tests running on jenkins
- chatted w/ wenzel, got the basic infra going
- need to get test data, filed bug 958756 to get current prod DB dump
- worked on getting tests running on jenkins
- socorro
- reviews
- class
- socorro
- reviews
- bouncer
- worked on getting tests running on jenkins
- socorro
- meeting
- reviews
- socorro
- worked on "topcrash for all signatures of a bug" followups
- landed one, made progress on another
- worked on "topcrash for all signatures of a bug" followups
- bouncer
- met with brandonsavage re: handover
- set up CI job for bouncer
- needs some work to go green https://ci.mozilla.org/job/tuxedo/
- l10n
- meeting
- follow up w/ IT on new a10n server
- look into potential hg leak
- think about goals
- meeting
- socorro
- meeting
- discussed bouncer issue
- worked on UI for "topcrash ranks for all signatures of a bug"
- socorro
- landed new service + model for "topcrash rank for all signatures of a bug"
- socorro
- worked on service + model for "topcrash rank for all signatures of a bug"
- socorro
- worked on service + model for "topcrash rank for all signatures of a bug"
- out part of day w/ dentist appt
- socorro
- meeting
- working on "topcrash ranks for all signatures of a bug"
- https://bugzilla.mozilla.org/show_bug.cgi?id=915373
- not possible to do w/ SQL alone at this time
- working on composing using existing API + new SignaturesByBugs
- socorro
- meeting
- working on SQL query for "topcrash ranks for all signatures of a bug"
- socorro
- reviews
-
eddy
- now working (w/ hardcoded app), publishing to datazilla
-
etherpad
- just realized that new migration test VM is ready!
- eddy
- work on hooking up jenkins hamachi b2g testers
- l10n
- meeting
- enabled sentry for a10n
-
l10n
- meeting
- coordinate downtime/hg upgrade
- ping jd re: prod a10n
- meeting
-
socorro
- reviews
- socorro
- worked on review on automatically install/run script
- static build of stackwalker
- socorro
- worked on review on automatically install/run script
- helped w/ stackwalker rollout
- socorro
- meeting
- tracked down probable cause of signature history bug
- l10n
- meeting w/ jd and pike, finalizing stage and planning production
- https://etherpad.mozilla.org/a10n-puppet
- jd is working on it, will let us know in the next few weeks
- meeting w/ jd and pike, finalizing stage and planning production
-
socorro
- reviews
- PRs
- automate setup/run of socorro dev mode
-
l10n
- meeting
- chatted w/ shyam about prod hardware for a10n
- he is checking into it, seamicro nodes
- might be different group now
- set up meeting with hd, pike, rhelmer
- socorro
- reviews
- l10n
- following up on a10n server warnings
- socorro
- reviews
- l10n
- a10n server up and running
- l10n
- followed up on why a10n is not queueing/working as expected
- filed bug to set up a10n user
Summit recovery - got some Socorro refactoring and other misc work in.
- l10n
- followup on a10n VM install (almost done)
- graphserver
- reviewed and pushed graphserver feature
- l10n
- meeting
- finish up a10n install
- filed bugs to get access to elmo DB
- installed packages and set up test environment on VM
- eddy
- chatted w/ andym about adding new eddy API to marketplace
- eddy
- meeting w/ davehunt and stephend
- elmo
- meeting
- need to finish up a10n VM install
- meeting
- eddy
- apps show-and-tell
- https://vreplay.mozilla.com/replay/showRecordingExternal.html?key=hs9K5MBSw9SIYHm
- feedback generall positive
- probably more useful to surface to app developers
- simple to do, working on adjusting PR
- chatted w/ stephend re: new phones
- incoming "hamachi" phones are not working w/ b2gperf yet
- no way to queue incoming requests to jenkins, yet
- apps show-and-tell
- socorro
- reviews
- eddy
- patched b2gperf to handle overriding app name
- this makes it work with mkt "app_slug" names \o/
- patched b2gperf to handle overriding app name
- socorro
- reviews
- eddy
- meeting w/ davehunt and stephend
- elmo
- meeting
- need to finish up a10n VM install
- meeting
- eddy
- apps show-and-tell
- https://vreplay.mozilla.com/replay/showRecordingExternal.html?key=hs9K5MBSw9SIYHm
- feedback generall positive
- probably more useful to surface to app developers
- simple to do, working on adjusting PR
- chatted w/ stephend re: new phones
- incoming "hamachi" phones are not working w/ b2gperf yet
- no way to queue incoming requests to jenkins, yet
- apps show-and-tell
- socorro
- reviews
- eddy
- patched b2gperf to handle overriding app name
- this makes it work with mkt "app_slug" names \o/
- patched b2gperf to handle overriding app name
- socorro
- reviews
- socorro
- meeting
- reviews
- socorro
- reviews
- landed install docs + vagrant reboot
- started working on socorro/b2g release channel bug
- eddy
- chatted w/ andym re: auth for marketplace API
- need to set up oauth review user for eddy
- made marketplace-datazilla JS able to load arbitrary apps
- chatted w/ andym re: auth for marketplace API
- socorro
- reviews
- worked on install docs + vagrant reboot
- eddy
- get download app loading on device \o/
- lots of testing with random apps
- seems to work!
- eddy
- provide way to query if job is already in the queue
- socorro
- meeting
- reviews
- eddy
- hooked up "perf test app" button properly
- made web service take POST for submissions not GET
- researched actually loading phone onto device
- socorro
- helped installer on mailing list
- filed bug about simplifying vagrant
- eddy
- added basic "test app" button to perfcharts branch
- l10n
- meeting
- working on finishing up a10n deploy
- eddy
- started marketplace review dashboard integration
- graphserver
- pushed minor fix for b2g-inbound hg repo links
- eddy
- added flask+celery+rabbitmq support to eddy
- simple endpoint for marketplace reviewer dashboard to hit
- celery worker runs test and submits to datazilla
- trying to figure out why b2gperf does not like my unagi build
- missing build_revision so will not report to datazilla :/
- added flask+celery+rabbitmq support to eddy
- socorro
- eddy
- published repo with eddy-specific work so far
- socorro
- meeting, post-mortem
- backfilling for "corrupted modulelist output" bug
- eddy
- worked on REST service for launching b2gperf tests from marketplace
- socorro
- worked on "corrupted modulelist output" bug with harsha
- graphserver
- helped with graphserver db archiving
- socorro
- filed bug on update tcbs problem
- eddy
- got b2gperf running w/ andym's stopwatch app
- sent email re: next steps
- socorro
- put up PR for fakedata bug
- put up PR to fix b2g scraping problem
- release-api
- solarce working on putting standalone scraper on generic cluster
- graphserver
- chatted w/ bz about graphserver feature request
-
eddy
- start testing b2gperf with third-party packaged apps
- https://github.com/mozilla/b2gperf
- flashed unagi w/ marionette
- still working on getting b2gperf going
- start testing b2gperf with third-party packaged apps
-
graphserver
- reviewed sorting patch
- socorro
- filed followup bugs from workweek
- promoted split-out ftp scraper to other teams, #ateam is interested
- etherpad-lite
- investigated spellcheck request
- chatted about hand-off, launching MVP etc.
- socorro
- stability workweek
- extracted ftpscraper from socorro to standalone service
- socorro
- followup bug from yesterday's PR
- elmo
- testing a10n setup
- discussed deploy script w/ erikrose
- testing a10n setup
- socorro
- worked on table count bug
- helped out with missing ADI backfill
- graphserver
- followed up on contribution
- elmo
- weekly meeting
- looked into elmo test failure
- turns out was failing on jenkins too but reported as passed!
- followed up on bugs from Friday w/ Axel
- elmo
- got a10n starting under supervisord
- filed bugs to track changes so far
- filed bug to track (continuous) deployment script
- filed bug about puppetizing a10n VM
- bugs in a10n twistd app that block deployment
- tracker bug for deploying new VM
- eddy
- submitted test data via
datazilla_client
- submitted test data via
- elmo
- got a10n working in local dev env
- working on startup scripts (supervisord)
- socorro
- email/irc chatter about dev/stage data sync issues
- elmo
- figuring out bugs in test setup script
- worked out plan for standard deployment script w/ ErikRose
- socorro
- weekly meeting
- answer random irc queries :)
- elmo
- discussed deployment strategy w/ solarce
- local VM issues, plowed through
- socorro
- PR to speed up socorro-vagrant jenkins job
- mozilla-services/socorro#1387
- 1h20m -> ~40m
- PR to speed up socorro-vagrant jenkins job
- elmo
- attended elmo meeting
- went over a10n test setup w/ axel
- http://pike.github.io/a10n/test-setup/
- now working locally
- socorro
- reviewed mozilla-services/socorro#1382
- eddy
- chatted w/ ctalbert about running tests
- followup w/ stephend + davehunt on Monday
- reviewed info jeads sent a while back for testing /marketapps endpoint
- chatted w/ ctalbert about running tests
- socorro
- helped peterbe w/ webapp-django -> devdb
- helped out w/ configman mware setup
- graphserver
- shipped y-axis patch (https://bugzil.la/641413)
- elmo
- got working settings/local.py from Pike, will contribute fixes for local.py-dev so others do not trip on yesterday's problems
- socorro
- reviewed mozilla-services/socorro#1375
- investigated https://bugzil.la/898432
- elmo
- weekly meeting
- helped look at jenkins test failure, filed https://bugzil.la/899160
- continued puppet and basic setup in vagrant VM
- plan to hand this basic puppet setup off to IT for new prod VM setup
- does not start up - seems to not be finding settings/local.py
- eddy
- merged perfcharts branch to latest https://github.com/rhelmer/zamboni
- got zamboni running on new laptop
- socorro
- graphserver
- sent email to dev-planning about upcoming y-axis feature
- has been in the pipeline for months, recently unblocked
- sent email to dev-planning about upcoming y-axis feature
- pushlog
- did some analysis on access logs for load-testing purposes
- socorro
- chatted w/ socorro installer
- got them interested in my Go collector/processor :)
- chatted w/ socorro installer
- elmo
- more work on a10n VM puppet manifests
- eddy
- started beating zamboni patch into shape
- socorro
- helped mjrosenb w/ ad-hoc query
- picked up bad fix of mine https://bugzil.la/898432
- graphserver
- helped mbrubeck pick up some volunteer tasks, until datazilla is ready
- removed index page https://bugzil.la/898640
- finished out https://bugzil.la/835751 for sheeri
- pushed three releases (v2.3.8, v2.3.9 and v2.3.10)
- helped mbrubeck pick up some volunteer tasks, until datazilla is ready
- elmo
- worked on puppet for a10n VM
- eddy
- SfN meeting, nothing to report
- socorro
- reviews
- looking at JSON encoding issue w/ kairo
- helped external user w/ install (oleavr)
- graphserver
- put up patch for review on perf problems (https://bugzil.la/835751)
- elmo
- worked on access to new a10n VM + puppet w/ rbryce
- eddy
- delays due to viscosity/tunnelblick problems
- socorro
- followed up on dev and vagrant problems (https://bugzil.la/892271)
- graphserver
- followed up on perf problems https://bugzil.la/835751
- https://bugzil.la/897580
- etherpad
- discussions with jakem
- https://bugzil.la/897693