fix(cli): resolve project config under projectRoot deno.json (prod D1)#148
Merged
Conversation
Owner
Author
|
[PHASE: IMPL] [VERDICT: PASS] Implemented the prod D1 config-loader fix and completed separate IMPL-EVAL PASS. Scope
Commits
Validation
Release GateFinal closure still requires publishing alpha.9 and observing a GREEN release-triggered |
rickylabs
marked this pull request as ready for review
June 26, 2026 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the prod-only CLI config-loading failure by loading project config through a CLI-owned child Deno process rooted at the scaffolded project's
deno.json. This keeps@netscript/configpure while makingnetscript plugin listand other config-loading CLI paths resolve@netscript/configfrom the generated project import map.Scope
packages/cliArchetype 6 CLI/tooling; consumed@netscript/configcontract remains Archetype 1.llm/tmp/run/fix-cli-config-loader-resolution--prod-d1/Slices
a5e95ad87d077cbb788e16ecValidation
deno test --allow-all packages/cli/src/kernel/adapters/config/project-config-loader_test.ts packages/cli/src/kernel/adapters/config/plugin-registry.test.ts— PASS, 7 passed / 0 faileddeno run --allow-read --allow-run .llm/tools/run-deno-check.ts --root packages/cli --ext ts,tsx --pretty— PASS, 524 files, 5 batches, 0 faileddeno lint --no-config <9 touched CLI files>— PASSdeno fmt --check <9 touched CLI files>with repo-style inline config — PASSplugin listfrom inside project and via--project-root— PASSdeno task publish:dry-run— PASS, existing warnings onlydeno task e2e:cli run scaffold.runtime --cleanup --format pretty— PASS, 47 passed / 0 faileddeno task arch:check— BLOCKED_UNRELATED by pre-existingDEPS-JSR-CENTRALIZATIONfailures for divergent@netscript/aspireand@netscript/pluginranges; this PR does not touch dependency rangesHarness
.llm/tmp/run/fix-cli-config-loader-resolution--prod-d1/Drift / Debt
pluginListCommandsymbol and was updated to the new factory.Release Gate
Do not treat this defect as finally closed until alpha.9 is published and the release-triggered
e2e-cli-prodrun is GREEN against the freshly published prerelease.