Conversation
|
@GianlucaGuarini sure. Will do. @gdub22 Thanks! I'm bit busy now, I'll check it tomorrow ;) |
|
@gdub22 I'm a bit new to the server-side Riot, so it's been taking a time to review it. Thank you for waiting. |
|
Thanks for reviewing. I can separate the tests when I get some time. I kept it in the same file because it was easier to run the same specs on both browser and server. |
|
@gdub22 I'm going to merge this after releasing of v2.3.0 of Riot.js. I'll be back soon. Sorry. |
|
Excellent! I just fixed the conflicts |
|
@cognitom I am having problems merging the |
|
@GianlucaGuarini can I roll back this merge commit? I need to check this PR more, because some API has been changed. It seems better to focus to only fix for v2.3.1. |
|
@cognitom ok sorry I thought It wasn't that hard |
|
No prob ;-) |
|
@cognitom @GianlucaGuarini Besides resolving any conflicts, what can I do to get this re-merged? |
|
I would like to give the lead to @cognitom on this because last time I merged It was a disaster.. 😄 |
|
Oh, sorry. What I have to do is just making a time. I'm still not familiar with server-side riot. |
|
I am not even sure it's needed.. I ended up with express and this solution that works pretty well https://github.com/GianlucaGuarini/riot-app-example/blob/master/shared/routes.js |
|
@cognitom @GianlucaGuarini If this will help you, I can break it up into a few PRs:
FYI I'm already using this successfully in production. |
|
@gdub22 can you please update your pull request making a new one on the current codebase? |
|
@GianlucaGuarini yes, could you sync the dev branch? It looks far behind master |
|
I guess @cognitom could help you on that I don't want to destroy everything again like I did last time. Could you collaborate you guys working on this task? |
|
@gdub22 btw I have merged the master into the dev branch so you can start patching it |
execmethod now takes an optionalpathparameter which can be used on the server. This allows the server to use your route handling logic to control what's rendered.