Skip to content

Server-side support (part 2 of 2: api)#45

Merged
cognitom merged 1 commit intoriot:devfrom
gpoitch:server-api
Dec 27, 2015
Merged

Server-side support (part 2 of 2: api)#45
cognitom merged 1 commit intoriot:devfrom
gpoitch:server-api

Conversation

@gpoitch
Copy link
Contributor

@gpoitch gpoitch commented Dec 21, 2015

This is a follow up to part 1 (#43) of server-side support. The api method to go to a route: route(path) now works server-side.

This adds a new API method: route.render(path) so your route handlers can be directly executed on the server. Alternatively, we could allow the existing route.exec() to accept an optional path parameter, which I did in my first implementation (#19 (reverted))

@GianlucaGuarini
Copy link
Member

I would like to avoid a new method.. cant we reuse simply route('path')?

@gpoitch gpoitch changed the title API to handle routing server-side Server-side support (part 2 of 2: api) Dec 21, 2015
@gpoitch
Copy link
Contributor Author

gpoitch commented Dec 22, 2015

@GianlucaGuarini Good idea. Updated.

@GianlucaGuarini
Copy link
Member

Much better @cognitom I guess we could merge this right?

@cognitom cognitom self-assigned this Dec 26, 2015
@cognitom
Copy link
Member

@gdub22 great! Thank you.

cognitom added a commit that referenced this pull request Dec 27, 2015
Server-side support (part 2 of 2: api)
@cognitom cognitom merged commit b53d0d7 into riot:dev Dec 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants