Use context helpers more broadly in the codebase#1329
Merged
Conversation
This one follows up #1277 just to apply the same pattern more broadly. It's not strictly needed, but it should result in some improved error messages, and give us some material for a blog post. I told Codex not to bother applying it to any places where we'd have to deviate too much from the normal pattern or do anything weird, so included are just the spots where `WithTimeout`/`WithTimeoutV` applies cleanly.
Contributor
Author
|
@bgentry Just one more for the release tmr plz. |
Contributor
|
@codex review |
bgentry
approved these changes
Jul 24, 2026
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
brandur
added a commit
that referenced
this pull request
Jul 24, 2026
Just a small fix for v0.41.0 -- I accidentally forgot to update the number at the top of the version banner. Also add an entry for #1329 since it can't hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one follows up #1277 just to apply the same pattern more broadly.
It's not strictly needed, but it should result in some improved error
messages, and give us some material for a blog post.
I told Codex not to bother applying it to any places where we'd have to
deviate too much from the normal pattern or do anything weird, so
included are just the spots where
WithTimeout/WithTimeoutVappliescleanly.