chore: impl canInvoke for matchmaker#4253
Conversation
|
🚅 Deployed to the rivet-pr-4253 environment in rivet-frontend
|
PR Review: chore: impl canInvoke for matchmakerThis PR adds fine-grained access control via Migration Gaps for Existing DatabasesThe Arena matchmaker.ts: The Ranked matchmaker.ts: The Fix: add the missing SQL Injection Pattern in ensureColumnBoth await dbHandle.execute(`PRAGMA table_info(${table})`);
await dbHandle.execute(`ALTER TABLE ${table} ADD COLUMN ${column} ${definition}`);The TypeScript union types restrict the inputs to known literals so there is no actual injection risk, but the pattern looks unsafe to readers. Either add a comment explaining why it is safe, or use a lookup table to make the constraint explicit. physics2dGame.ts: myConnId May Be Left UnsetThe PR removes the block that captured the connection ID: // Removed:
(handle as unknown as { id: Promise<string> }).id?.then?.((id: string) => {
this.myConnId = id;
});If Minor: Polling Interval Has No JitterThe 200 ms fixed polling interval in Positive Observations
SummaryThe two migration gaps are the main actionable items — they cause broken queries on upgrade for any deployed instance of the example. The rest are low-priority notes. |
345a3a6 to
4214c51
Compare
7f0daef to
2299455
Compare
4214c51 to
bf27e5e
Compare
2299455 to
5cd4249
Compare
5cd4249 to
f5dbebd
Compare
bf27e5e to
d25039e
Compare
d25039e to
bf27e5e
Compare
f5dbebd to
5cd4249
Compare
bf27e5e to
99744bc
Compare
5cd4249 to
d1bce69
Compare
99744bc to
7096692
Compare
d1bce69 to
2654312
Compare
2654312 to
b9b4e42
Compare
7096692 to
2cceca3
Compare
b9b4e42 to
d1bce69
Compare
2cceca3 to
99744bc
Compare
f8289f9 to
b8a2b15
Compare
d1bce69 to
a809615
Compare
b8a2b15 to
369aef4
Compare
a809615 to
b96f19e
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: