Skip to content

Comments

docs: document queue with interval pattern#4265

Merged
NathanFlurry merged 10 commits intomainfrom
02-22-docs_document_queue_with_interval_pattern
Feb 24, 2026
Merged

docs: document queue with interval pattern#4265
NathanFlurry merged 10 commits intomainfrom
02-22-docs_document_queue_with_interval_pattern

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@NathanFlurry NathanFlurry mentioned this pull request Feb 23, 2026
11 tasks
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4265 February 23, 2026 06:41 Destroyed
@railway-app
Copy link

railway-app bot commented Feb 23, 2026

🚅 Deployed to the rivet-pr-4265 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 23, 2026 at 6:51 am
mcp-hub ✅ Success (View Logs) Web Feb 23, 2026 at 6:42 am
frontend-inspector ❌ Build Failed (View Logs) Web Feb 23, 2026 at 6:41 am
frontend-cloud ❌ Build Failed (View Logs) Web Feb 23, 2026 at 6:41 am
ladle ❌ Build Failed (View Logs) Web Feb 23, 2026 at 6:41 am

Copy link
Member Author

NathanFlurry commented Feb 23, 2026


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 23, 2026

PR Review: docs: document queue with interval pattern

Note: This review supersedes the previous automated review on this PR.

Summary

This PR adds three categories of content, all documentation/configuration files with no production Rust or TypeScript code changes:

  1. Agent notes and specs (.agent/): Friction log, game example issues log, multiplayer cookbook, and 7 game design specs.
  2. OpenSpec OPSX slash commands (.claude/commands/opsx/): 11 new command definition files for the OpenSpec workflow tool.
  3. OpenSpec skills (.claude/skills/): Matching skill files for the same OpenSpec operations.

General Observations

Strengths:

  • The game specs in .agent/specs/games/ are detailed and well-structured. Each spec covers summary, goals, non-goals, actor design, networking, security checklist, and testing. The consistency across all seven specs is good.
  • The multiplayer cookbook (.agent/notes/multiplayer-cookbook.md) is a solid reference document covering matchmaking patterns, game loop tick rates, physics recommendations, security baselines, and testing patterns.
  • The OPSX commands and skill files maintain consistency between the two invocation surfaces.
  • The friction log (.agent/friction/rivetkit.md) concisely captures real pain points from the spec writing session.

Issues Found

1. PR title does not match content

The PR title is 'docs: document queue with interval pattern', but the actual content is entirely about game example specs, multiplayer cookbooks, and OpenSpec workflow tooling.

Recommendation: Update the PR title to something like docs: add game example specs and OpenSpec workflow commands.


2. Duplicate content between .claude/commands/opsx/ and .claude/skills/

The commands and skill files are near-identical in content. Maintaining two parallel copies of every workflow definition is a maintenance burden.

Recommendation: Either document the rationale for the duplication, or consolidate into one canonical source.


3. idle-base-builder uses localStorage for player identity (security concern)

File: .agent/specs/games/idle-base-builder-leaderboard-2-5d.md

The spec uses a UUID stored in localStorage as the actor key [playerId]. A client can trivially claim any playerId by setting localStorage, allowing access to any other player world actor. All other specs correctly use c.conn.id as canonical identity.

Recommendation: Either use c.conn.id as the actor key, or explicitly document the trade-off with a concrete mitigation (e.g., a matching secret token alongside the playerId) in the security checklist.


4. npc-town spec omits a concrete rate limit for move()

File: .agent/specs/games/npc-town-vercel-ai-sdk-2-5d.md

The move() action only says 'Tile-based with simple clamp and rate limit' without a specific rate. All other specs are explicit (e.g., '10-20Hz', '20Hz').

Recommendation: Add a concrete rate limit for move() for consistency and to prevent a future implementer from omitting it.


5. party-game spec does not handle judge disconnect mid-round

File: .agent/specs/games/party-game-cah-like-2d.md

If the judge disconnects while phase == 'judging', the game will deadlock with no path forward. The onDisconnect lifecycle only handles the empty-lobby case.

Recommendation: Add a note about judge disconnect handling (e.g., rotate judge, cancel round, or abort game).


6. Friction log surfaces an unresolved .agent/ vs .agents/ path ambiguity

File: .agent/friction/rivetkit.md

The log notes that repo guidance references .agents/notes/... while this task uses .agent/notes/.... Contributors need a clear canonical location.

Recommendation: Decide on a single canonical path and update any guidance that still references the other.


7. Known Node 24 crashes have no follow-up tracking

File: .agent/notes/games/game-examples-issues.md

Two crashes noted as still reproducing as of 2026-02-13 are buried in internal notes:

  • examples/game-idle-base: RuntimeError: memory access out of bounds from wa-sqlite under Node v24.13.0.
  • examples/game-mmo-chunks: Error: Failed to save actor state: BareError: (byte:0) too large buffer.

Recommendation: Open tracking issues for these crashes and consider pinning a Node version requirement in affected examples.


Minor Notes

  • .agent/specs/games/realtime-multiplayer-fps-3d.md: The entry projectileLog omitted (hitscan) appears as a state field comment. It would be cleaner to remove it from the state table and mention it only in the fire() action description.
  • .agent/notes/multiplayer-cookbook.md: The note 'Seeded from /home/nathan/misc/rork-skill-old.md' exposes a developer local filesystem path and is not useful to other contributors. It should be removed before merging.
  • .claude/commands/opsx/bulk-archive.md and .claude/skills/openspec-bulk-archive-change/SKILL.md are the largest files in this PR (242 and 246 additions respectively). These represent the highest maintenance burden given the duplication concern above.

Checklist

Category Status
No rivet.gg domain references Pass
Logging/tracing conventions (N/A, docs only) N/A
Error handling conventions (N/A, docs only) N/A
Timestamp naming conventions (N/A, docs only) N/A
Security considerations in game specs Concerns noted (items 3, 4, 5)
Content quality and consistency Good overall
PR title accuracy Mismatch (item 1)

@NathanFlurry NathanFlurry force-pushed the 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations branch from d5b839a to b2b8dc8 Compare February 23, 2026 08:25
@NathanFlurry NathanFlurry force-pushed the 02-22-docs_document_queue_with_interval_pattern branch from 94b5564 to 5a043e0 Compare February 23, 2026 08:25
@NathanFlurry NathanFlurry force-pushed the 02-22-docs_document_queue_with_interval_pattern branch from 5a043e0 to 4ae8dab Compare February 23, 2026 18:22
@NathanFlurry NathanFlurry force-pushed the 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations branch from b2b8dc8 to 017b2a7 Compare February 23, 2026 18:22
@NathanFlurry NathanFlurry force-pushed the 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations branch from 017b2a7 to b2b8dc8 Compare February 23, 2026 18:34
@NathanFlurry NathanFlurry force-pushed the 02-22-docs_document_queue_with_interval_pattern branch from 4ae8dab to 5a043e0 Compare February 23, 2026 18:34
@NathanFlurry NathanFlurry force-pushed the 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations branch from b2b8dc8 to 4472768 Compare February 23, 2026 18:35
@NathanFlurry NathanFlurry force-pushed the 02-22-docs_document_queue_with_interval_pattern branch from 5a043e0 to 193d01e Compare February 23, 2026 18:35
@NathanFlurry NathanFlurry force-pushed the 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations branch from 4472768 to bc22452 Compare February 24, 2026 02:39
@NathanFlurry NathanFlurry force-pushed the 02-22-docs_document_queue_with_interval_pattern branch from 193d01e to 26393b8 Compare February 24, 2026 02:40
@NathanFlurry NathanFlurry mentioned this pull request Feb 24, 2026
11 tasks
@NathanFlurry NathanFlurry force-pushed the 02-22-docs_document_queue_with_interval_pattern branch from 26393b8 to dd75c7e Compare February 24, 2026 02:57
@NathanFlurry NathanFlurry force-pushed the 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations branch from bc22452 to b383455 Compare February 24, 2026 02:57
@NathanFlurry NathanFlurry force-pushed the 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations branch from b383455 to 4472768 Compare February 24, 2026 03:19
@NathanFlurry NathanFlurry force-pushed the 02-22-docs_document_queue_with_interval_pattern branch from dd75c7e to 193d01e Compare February 24, 2026 03:19
@NathanFlurry NathanFlurry force-pushed the 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations branch from 4472768 to 994ed2a Compare February 24, 2026 04:01
@NathanFlurry NathanFlurry force-pushed the 02-22-docs_document_queue_with_interval_pattern branch from 193d01e to 59dff12 Compare February 24, 2026 04:01
@NathanFlurry NathanFlurry force-pushed the 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations branch from 994ed2a to 50a5e67 Compare February 24, 2026 04:08
Base automatically changed from 02-22-chore_rivetkit_migrate_to_sqlite_instance_per-actor_for_concurrency_optimizations to main February 24, 2026 04:08
@NathanFlurry NathanFlurry merged commit 1f4122d into main Feb 24, 2026
11 of 22 checks passed
@NathanFlurry NathanFlurry deleted the 02-22-docs_document_queue_with_interval_pattern branch February 24, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant