chore(rivetkit): update conns to be hibernatable#4260
Conversation
|
🚅 Deployed to the rivet-pr-4260 environment in rivet-frontend
|
PR Review: chore(rivetkit): update conns to be hibernatableThis PR fixes several interconnected issues with hibernatable WebSocket connections in the file system driver and the broader connection lifecycle. The changes are well-reasoned and address real bugs. Core Fix:
|
| Area | Assessment |
|---|---|
isHibernatable fix |
Correct and necessary |
| Message ordering chain | Solid fix, minor edge case in error path |
| Client message queuing | Correct fix |
| ID entropy (4 bytes) | Should be increased or documented |
| Cleanup timing | Correct but implicit, worth a comment |
| Test coverage | Good scenario coverage |
| Engine driver parity | Engine onBeforeActorStart correctly omits cleanup since it manages WS restoration itself |
The changes are a clear improvement. The 4-byte ID size is the main actionable concern.
ebbe0a2 to
240add0
Compare
57c3534 to
033c3b9
Compare
033c3b9 to
7d43770
Compare
240add0 to
88fcb5f
Compare
88fcb5f to
240add0
Compare
033c3b9 to
d8a30c7
Compare
d8a30c7 to
c2be680
Compare
070db06 to
3c2f302
Compare
c2be680 to
310b793
Compare
3c2f302 to
62a8778
Compare
310b793 to
d8a30c7
Compare
070db06 to
ada2163
Compare
d8a30c7 to
326942f
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: