fix: invalid changelog ping position#4298
fix: invalid changelog ping position#4298jog1t wants to merge 1 commit intofix_invalid_env_detectionfrom
Conversation
|
🚅 Deployed to the rivet-pr-4298 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: fix: invalid changelog ping positionSmall, focused fix. Here's my analysis: What the change does
IssuesMinor: Pre-existing typo Whats new?Should be Minor: Ping component has a hardcoded color bug (pre-existing) <span className={cn("relative inline-flex rounded-full size-2 bg-red-500", mainVariants[variant])} />The Tailwind merge will have Minor: Inconsistent Correctness of the positioning fixThe
This is the correct approach. The fix is sound. SummaryThe core change is correct and an improvement over the previous approach. The Tailwind config addition is necessary for correct production builds. No blocking issues — the minor items above are pre-existing and can be addressed in follow-up PRs. |

Description
This change repositions the ping indicator for the "What's new?" changelog link in the inspector sidebar. The ping notification is now positioned relative to the text content rather than floating separately, providing better visual association with the changelog link. Additionally, the Tailwind configuration is updated to include the apps directory in the content scanning path.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: