Skip to content

Comments

fix: invalid changelog ping position#4298

Open
jog1t wants to merge 1 commit intofix_invalid_env_detectionfrom
02-19-fix_invalid_changelog_ping_position_split
Open

fix: invalid changelog ping position#4298
jog1t wants to merge 1 commit intofix_invalid_env_detectionfrom
02-19-fix_invalid_changelog_ping_position_split

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Feb 24, 2026

Description

This change repositions the ping indicator for the "What's new?" changelog link in the inspector sidebar. The ping notification is now positioned relative to the text content rather than floating separately, providing better visual association with the changelog link. Additionally, the Tailwind configuration is updated to include the apps directory in the content scanning path.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Feb 24, 2026

🚅 Deployed to the rivet-pr-4298 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-inspector 😴 Sleeping (View Logs) Web Feb 24, 2026 at 7:35 pm
website 😴 Sleeping (View Logs) Web Feb 24, 2026 at 7:35 pm
frontend-cloud ❌ Build Failed (View Logs) Web Feb 24, 2026 at 7:27 pm
mcp-hub ✅ Success (View Logs) Web Feb 24, 2026 at 7:25 pm
ladle ❌ Build Failed (View Logs) Web Feb 24, 2026 at 7:25 pm

Copy link
Contributor Author

jog1t commented Feb 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t mentioned this pull request Feb 24, 2026
11 tasks
@jog1t jog1t marked this pull request as ready for review February 24, 2026 19:24
@claude
Copy link

claude bot commented Feb 24, 2026

PR Review: fix: invalid changelog ping position

Small, focused fix. Here's my analysis:

What the change does

layout.tsx: Moves the Ping component inside the <a> element's text, wrapped in a <span className="relative">. This gives the absolutely-positioned Ping a proper containing block, so the animation renders relative to the "Whats new?" label rather than floating independently. Previously the Ping was a sibling before the button with className="relative -right-1", which made the Ping span itself the positioned ancestor rather than a parent container for its inner absolute children.

tailwind.config.js: Adds ./apps/**/*.{ts,tsx} to the content scanning paths. This is needed so Tailwind purges correctly for the inspector app under frontend/apps/ — without this, classes used only in apps/ would be stripped in production builds.

Issues

Minor: Pre-existing typo

Whats new?

Should be What's new?. Not introduced by this PR but it's a low-cost fix to include while touching this line.

Minor: Ping component has a hardcoded color bug (pre-existing)
In frontend/packages/components/src/ping.tsx, the inner dot span uses bg-red-500 unconditionally instead of mainVariants[variant]:

<span className={cn("relative inline-flex rounded-full size-2 bg-red-500", mainVariants[variant])} />

The Tailwind merge will have mainVariants[variant] win due to specificity ordering, so in practice the dot renders with the correct variant color — but this is confusing and should be cleaned up separately.

Minor: Inconsistent rel attribute
The changelog link uses rel="noopener" while the Documentation and other links use rel="noopener noreferrer". Consider adding noreferrer for consistency and to prevent the Referer header from leaking (pre-existing).

Correctness of the positioning fix

The Ping component's base classes are flex size-2 absolute top-0 -right-3. Wrapping the text in <span className="relative"> and passing className="-right-4" to Ping gives:

  • A proper relative ancestor for the absolute pin
  • The -right-4 override shifts the dot slightly further right than the default -right-3, placing it just past the end of the text

This is the correct approach. The fix is sound.

Summary

The core change is correct and an improvement over the previous approach. The Tailwind config addition is necessary for correct production builds. No blocking issues — the minor items above are pre-existing and can be addressed in follow-up PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant