Skip to content

Comments

fix: disable selection on drag#4300

Open
jog1t wants to merge 1 commit into02-24-fix_pkg_pr_new_configfrom
02-24-fix_disable_selection_on_drag
Open

fix: disable selection on drag#4300
jog1t wants to merge 1 commit into02-24-fix_pkg_pr_new_configfrom
02-24-fix_disable_selection_on_drag

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Feb 24, 2026

Description

This change removes the selectionOnDrag property from the ReactFlow component in the workflow visualizer and reorganizes import statements to follow a consistent ordering pattern. The removal of selectionOnDrag disables the ability to select nodes by dragging, which may improve the user experience by preventing accidental selections during pan operations.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor Author

jog1t commented Feb 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t marked this pull request as ready for review February 24, 2026 19:52
@jog1t jog1t mentioned this pull request Feb 24, 2026
11 tasks
@railway-app
Copy link

railway-app bot commented Feb 24, 2026

🚅 Deployed to the rivet-pr-4300 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 24, 2026 at 8:06 pm
frontend-inspector 😴 Sleeping (View Logs) Web Feb 24, 2026 at 8:04 pm
frontend-cloud ❌ Build Failed (View Logs) Web Feb 24, 2026 at 7:55 pm
mcp-hub ✅ Success (View Logs) Web Feb 24, 2026 at 7:52 pm
ladle ❌ Build Failed (View Logs) Web Feb 24, 2026 at 7:52 pm

@claude
Copy link

claude bot commented Feb 24, 2026

PR Review

This is a small, focused change to frontend/src/components/actors/workflow/workflow-visualizer.tsx.

Summary of Changes

  1. Removes the selectionOnDrag prop from <ReactFlow>
  2. Reorganizes import statements into a consistent ordering pattern
  3. Reformats two long prop expressions to multi-line for readability

selectionOnDrag Removal

The core change is valid. With panOnDrag={[1, 2]} restricting pan to middle/right mouse buttons, selectionOnDrag was enabling left-click drag for multi-node selection. In a read-only workflow visualizer, this selection behavior adds no user value and likely caused accidental activations. Removing it is a clean improvement.

One question worth considering: should panOnDrag be updated to include left-click drag (button 0) now that selectionOnDrag is removed? Currently, left-click dragging does nothing. Allowing left-click to pan (panOnDrag={[0, 1, 2]}) may be more intuitive for users unfamiliar with middle/right-click panning. This is a minor UX consideration rather than a blocker.

Import Reorganization

The alphabetical ordering is consistent and readable. However, this reorganization mixes concerns — it conflates a behavioral fix with a style cleanup, making the diff slightly harder to parse at a glance. For future PRs, keeping style changes separate from behavioral changes helps with bisecting and code review. Not a blocker here given the small size.

Formatting Changes

The multi-line reformatting of the two type and value props is a minor improvement for readability on long lines. No issues here.

Concerns

  • Test coverage: The checklist notes no tests were added. For UI behavior changes like this, a manual verification note in the PR description (e.g., "tested by panning and verifying no accidental node selections") would help reviewers gain confidence.
  • PR target branch: This PR targets 02-24-fix_pkg_pr_new_config rather than main. Confirm this is intentional and the change will be merged transitively into main.

Verdict

The behavioral change is correct and the implementation is clean. The concerns above are minor and don't block merging.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 24, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4300

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4300

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4300

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4300

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4300

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4300

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4300

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4300

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4300

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4300

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4300

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4300

commit: c25da1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant