Skip to content

Comments

feat: allow ips in runner configs#4304

Open
jog1t wants to merge 1 commit into02-24-fix_workflow_statusesfrom
02-24-feat_allow_ips_in_runner_configs
Open

feat: allow ips in runner configs#4304
jog1t wants to merge 1 commit into02-24-fix_workflow_statusesfrom
02-24-feat_allow_ips_in_runner_configs

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Feb 24, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor Author

jog1t commented Feb 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t marked this pull request as ready for review February 24, 2026 20:45
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 24, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4304

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4304

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4304

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4304

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4304

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4304

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4304

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4304

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4304

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4304

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4304

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4304

commit: 94dbeac

@claude
Copy link

claude bot commented Feb 24, 2026

PR Review: Allow IPs in Runner Configs

This is a clean, focused change. The overall approach is sound. A few notes:

IPv4 Octet Range Validation

The current regex accepts out-of-range octets like 999.0.0.1. Per the WHATWG URL spec, when a URL like http://999.0.0.1/ is parsed, the hostname 999.0.0.1 is treated as an opaque hostname (not IPv4) because 999 > 255 — so it passes through to isValidHost and the regex accepts it. The connection itself would fail, but the form would not surface an error to the user.

Consider tightening the regex:

const IPV4_REGEX = /^((25[0-5]|2[0-4]\d|[01]?\d\d?)\.){3}(25[0-5]|2[0-4]\d|[01]?\d\d?)$/;

IPv6 Validation

The IPv6 regex is fine here. The new URL() call already performs strict WHATWG IPv6 validation before isValidHost is reached, so by the time you test url.hostname, it has already been validated structurally.

Minor: Redundant localhost Check

localhost already passes z4.regexes.domain since it is a valid single-label domain, so the explicit check is not strictly necessary. That said, having it explicitly listed makes the intent clear at a glance, so this is just a note rather than a blocker.

Summary

The change correctly handles the main cases (IPv4, IPv6 brackets, localhost). The IPv4 octet range issue is worth fixing to avoid silently accepting invalid addresses in the form.

@jog1t jog1t mentioned this pull request Feb 24, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant