feat: allow ips in runner configs#4304
feat: allow ips in runner configs#4304jog1t wants to merge 1 commit into02-24-fix_workflow_statusesfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: Allow IPs in Runner ConfigsThis is a clean, focused change. The overall approach is sound. A few notes: IPv4 Octet Range ValidationThe current regex accepts out-of-range octets like Consider tightening the regex: const IPV4_REGEX = /^((25[0-5]|2[0-4]\d|[01]?\d\d?)\.){3}(25[0-5]|2[0-4]\d|[01]?\d\d?)$/;IPv6 ValidationThe IPv6 regex is fine here. The Minor: Redundant
|

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: