feat(pb): actors v3#4463
feat(pb): actors v3#4463MasterPtato wants to merge 1 commit into03-19-feat_cache_add_in_flight_dedupingfrom
Conversation
|
🚅 Deployed to the rivet-pr-4463 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: feat(pb): actors v3
Critical Issues1. Struct name mismatch (compile error) 2. Syntax errors in actor2 workflow (compile errors) 3. Package name mismatch Dependency Issues4. Pinned hyper version outside workspace |
Design / Logic Issues5. Double-counted eviction metrics 6. Silent JSON deserialization errors in conn.rs 7. Wrong field mapping in Mk1 KV metadata 8. Unverified abort safety in demuxer GC |
Code Quality9. Significant KV code duplication 10. Unimplemented module 11. TODOs indicating known gaps Minor / Style12. Workflow rename is a breaking change |
SummaryThis is a substantial feature adding an envoy abstraction layer between runners and the engine, plus a v2 gateway and the foundations of an actors v3 workflow. The overall architecture looks solid. The eviction, hibernation, and ping/keepalive mechanics are well-designed with good attention to race conditions (subscribe before publish for eviction, structured lifecycle abort pattern, etc.). Before marking ready for review, the compile errors (items 1-3) must be fixed. Items 5, 7, and 8 are the highest-priority logic issues. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: