fix(envoy): use global instance, add signal handlers#4565
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
🚅 Deployed to the rivet-pr-4565 environment in rivet-frontend
|
PR Review: fix(envoy): use global instance, add signal handlersThe refactor to a global singleton is the right approach, preventing multiple EngineActorDriver instances from each spawning their own envoy WebSocket connection. However, there are several issues worth addressing before merge. Critical1. Compilation break in test-envoy
2. GLOBAL_ENVOY never cleared after shutdown
Medium3. Signal handlers registered even for notGlobal: true envoysWhen 4. SSE abort handler silently became a no-op
Minor5. Dead config field serverlessStartPayload
6. ShutdownReason type has a dead variant
7. immediate parameter in shutdown() is ignoredThe signal handler calls Positive Changes
|
de70131 to
4639183
Compare
6c9af76 to
94f54ba
Compare
4639183 to
fdd0c18
Compare
94f54ba to
ef85f3e
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: