fix: remove serverless token#4572
fix: remove serverless token#4572MasterPtato wants to merge 1 commit into04-06-fix_misc_token_fixesfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: fix: remove serverless tokenSummaryThis PR removes token passing logic from the serverless outbound request path across two files. The change is a net simplification (+2/-28), but raises a few questions worth discussing. engine/packages/pegboard-outbound/src/lib.rsChanges: Removes the The removal is clean with no dangling references. If the token is no longer required for authenticating serverless outbound requests (e.g., because the auth model changed), this is a clear improvement. Question: Is authentication for serverless outbound requests now handled at a different layer, or is the token simply no longer required? If it's the latter, a brief comment or PR description note would help future readers understand why this header was removed. engine/sdks/typescript/envoy-client/src/tasks/envoy/index.tsThis is the more notable change. The removed code had an explicit comment explaining its purpose:
Concern: If serverless envoys still persist beyond the The removal of Minor Notes
Overall this looks like a reasonable cleanup, but the token refresh removal in the TypeScript file deserves explicit confirmation that the expiry case is handled or no longer applicable. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: