Skip to content

chore: remove non-engine drivers#4574

Open
NathanFlurry wants to merge 1 commit into03-08-feat_rivetkit_dynamic_actorsfrom
04-06-chore_remove_non-engine_drivers
Open

chore: remove non-engine drivers#4574
NathanFlurry wants to merge 1 commit into03-08-feat_rivetkit_dynamic_actorsfrom
04-06-chore_remove_non-engine_drivers

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 7, 2026

@claude
Copy link
Copy Markdown

claude bot commented Apr 7, 2026

PR Review: chore: remove non-engine drivers

Summary: This PR removes three Cloudflare Workers examples and updates related documentation/guidance to reflect the shift to engine-only testing. Net result: +832 / -38,373 lines — a healthy cleanup.


Positives

  • Large reduction in maintenance surface: removing ~38K lines of Cloudflare Workers-specific code is a clear win
  • Repository URL fix in engine/sdks/typescript/api-full/package.json: corrects the deprecated rivet-gg/rivet URL to rivet-dev/rivet and updates the directory path — required per CLAUDE.md
  • Comment fix in examples/actor-actions/vite.config.ts: "manager API" to "actor API" is a minor but correct cleanup
  • README consistency: The Cloudflare Workers quickstart doc was already absent from the repo tree, so removing the README link prevents a dead external link

Concerns

1. Empty PR description

The PR template checklist is blank with no explanation of the motivation (e.g. consolidating on engine-only drivers, removing unmaintained runtimes). A one-paragraph summary would help future readers understand why this code was removed.

2. Vague path references in updated documentation

DYNAMIC_ACTORS_ARCHITECTURE.md now reads: "dedicated static and dynamic registry fixtures in test coverage" — no file path. The old text was explicit about registry-static.ts / registry-dynamic.ts. Consider pointing to concrete paths or the new canonical location in examples/sandbox/.

DYNAMIC_ACTOR_SQLITE_PRO#Y_SPEC.md now reads: "shared sandbox-style test fixtures" — no path. The old text named fixtures/driver-test-suite/. If the new home is examples/sandbox/, say so.

These spec documents guide future implementers; vague references defeat their purpose.

3. DYNAMIC_ACTOR_FAILED_START_RELOAD_SPEC.md path rename

The diff changes remote-manager-driver/metadata.ts to engine-client/metadata.ts. This looks correct if the package was renamed, but if the path does not exist yet or the rename is in a separate PR, the spec will be misleading until that lands. Worth noting in the PR description.

4. CLAUDE.md "RivetKit Test Fixtures" guidance is thin

The new text says to keep fixtures scoped to the engine-only runtime and prefer tests under rivetkit-typescript/packages/rivetkit/tests/. Losing the explicit guidance about registry-static.ts/registry-dynamic.ts/actors/ may leave contributors without enough detail. Consider adding one sentence naming the canonical fixture directory (e.g. examples/sandbox/src/actors/).


Minor nit

README.md adds a trailing newline on the [Apache 2.0](LICENSE) line. Cosmetic fix, no issue.


Verdict

The removals are clean and the direction is sound. The main asks are:

  1. Fill out the PR description with a brief rationale.
  2. Make the internal spec documents point to concrete paths rather than prose descriptions.

@MasterPtato MasterPtato force-pushed the 03-08-feat_rivetkit_dynamic_actors branch from ee1bb10 to db7311c Compare April 8, 2026 20:30
@MasterPtato MasterPtato force-pushed the 04-06-chore_remove_non-engine_drivers branch from 3720030 to 28719f8 Compare April 8, 2026 20:30
Copy link
Copy Markdown
Contributor

Merge activity

  • Apr 8, 8:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants