chore: remove non-engine drivers#4574
chore: remove non-engine drivers#4574NathanFlurry wants to merge 1 commit into03-08-feat_rivetkit_dynamic_actorsfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: chore: remove non-engine driversSummary: This PR removes three Cloudflare Workers examples and updates related documentation/guidance to reflect the shift to engine-only testing. Net result: +832 / -38,373 lines — a healthy cleanup. Positives
Concerns1. Empty PR description The PR template checklist is blank with no explanation of the motivation (e.g. consolidating on engine-only drivers, removing unmaintained runtimes). A one-paragraph summary would help future readers understand why this code was removed. 2. Vague path references in updated documentation
These spec documents guide future implementers; vague references defeat their purpose. 3. The diff changes 4. CLAUDE.md "RivetKit Test Fixtures" guidance is thin The new text says to keep fixtures scoped to the engine-only runtime and prefer tests under Minor nit
VerdictThe removals are clean and the direction is sound. The main asks are:
|
83289a0 to
3720030
Compare
ee1bb10 to
db7311c
Compare
3720030 to
28719f8
Compare
Merge activity
|

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: