feat(rivetkit): expose c.keepAwake(promise) through native path#4748
feat(rivetkit): expose c.keepAwake(promise) through native path#4748NathanFlurry wants to merge 1 commit intosleep-cleanup/06-ts-deprecate-prevent-sleepfrom
Conversation
PR Review: feat(rivetkit): expose c.keepAwake(promise) through native pathOverviewThis PR routes the native-path Issues1. Silent error swallowing (significant)The old code explicitly caught and only swallowed If the wrapped JS promise rejects, the NAPI Suggested fix - add a void callNative(() =>
this.#ctx.keepAwake(promise.then(() => null)),
).catch((error) => {
if (!isClosedTaskRegistrationError(error)) {
logger().warn('keep_awake bridge error', { error });
}
});Alternatively, restructure the NAPI method to match the 2. Unnecessary
|
6966cdb to
8650b44
Compare
571bece to
ef299f2
Compare
31f3a57 to
dfa956c
Compare
ef299f2 to
b27b338
Compare
dfa956c to
181bb0f
Compare
b27b338 to
0454dc5
Compare
Preview packages published to npmInstall with: npm install rivetkit@pr-4748All packages published as Engine binary is shipped via Docker images: docker pull rivetdev/engine:slim-d1a6ff3
docker pull rivetdev/engine:full-d1a6ff3Individual packagesnpm install rivetkit@pr-4748
npm install @rivetkit/react@pr-4748
npm install @rivetkit/rivetkit-napi@pr-4748
npm install @rivetkit/workflow-engine@pr-4748 |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: