Skip to content

test(rivetkit): remove sleepWithPreventSleep fixture and tests#4756

Draft
NathanFlurry wants to merge 1 commit intosleep-cleanup/10-alarm-overdue-during-sleep-testfrom
sleep-cleanup/11-remove-prevent-sleep-fixture
Draft

test(rivetkit): remove sleepWithPreventSleep fixture and tests#4756
NathanFlurry wants to merge 1 commit intosleep-cleanup/10-alarm-overdue-during-sleep-testfrom
sleep-cleanup/11-remove-prevent-sleep-fixture

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude Bot commented Apr 24, 2026

PR Review: test(rivetkit): remove sleepWithPreventSleep fixture and tests

Summary: Pure deletion PR (163 deletions, 0 additions) removing the sleepWithPreventSleep fixture and associated driver tests, in coordination with parent PR #4741 which deprecated set_prevent_sleep to a no-op in the Rust core.


Code Quality

The cleanup is complete and internally consistent:

  • Fixture file actors/sleepWithPreventSleep.ts (re-export shim) is deleted
  • registry-static.ts import and registration entries are removed together
  • sleep.ts fixture actor definition and PREVENT_SLEEP_TIMEOUT constant removed
  • All 3 related tests in actor-sleep.test.ts removed

No dangling references to sleepWithPreventSleep or PREVENT_SLEEP_TIMEOUT remain in the TypeScript package.

Rationale Alignment

Well-grounded. With set_prevent_sleep and prevent_sleep marked as deprecated no-ops in the Rust core, running driver tests against that path would yield misleading passing results. Removing the tests is the correct response.

Potential Gap to Track

The TypeScript-native path in rivetkit-typescript/packages/rivetkit/src/actor/instance/mod.ts still contains an active setPreventSleep implementation managing #preventSleep, #preventSleepClearedPromise, and the can_sleep check. Production code (e.g., agent-os) still calls c.setPreventSleep(true/false). This PR removes driver-test coverage for the NAPI/Rust path, but the TS-native path behavior has no replacement coverage.

Suggestion: Track whether separate tests for the TS-native setPreventSleep behavior are needed, given active agent-os production usage.

No Issues Found

No bugs, security concerns, style violations, or incomplete deletions. The change is correct and complete for its stated purpose.


Reviewed by claude[bot]

@NathanFlurry NathanFlurry force-pushed the sleep-cleanup/10-alarm-overdue-during-sleep-test branch from 50500b5 to d151463 Compare April 24, 2026 13:16
@NathanFlurry NathanFlurry force-pushed the sleep-cleanup/11-remove-prevent-sleep-fixture branch from c7f9133 to ace5f49 Compare April 24, 2026 13:16
@github-actions
Copy link
Copy Markdown
Contributor

Preview packages published to npm

Install with:

npm install rivetkit@pr-4756

All packages published as 0.0.0-pr.4756.89f55a3 with tag pr-4756.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-89f55a3
docker pull rivetdev/engine:full-89f55a3
Individual packages
npm install rivetkit@pr-4756
npm install @rivetkit/react@pr-4756
npm install @rivetkit/rivetkit-napi@pr-4756
npm install @rivetkit/workflow-engine@pr-4756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant