refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• test(rivetkit-core): cover sleep/destroy guards and prevent_sleep no-op #4750
• docs: add keepAwake vs waitUntil table and internal sleep-sequence invariants #4749
• feat(rivetkit): expose c.keepAwake(promise) through native path #4748
• refactor(rivetkit): deprecate setPreventSleep to no-op in TypeScript #4747
• fix(rivetkit-core): enumerate non-drained counters in grace deadline warn log #4746
• fix(rivetkit-core): abort graceful cleanup task when grace deadline elapses #4745
• fix(rivetkit-core): error on sleep/destroy before startup or already-requested #4743
• fix(rivetkit-core): cap SerializeState shutdown timeout at 15s #4742
• refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op #4741 👈 (View in Graphite)
• chore: sql fuzz #4739 : 1 other dependent PR (#4740 )
• fix(rivetkit-core): gate startup until runtime is ready #4736 : 1 other dependent PR (#4737 )
• fix(rivetkit-sqlite): preserve text with embedded nul bytes #4735
• chore(rivetkit): add child spans for logging #4734
• fix(rivetkit-core): orphan engine process and detect crashes #4733
• fix(rivetkit-core): return None for empty inspector state to avoid frontend CBOR decode error #4732
• fix(rivetkit-core): don't install tokio::signal::ctrl_c() handler inside serve_with_config #4731
• refactor(rivetkit-core): use subtle::ConstantTimeEq for inspector token verify #4730
• fix(rivetkit): drop is_read_only_sql classifier, surface RETURNING rows #4728
• docs: require close-code rejection for websocket auth/policy failures #4727
• fix(rivetkit): inspector reports actual config state + real queue messages #4726
• fix(rivetkit-napi): plumb ctx through serializeState TSF and stop panicking on runtime_state Ref drop #4725
• chore(rivetkit): remove legacy metrics & prometheus auth #4724
• chore(rivetkit): remove legacy metrics #4723
• chore(rivetkit): impl inspector token #4722
• chore: disable auth on serverless #4721
• chore: fix cors for envoys #4720
• chore: fix serverless in rivetkit-core #4719
• chore(rivetkit): impl follow up review #4711
• chore: rivetkit core/napi/typescript follow up review #4702
• chore: fix remaining issues with rivetkit-core #4701
• chore: sqlite v1 to v2 data migration #4692 : 1 other dependent PR (#4640 )
• chore: move rivetkit to task model #4680
• chore: rivetkit to rust #4679
• feat(rivetkit): sqlite vfs v2 #4673
• chore: rename sandbox -> kitchen sink #4671 : 1 other dependent PR (#4672 )
• chore: configure TLS trust roots for rustls clients #4667
• fix(rivetkit): update config to match envoys & remove manager references #4663
• chore(publish): pin docker base image refs #4652
• chore(engine): publish engine bases in ci #4649 : 2 other dependent PRs (#4650 , #4666 )
• chore: lockfile lefthook #4647
• fix(rivetkit): surface native sqlite kv errors to callers #4645
• fix(rivetkit): prevent sleep races during disconnect and db work #4644
• fix(rivetkit): isolate engine envoys and propagate startup failures #4643
• test(rivetkit): remove wasm sqlite-only fixtures and coverage #4642
• chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring #4641
• chore(rivetkit): remove wasm sqlite runtime #4614
• fix(sqlite-native): restore native startup kv preload #4639
• fix(sqlite-native): delete metadata before chunk range #4638
• fix(sqlite-native): keep truncate cache coherent #4637
• fix(sqlite-vfs): use delete range for truncate cleanup #4636
• fix(sqlite-native): restore kv error hook #4635
• perf(sqlite-native): avoid cloning cached read chunks #4634
• perf(sqlite-native): gate kv operation labels #4633
• perf(sqlite-native): reuse read cache for partial writes #4632
• perf(sqlite-native): remove delete file existence probe #4631
• fix(sqlite-native): gate native read cache behind env var #4630
• fix(pegboard): isolate runner config dc lookup failures #4625 : 1 other dependent PR (#4626 )
• docs(pegboard): note runner config upsert split write risk #4624
• fix(pegboard): unpack global runner config keys correctly #4623
• fix(pegboard-gateway): enforce tunnel message state #4622
• fix(pegboard-runner): clear terminal tunnel routes #4621
• fix(pegboard): skip protocol version keys in runner pool backfill #4620
• fix(pegboard): create missing normal runner configs #4619
• fix(epoxy): reuse cached optimistic value #4618
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR #4741 Review: refactor(rivetkit-core): remove prevent_sleep field and deprecate set_prevent_sleep to no-op

Overview

This PR removes the prevent_sleep field from rivetkit-core's ActorContextInner and converts set_prevent_sleep / prevent_sleep into deprecated no-ops, while retaining the NAPI surface for bridge compatibility. The intent is to replace the old pull-style flag with keep_awake (RAII guard) and wait_until (future-scoped hold).

---

Critical: AgentOS regression

The agentOS layer (agent-os/actor/index.ts, process.ts, shell.ts, session.ts) still calls syncPreventSleep(c) → c.setPreventSleep(shouldPrevent) to hold the actor awake while a subprocess or shell session is running. After this change, those calls go through the NAPI bridge into a no-op. AgentOS actors running on the native (NAPI) path can now sleep prematurely while a process is still alive. This is a behavioral regression that needs to be fixed before or alongside this change.

Tests will pass vacuously or fail

actor-sleep.test.ts lines 596–691 test three concrete scenarios: that preventSleep blocks auto-sleep until cleared, delays shutdown, and can be restored on wake. All three rely on setPreventSleep actually preventing sleep. Against the NAPI driver these tests now exercise a no-op and either:

• pass vacuously (the actor was already sleeping for another reason), or
• fail because the expected sleep-blocking behavior is gone.

These tests should be removed, skipped for the native driver, or replaced with equivalent keep_awake / wait_until tests before this ships.

TypeScript pure path and NAPI path now diverge

The pure-TypeScript actor instance (actor/instance/mod.ts) retains the full preventSleep state machine — #preventSleep, #waitForPreventSleepClear, CanSleep.PreventSleep, etc. The NAPI path converts those calls to no-ops. Callers currently cannot tell which runtime they're on, so the same actor code exhibits different sleep behavior depending on the driver. The PR should either:

• stub out the TS side too (marking it deprecated and always returning false), or
• document the intentional split and note that the TS path will be updated in a follow-up.

Minor: #[allow(deprecated)] without an explanatory comment

The #[allow(deprecated)] suppression in rivetkit-napi/src/actor_context.rs is correct, but a one-line comment explaining why ("NAPI bridge retains this surface for TS callers still using setPreventSleep") would make the intent clearer to future readers.

Positive notes

• The removal of prevent_sleep_notify and the PreventSleep variant from CanSleep is clean; no dead branches left.
• Propagating #[deprecated] through both rivetkit-core and the thin rivetkit (Rust) wrapper with #[allow(deprecated)] in the forwarders is the correct pattern.
• Keeping the NAPI surface as a no-op rather than removing it avoids a hard break in downstream TS code that may still call setPreventSleep.

Summary

The core cleanup is well-motivated, but the PR has a behavioral regression in agentOS and leaves tests that now exercise a no-op. The asymmetry between the TS-pure and NAPI paths also needs to be called out explicitly (in the PR description at minimum). Recommend resolving the agentOS syncPreventSleep calls and the affected test suite before marking ready for review.