feat: add service tokens #636
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
NathanFlurry
force-pushed
the
04-05-feat_add_service_tokens
branch
from
ca65811 to
2b0f7e4
Compare
MasterPtato
requested changes
Apr 5, 2024
NathanFlurry
force-pushed
the
04-05-feat_add_service_tokens
branch
from
2b0f7e4 to
8da0d66
Compare
NathanFlurry
changed the base branch from
main
to
04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt
This was referenced Apr 11, 2024
NathanFlurry
force-pushed
the
04-05-feat_add_service_tokens
branch
2 times, most recently
from
a0b8538 to
89c1666
Compare
NathanFlurry
force-pushed
the
04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt
branch
from
1fdc448 to
e66ae58
Compare
NathanFlurry
force-pushed
the
04-05-feat_add_service_tokens
branch
from
89c1666 to
e185ca9
Compare
NathanFlurry
force-pushed
the
04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt
branch
from
e66ae58 to
0253f00
Compare
NathanFlurry
changed the base branch from
04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt
to
04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container
NathanFlurry
force-pushed
the
04-05-feat_add_service_tokens
branch
from
e185ca9 to
5d8b4ce
Compare
NathanFlurry
force-pushed
the
04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container
branch
from
3c57734 to
e768e8f
Compare
NathanFlurry
force-pushed
the
04-05-feat_add_service_tokens
branch
from
5d8b4ce to
214bf51
Compare
NathanFlurry
force-pushed
the
04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container
branch
from
e768e8f to
03f6476
Compare
NathanFlurry
force-pushed
the
04-05-feat_add_service_tokens
branch
from
214bf51 to
c1bce3d
Compare
This was referenced Apr 12, 2024
AngelOnFira
suggested changes
Apr 15, 2024
There was a problem hiding this comment.
I wrote my own docs for this in the script file parallel to this being written:
# To install fern, first clone the repo and check out the branch
# $ git clone https://github.com/rivet-gg/fern
# $ cd fern
# $ git checkout max/remove-headers
#
# Then, follow the instructions in SETUP.md and CONTRIBUTING.md to compile fern
# $ yarn
# $ yarn compile
# $ yarn dist:cli:dev
#
# Finally, run this with the path to the fern repo, say:
# $ FERN_REPO_PATH=~/fern ./oss/scripts/fern/gen.shI think we can remove mine, it makes more sense to go here. I'm going to make some other requests for things that could be a bit better in the writeup based on mine.
| ## Step 1: Cloud & build Fern | ||
|
|
||
| ```sh | ||
| gh repo clone rivet-gg/fern |
There was a problem hiding this comment.
Can we instead use git here? I think people will be less familiar with gh, and potentially not know what the command would do.
Suggested change
| gh repo clone rivet-gg/fern | |
| git clone https://github.com/rivet-gg/fern |
Comment on lines
+8
to
+10
| yarn install | ||
| yarn husky install | ||
| yarn dist:cli:dev |
There was a problem hiding this comment.
I have yarn compile right before yarn dist:cli:dev, is it needed?
| ## Step 1: Cloud & build Fern | ||
|
|
||
| ```sh | ||
| gh repo clone rivet-gg/fern |
There was a problem hiding this comment.
In my version, I said to check out max/remove-headers. Is that now included in trunk?
MasterPtato
approved these changes
Apr 15, 2024
NathanFlurry
force-pushed
the
04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container
branch
from
03f6476 to
eb1a6cf
Compare
NathanFlurry
changed the base branch from
04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container
to
main
NathanFlurry
force-pushed
the
04-05-feat_add_service_tokens
branch
from
c1bce3d to
cbca7d6
Compare
|
Closing in favor of OpenGB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RVT-3700
Fixes RVT-3702