Skip to content

chore(dev): respect CARGO_TARGET_DIR in bolt & use non-mounted target in dev container #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2024
Merged

chore(dev): respect CARGO_TARGET_DIR in bolt & use non-mounted target in dev container #675

merged 1 commit into from
Apr 15, 2024

Conversation

@NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented Apr 12, 2024

Changes

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 12, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

This was referenced Apr 12, 2024
Merged
Closed
Merged
Merged
Merged
Merged
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Apr 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

@NathanFlurry NathanFlurry mentioned this pull request Apr 12, 2024
Merged
@NathanFlurry NathanFlurry force-pushed the 04-05-feat_add_service_tokens branch from 89c1666 to e185ca9 Compare April 12, 2024 06:04
@NathanFlurry NathanFlurry force-pushed the 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container branch 2 times, most recently from 1d8d321 to 3c57734 Compare April 12, 2024 06:09
@NathanFlurry NathanFlurry changed the base branch from 04-05-feat_add_service_tokens to 04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt April 12, 2024 06:09
@NathanFlurry NathanFlurry force-pushed the 04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt branch from 0253f00 to 1305174 Compare April 12, 2024 06:44
@NathanFlurry NathanFlurry force-pushed the 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container branch from 3c57734 to e768e8f Compare April 12, 2024 06:44
@NathanFlurry NathanFlurry mentioned this pull request Apr 12, 2024
Closed
@NathanFlurry NathanFlurry force-pushed the 04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt branch 2 times, most recently from 1e41b41 to 8e16a94 Compare April 12, 2024 06:58
@NathanFlurry NathanFlurry changed the base branch from 04-11-feat_nix_skip_building_bolt_in_nix_with_nix_skip_bolt to main April 12, 2024 07:25
@NathanFlurry NathanFlurry force-pushed the 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container branch from e768e8f to 03f6476 Compare April 12, 2024 21:21
This was referenced Apr 12, 2024
Merged
Closed
Closed
Merged
AngelOnFira
AngelOnFira approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@AngelOnFira AngelOnFira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to try with this config. I'm still weirded out about why it works fine for me on apple silicon but runs into issues for you. I'll also check if this runs into anything odd on linux.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 15, 2024 •
edited
Loading

Merge activity

@NathanFlurry
chore(dev): respect CARGO_TARGET_DIR in bolt & use non-mounted target…
eb1a6cf 
… in dev container (#675)

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container branch from 03f6476 to eb1a6cf Compare April 15, 2024 21:18
@graphite-app graphite-app bot merged commit eb1a6cf into main Apr 15, 2024
@graphite-app graphite-app bot deleted the 04-11-chore_dev_respect_cargo_target_dir_in_bolt_use_non-mounted_target_in_dev_container branch April 15, 2024 21:23
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

+1 more reviewer

@AngelOnFira AngelOnFira AngelOnFira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NathanFlurry @AngelOnFira @MasterPtato