Regenerate from the v1-only proto set - #35
Merged
Merged
Conversation
Bump proto/api to roadrunner-server/api@25217e9. The v2 packages and the informer/metrics/resetter/tcp packages are gone; lock/v1 messages are Request/Response again. Generated output is otherwise byte-identical.
There was a problem hiding this comment.
Pull request overview
Updates generated Go protobuf artifacts to match the v1-only proto set from proto/api (roadrunner-server/api@25217e9), removing v2 protos and several plugin proto packages, and reverting lock/v1 message names back to Request/Response.
Changes:
- Removes generated
*/v2protobuf packages (e.g.,http/v2,jobs/v2,kv/v2,service/v2,status/v2,websockets/v2,applogger/v2). - Removes generated protobuf packages for
informer,metrics,resetter, andtcp. - Renames
lock/v1message types fromLockRequest/LockResponsetoRequest/Response.
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| websockets/v2/websockets.pb.go | Removes generated v2 websockets protobuf definitions. |
| websockets/v2/response.pb.go | Removes generated v2 websockets response message. |
| websockets/v2/request.pb.go | Removes generated v2 websockets request message. |
| tcp/v1/service.pb.go | Removes generated TCP v1 service messages. |
| status/v2/response.pb.go | Removes generated v2 status response message. |
| status/v2/request.pb.go | Removes generated v2 status request message. |
| service/v2/service.pb.go | Removes generated v2 service message definitions. |
| service/v2/response.pb.go | Removes generated v2 service response/list/status messages. |
| service/v2/request.pb.go | Removes generated v2 service request messages. |
| resetter/v1/service.pb.go | Removes generated resetter v1 service messages. |
| metrics/v1/service.pb.go | Removes generated metrics v1 service/messages/enums. |
| lock/v1/lock.pb.go | Renames lock v1 messages to Request/Response in generated output. |
| kv/v2/response.pb.go | Removes generated v2 KV response message. |
| kv/v2/request.pb.go | Removes generated v2 KV request message. |
| kv/v2/kv.pb.go | Removes generated v2 KV item/message definitions. |
| jobs/v2/response.pb.go | Removes generated v2 jobs handler response message. |
| jobs/v2/request.pb.go | Removes generated v2 jobs request messages. |
| jobs/v2/jobs.pb.go | Removes generated v2 jobs core message definitions. |
| informer/v1/service.pb.go | Removes generated informer v1 service/messages. |
| http/v2/response.pb.go | Removes generated v2 HTTP handler response message. |
| http/v2/request.pb.go | Removes generated v2 HTTP handler request/fetch/batch messages. |
| http/v2/http.pb.go | Removes generated v2 HTTP header messages. |
| applogger/v2/service.pb.go | Removes generated v2 applogger service message. |
| applogger/v2/applogger.pb.go | Removes generated v2 applogger messages. |
Files not reviewed (1)
- lock/v1/lock.pb.go: Generated file
Suppressed comments (1)
lock/v1/lock.pb.go:28
- Renaming exported proto messages from
LockRequest/LockResponseto the very genericRequest/Responseis a breaking change for Go consumers (compile-time) while the module major version remains.../v6. If this rename is intended, consider adding backwards-compatible type aliases in a separate non-generated file in this package (and deprecating them) or bumping the module major version when releasing this change.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
proto/apito roadrunner-server/api@25217e9 (v2 protos removed) and regenerates. Removes the*/v2packages andinformer/metrics/resetter/tcp;lock/v1messages areRequest/Responseagain. All other generated files are byte-identical;go.modunchanged.