Use http/v1 payload protos again - #276
Open
rustatian wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Reverts the worker HTTP payload wire format back to the http/v1 protobuf messages (Request/Response/HeaderValue with bytes header values) to match the released Spiral / RoadRunner HTTP packages and the roadrunner-api-dto v1.14.1 contract.
Changes:
- Switch handler request/response marshaling/unmarshaling from
api-go/http/v2protos toapi-go/http/v1protos, including header value handling asbytes. - Update module dependencies to
github.com/roadrunner-server/api-go/v6 v6.0.0-beta.14. - Temporarily pin some test-module dependencies to sibling revert branches via pseudo-versions.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/go.sum | Updates checksums for the bumped/pinned test dependencies (including pseudo-versions). |
| tests/go.mod | Pins test dependencies (informer/resetter) via pseudo-versions and bumps api-go to beta.14. |
| handler/response.go | Decodes http/v1 Response protos and writes header values from bytes to net/http headers. |
| handler/request.go | Updates request payload marshaling signature to accept http/v1 Request proto. |
| handler/pool.go | Updates proto request/response pool types to http/v1 Request/Response. |
| handler/handler.go | Updates proto pool initialization to http/v1 types and header map value type. |
| handler/convert.go | Converts net/http headers/cookies into http/v1 HeaderValue (repeated bytes). |
| go.sum | Updates checksums for the bumped api-go dependency. |
| go.mod | Bumps github.com/roadrunner-server/api-go/v6 to v6.0.0-beta.14. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the worker payload wire format to http/v1 (Request/Response/HeaderValue with bytes values), matching released spiral/roadrunner-http v3/v4.
Part of the v1 proto revert (roadrunner-server/api#77, roadrunner-server/api-go#35): wire format back to what roadrunner-api-dto v1.14.1 and the released PHP packages speak. Pins api-go v6.0.0-beta.14. Tests temporarily pin sibling revert branches via pseudo-versions; they will be bumped to the new betas once tagged.