fix(quality): tour title/element alignment and capability pluralization#594
Merged
Conversation
Two surface-level quality bugs surfaced by the Early-Maturity EA Practice Lead persona walk (#586): 1. product-tour.tsx — steps 9, 10, 11 had titles anchored to the wrong nav elements. The Strategy nav group was showing a "Decisions" popover, the Roadmap nav item was showing "Strategy", and the Reports nav group was showing "Roadmap". Re-anchored each step to the nav element whose label matches its title and description: nav-adrs → "Decisions", nav-strategy → "Strategy", nav-roadmap → "Roadmap". 2. Pluralization — three call sites built the plural form as `capability${n !== 1 ? 'ies' : 'y'}`, which produces "capabilityies" for any plural count because the base string already ends in "y". Replaced with explicit `${n === 1 ? 'capability' : 'capabilities'}` in: - reports/architecture-vision/page.tsx (Strategic Drivers, Gaps) - executive/page.tsx (Architecture Gaps callout) - reports/heatmap/page.tsx (Unsupported callout) Both bugs were visible on every stakeholder-facing demo surface for the persona — Architecture Vision report, Executive Summary, the in-product tour. Browser-verified the pluralization fix on /reports/architecture-vision and /executive (no remaining "capabilityies" matches). Tour fix verified by source diff (driver.js is hard to drive programmatically across many steps). Capability: fd-traceability-views; fd-portfolio-views Closes #588
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two surface-level quality bugs surfaced by the Early-Maturity EA Practice Lead persona walk (#586). Both ride on stakeholder-facing surfaces (Architecture Vision report, Executive Summary, in-product tour) and undercut the credibility of the first-deliverable demo path.
1. Tour step misalignment — Steps 9-11 anchored to the wrong nav elements:
nav-strategynav-adrsnav-roadmapnav-strategynav-reportsnav-roadmapEach step now has element + title + description aligned. (No tour length change; the rationale for not adding a separate "Reports" step is that the Reports section already gets its own visual treatment in the nav and the tour's purpose is orientation rather than enumeration.)
2. Pluralization — three call sites built the plural form as
capability${n !== 1 ? 'ies' : 'y'}→ "capabilityies" for any n ≠ 1, because the base string already ends in "y". Replaced with explicit${n === 1 ? 'capability' : 'capabilities'}in:reports/architecture-vision/page.tsx(Strategic Drivers panel + Gaps line)executive/page.tsx(Architecture Gaps callout)reports/heatmap/page.tsx(Unsupported callout — found while sweeping)Test plan
/reports/architecture-visionshows "3 capabilities linked" / "2 capabilities linked" (was "capabilityies")/executiveshows "4 capabilities without supporting technology" (was "capabilityies")product-tour.tsxgrep -rE "\? 'ies' :"inapps/govea/srcreturns no remaining buggy template literalsCapability: fd-traceability-views; fd-portfolio-views
Closes #588
🤖 Generated with Claude Code