New roboflow model block versions with confidence dropdown#2246
Draft
leeclemnet wants to merge 44 commits intomainfrom
Draft
New roboflow model block versions with confidence dropdown#2246leeclemnet wants to merge 44 commits intomainfrom
leeclemnet wants to merge 44 commits intomainfrom
Conversation
…ge refinement into existing loops
…confidence Tensor contents
22d7255 to
662da7e
Compare
662da7e to
7a35e90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#2242 introduced support for "best", "default" and custom confidence threshold modes with "best" derived from model-eval and "default" using the inference_models defaults / env vars. "default" is the default and inference users generally must opt-in to the the other modes.
This PR creates new versions of the roboflow model workflows blocks to include some UI around confidence mode selection, and makes "best" the recommended and default option for new workflows.
Semantic Segmentation and Keypoint Detection model blocks are updated to match the UI but do not have the "Best" option because model-eval does not yet support those tasks.
Depends on:
Type of Change
Testing
Test details:
Unit tests for new block versions
Bump block versions in integration tests
Workflow test against local inference server.
Checklist
Additional Context