Skip to content

Conversation

@christophfroehlich
Copy link
Member

@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-humble Triggers PR backport to ROS 2 humble. labels Jul 1, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (ff1f2d6) to head (c5155f2).

Additional details and impacted files
@@             Coverage Diff              @@
##           ros2-master     #424   +/-   ##
============================================
  Coverage        78.38%   78.38%           
============================================
  Files               30       30           
  Lines             1888     1888           
  Branches           114      114           
============================================
  Hits              1480     1480           
  Misses             338      338           
  Partials            70       70           
Flag Coverage Δ
unittests 78.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

saikishor
saikishor previously approved these changes Jul 1, 2025
Copy link

@xguay xguay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this workflow more uniform and robust to copy into other repos I'd like to suggest adding the following file formats to the list.

  • .jpg
  • .jpeg
  • .png
  • .svg
  • .yml
  • .bib maybe

@christophfroehlich
Copy link
Member Author

To make this workflow more uniform and robust to copy into other repos I'd like to suggest adding the following file formats to the list.

* .jpg

* .jpeg

* .png

* .svg

* .yml

* .bib maybe

You mean for the path filters? Could make sense. problem with the yml files is that the github workflows also have the same ending. I can have a look if one can exclude the .github folder but include other yaml files.

@christophfroehlich christophfroehlich merged commit 8462152 into ros2-master Jul 3, 2025
22 of 25 checks passed
@christophfroehlich christophfroehlich deleted the pr/doc/wf branch July 3, 2025 18:11
mergify bot pushed a commit that referenced this pull request Jul 3, 2025
(cherry picked from commit 8462152)

# Conflicts:
#	doc/migration.rst
#	doc/release_notes.rst
mergify bot pushed a commit that referenced this pull request Jul 3, 2025
(cherry picked from commit 8462152)

# Conflicts:
#	doc/migration.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants