Skip to content

Conversation

@saikishor
Copy link
Member

@saikishor saikishor commented Nov 4, 2024

The new changes to the handles, that the data exists inside the Handle itself will create problems with the old transmission_interface API and it is kinda dysfunctional with the new approach. This PR aims to solve the issue by migrating the transmission part to the new API and making it functional with the latest shared pointers approach.

@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 96.25293% with 16 lines in your changes missing coverage. Please review.

Project coverage is 89.41%. Comparing base (bfbedd2) to head (fce062f).
Report is 120 commits behind head on master.

Files with missing lines Patch % Lines
...ce/include/transmission_interface/transmission.hpp 0.00% 9 Missing ⚠️
...ude/transmission_interface/simple_transmission.hpp 76.92% 1 Missing and 2 partials ⚠️
...ansmission_interface/differential_transmission.hpp 95.23% 0 Missing and 2 partials ⚠️
...ission_interface/four_bar_linkage_transmission.hpp 93.54% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
- Coverage   89.59%   89.41%   -0.18%     
==========================================
  Files         139      139              
  Lines       15222    15409     +187     
  Branches     1290     1298       +8     
==========================================
+ Hits        13638    13778     +140     
- Misses       1096     1139      +43     
- Partials      488      492       +4     
Flag Coverage Δ
unittests 89.41% <96.25%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...erface/include/transmission_interface/accessor.hpp 83.33% <ø> (ø)
..._interface/test/differential_transmission_test.cpp 99.53% <100.00%> (+0.15%) ⬆️
...erface/test/four_bar_linkage_transmission_test.cpp 99.52% <100.00%> (+0.13%) ⬆️
...ission_interface/test/simple_transmission_test.cpp 100.00% <100.00%> (ø)
transmission_interface/test/utils_test.cpp 100.00% <100.00%> (ø)
...ansmission_interface/differential_transmission.hpp 74.04% <95.23%> (-5.77%) ⬇️
...ission_interface/four_bar_linkage_transmission.hpp 71.18% <93.54%> (-6.71%) ⬇️
...ude/transmission_interface/simple_transmission.hpp 70.17% <76.92%> (-4.34%) ⬇️
...ce/include/transmission_interface/transmission.hpp 9.09% <0.00%> (-90.91%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gcc still has some deprecation warnings

saikishor and others added 2 commits March 9, 2025 22:01
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor marked this pull request as draft June 7, 2025 09:24
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Jul 22, 2025
@mergify
Copy link
Contributor

mergify bot commented Jul 22, 2025

This pull request is in conflict. Could you fix it @saikishor?

@saikishor saikishor closed this Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants