Skip to content

Conversation

@TheDevMystic
Copy link
Contributor

Hello, ros_controllers maintainers. This is indeed, my first contribution.

Here I changed the following files,

  1. ackermann_steering_controller/test/test_ackermann_steering_controller.hpp
  2. bicycle_steering_controller/test/test_bicycle_steering_controller.hpp
  3. steering_controllers_library/test/test_steering_controllers_library.hpp

I renamed every instance of joint_reference_interfaces_
to reference_interface_names_.

Regards,
TheDevMystic (Surya)

@christophfroehlich christophfroehlich linked an issue Nov 16, 2025 that may be closed by this pull request
8 tasks
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling your first issue.
Please follow our contributing guidelines as linked in the first issue: Ensure that your code builds and tests pass before you submit a PR. In this case, you have only renamed the defined variables but not their usage in the code.

@TheDevMystic
Copy link
Contributor Author

Thank you very much dear ros_controllers maintainers. It seems like I was too focused on core goal that I missed crucial quality check. Please be reassured that I'll fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename joint_reference_interfaces_ variable

4 participants