-
Notifications
You must be signed in to change notification settings - Fork 425
Refactor: Renamed joint_reference_interfaces_ to reference_interface_… #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Renamed joint_reference_interfaces_ to reference_interface_… #2008
Conversation
…names_ in all test files.
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
|
Earlier approvals were in #2003 (@TheDevMystic there was no need to close it, you just could have pushed new changes to your branch). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2008 +/- ##
=======================================
Coverage 85.32% 85.32%
=======================================
Files 143 143
Lines 13936 13936
Branches 1201 1201
=======================================
Hits 11891 11891
Misses 1638 1638
Partials 407 407
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
6ddb0b4
into
ros-controls:master
(cherry picked from commit 6ddb0b4) # Conflicts: # ackermann_steering_controller/test/test_ackermann_steering_controller.cpp # ackermann_steering_controller/test/test_ackermann_steering_controller.hpp # ackermann_steering_controller/test/test_ackermann_steering_controller_preceding.cpp # bicycle_steering_controller/test/test_bicycle_steering_controller.cpp # bicycle_steering_controller/test/test_bicycle_steering_controller.hpp # bicycle_steering_controller/test/test_bicycle_steering_controller_preceding.cpp # steering_controllers_library/test/test_steering_controllers_library.cpp # steering_controllers_library/test/test_steering_controllers_library.hpp # tricycle_steering_controller/test/test_tricycle_steering_controller.cpp # tricycle_steering_controller/test/test_tricycle_steering_controller.hpp # tricycle_steering_controller/test/test_tricycle_steering_controller_preceding.cpp
(cherry picked from commit 6ddb0b4)
(cherry picked from commit 6ddb0b4)
|
Thank you very much Christopher! I'm glad , I can be helpful to ya. |
Dear ros2_controllers maintainers, my previous pull request was taken down due to some issues. Because of the that issue I have to open a second pull request. I am deeply sorry for the inconvenience due to my error.
Furthermore, information related to this pull request are as following,
It passed following workflows,
Again, I am extremely sorry for second pull request and your inconvenience.