Skip to content

Conversation

@TheDevMystic
Copy link
Contributor

Dear ros2_controllers maintainers, my previous pull request was taken down due to some issues. Because of the that issue I have to open a second pull request. I am deeply sorry for the inconvenience due to my error.

Furthermore, information related to this pull request are as following,

  1. Changed joint_reference_interfaces_ to reference_interface_name_ in 11 files with 31 additions and 31 deletions.

It passed following workflows,

  1. Check rolling compatibility on Jazzy
  2. Check rolling compatibility on Humble
  3. Check rolling compatibility on Kilted.

Again, I am extremely sorry for second pull request and your inconvenience.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@christophfroehlich christophfroehlich linked an issue Nov 18, 2025 that may be closed by this pull request
8 tasks
@christophfroehlich
Copy link
Contributor

Earlier approvals were in #2003 (@TheDevMystic there was no need to close it, you just could have pushed new changes to your branch).

@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.32%. Comparing base (d71538a) to head (d18e042).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2008   +/-   ##
=======================================
  Coverage   85.32%   85.32%           
=======================================
  Files         143      143           
  Lines       13936    13936           
  Branches     1201     1201           
=======================================
  Hits        11891    11891           
  Misses       1638     1638           
  Partials      407      407           
Flag Coverage Δ
unittests 85.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller/test/test_ackermann_steering_controller.cpp 100.00% <100.00%> (ø)
...roller/test/test_ackermann_steering_controller.hpp 88.28% <ø> (ø)
...t/test_ackermann_steering_controller_preceding.cpp 100.00% <100.00%> (ø)
...ntroller/test/test_bicycle_steering_controller.cpp 100.00% <100.00%> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 85.71% <ø> (ø)
...est/test_bicycle_steering_controller_preceding.cpp 100.00% <100.00%> (ø)
...library/test/test_steering_controllers_library.cpp 100.00% <100.00%> (ø)
...library/test/test_steering_controllers_library.hpp 97.43% <ø> (ø)
...troller/test/test_tricycle_steering_controller.cpp 100.00% <100.00%> (ø)
...troller/test/test_tricycle_steering_controller.hpp 87.12% <ø> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Nov 18, 2025
@christophfroehlich christophfroehlich merged commit 6ddb0b4 into ros-controls:master Nov 18, 2025
18 of 19 checks passed
mergify bot pushed a commit that referenced this pull request Nov 18, 2025
(cherry picked from commit 6ddb0b4)

# Conflicts:
#	ackermann_steering_controller/test/test_ackermann_steering_controller.cpp
#	ackermann_steering_controller/test/test_ackermann_steering_controller.hpp
#	ackermann_steering_controller/test/test_ackermann_steering_controller_preceding.cpp
#	bicycle_steering_controller/test/test_bicycle_steering_controller.cpp
#	bicycle_steering_controller/test/test_bicycle_steering_controller.hpp
#	bicycle_steering_controller/test/test_bicycle_steering_controller_preceding.cpp
#	steering_controllers_library/test/test_steering_controllers_library.cpp
#	steering_controllers_library/test/test_steering_controllers_library.hpp
#	tricycle_steering_controller/test/test_tricycle_steering_controller.cpp
#	tricycle_steering_controller/test/test_tricycle_steering_controller.hpp
#	tricycle_steering_controller/test/test_tricycle_steering_controller_preceding.cpp
mergify bot pushed a commit that referenced this pull request Nov 18, 2025
mergify bot pushed a commit that referenced this pull request Nov 18, 2025
@TheDevMystic
Copy link
Contributor Author

Thank you very much Christopher! I'm glad , I can be helpful to ya.

@TheDevMystic TheDevMystic deleted the rename-joint-ref-interface branch November 19, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename joint_reference_interfaces_ variable

2 participants