Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Foxy Fitzroy to REP 2000 #217

Merged
merged 26 commits into from
May 8, 2020
Merged

Add Foxy Fitzroy to REP 2000 #217

merged 26 commits into from
May 8, 2020

Conversation

jacobperron
Copy link
Contributor

So far, I've changed the version of Ubuntu (and some of it's dependency requirements) as well as bumped the language requirements.

@jacobperron
Add Foxy Fitzroy to REP 2000
7eb2bc9 
Copied platform information from Eloquent.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Switch to Ubuntu Focal and update language requirements
f4fba71 
Update dependencies accordingly.

C++17 and Python 3.7

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
dirk-thomas reviewed Dec 11, 2019
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Show resolved Hide resolved
wjwwood
wjwwood reviewed Dec 11, 2019
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
chapulina
chapulina reviewed Dec 11, 2019
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
@jacobperron
Rephrase note about Connext 6 support
ebec755 
Also updated the referenced ticket.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Update to MacOS Catalina
1f61d11 
Mark as tentative.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Update Focal dependencies
1467522 
And change Gazebo version for macOS and buster.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Add Ignition dependency requirement
ee62dc3 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
dirk-thomas reviewed Dec 15, 2019
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
jacobperron and others added 2 commits December 16, 2019 15:03
@jacobperron
Update Python version for Ubuntu and Windows
a9dc606 
I can update for macOS later if there's confirmation homebrew will update to 3.8

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@dirk-thomas
using latest FastRTPS release for now
24bf723
dirk-thomas
dirk-thomas reviewed Dec 16, 2019
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
@dirk-thomas dirk-thomas mentioned this pull request Jan 15, 2020
Merged
@jacobperron jacobperron self-assigned this Feb 6, 2020
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/future-ros-2-release-schedule/13030/1

@dirk-thomas dirk-thomas mentioned this pull request Mar 11, 2020
Merged
@dirk-thomas
Copy link
Member

I bumped CycloneDDS to tier-1 (e10c7ce) since we have recently updated CI to build with CycloneDDS for all PR testing as well as the nightlies and there are no significant issues blocking it from having the same level of support as FastRTPS and Connext.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-03-18/13313/1

@herb-kuta-lge
Copy link
Contributor

@jacobperron < I see that Ubuntu Focal now provides OpenCV 4.2 instead of 4.1 (see https://packages.ubuntu.com/source/focal/opencv). Should the chart for Foxy be updated?

@jacobperron
Update OpenCV version for Ubuntu and MacOS
b14c8f4 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Contributor Author

@herb-kuta-lge Thanks, updated b14c8f4

@nuclearsandwich nuclearsandwich mentioned this pull request Mar 31, 2020
Closed
@jacobperron
Update the dependency versions for OpenEmbedded and webOS OSE
f487cee 
Copied changes applied to Dashing and Eloquent in #234.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
mjcarroll
mjcarroll approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it may be worth the effort of packaging a new OpenCV version for Windows, if we want to get a consistent version across our Tier 1 platforms.

j-rivero
j-rivero reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I left some comments regarding cmake and pcl versions currently in Focal.

rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
@jacobperron
Update CMake version for Ubuntu
e48f9ff 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Update PCL version for Ubuntu
90cf56b 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Contributor Author

it may be worth the effort of packaging a new OpenCV version for Windows, if we want to get a consistent version across our Tier 1 platforms.

It's a nice idea. If someone has some time to look into doing this, please speak up 🙂 I'll see if I have some time later to take a look.

dirk-thomas
dirk-thomas reviewed Apr 7, 2020
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
mikaelarguedas
mikaelarguedas reviewed Apr 8, 2020
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
jacobperron and others added 4 commits April 8, 2020 18:31
@jacobperron
Bump CycloneDDS version
90b959d 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Mark Gazebo and Ignition as distributed by OSRF
6bd8ad0 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Bump OpenSSL versions
b4a910e 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@dirk-thomas
use FastRTPS 1.10
f498234
@jacobperron jacobperron mentioned this pull request Apr 14, 2020
Merged
herb-kuta-lge
herb-kuta-lge reviewed Apr 20, 2020
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
herb-kuta-lge and others added 2 commits April 23, 2020 13:17
@herb-kuta-lge
Update PCL version for OpenEmbedded (#249)
fe64bb9
@jacobperron @mikaelarguedas
Mark arm32 has having debs provided
70511f1 
Co-Authored-By: Mikael Arguedas <mikael.arguedas@gmail.com>
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros2-foxy-installation-on-ubuntu-20-04-failed/13894/4

sloretz
sloretz reviewed May 1, 2020
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
chapulina
chapulina reviewed May 8, 2020
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
@jacobperron @chapulina
Update rep-2000.rst
9fa34be 
Co-authored-by: Louise Poubel <louise@openrobotics.org>
clalancette
clalancette requested changes May 8, 2020
View reviewed changes
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst
Comment on lines +698 to +699
.. [7] Connext DDS 6.0.0 Support
(https://github.com/ros2/rmw_connext/issues/375)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be removed from the REP, since it doesn't look like it is going to happen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This footnote is still referenced by older distros in this document. If we remove this, I suggest we do it in a separate PR.

@jacobperron
Mojave
6e73ac3 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Remove tentative Connext 6.0.0
701fbf9 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Update python version for macOS
2326172 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Contributor Author

Thanks everyone for the feedback! Feel free to open more PRs and tag me if there's something else that needs an update.

@jacobperron jacobperron merged commit 6912d2d into master May 8, 2020
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/potential-downgrade-of-arm32-support-to-tier-3/14136/1

@jacobperron jacobperron deleted the jacob/foxy branch May 16, 2020 06:33
@cottsay cottsay mentioned this pull request Aug 10, 2020
Closed
65 tasks
@cottsay cottsay mentioned this pull request Nov 20, 2020
Merged
@audrow audrow mentioned this pull request Jun 3, 2021
Closed
82 tasks
@gbiggs gbiggs mentioned this pull request Sep 1, 2022
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dejanpan dejanpan dejanpan left review comments

@wjwwood wjwwood wjwwood left review comments

@gbiggs gbiggs gbiggs left review comments

@dirk-thomas dirk-thomas dirk-thomas left review comments

@lokesku lokesku lokesku left review comments

@j-rivero j-rivero j-rivero left review comments

@sloretz sloretz sloretz left review comments

@chapulina chapulina chapulina approved these changes

@mikaelarguedas mikaelarguedas mikaelarguedas left review comments

@herb-kuta-lge herb-kuta-lge herb-kuta-lge left review comments

@clalancette clalancette clalancette approved these changes

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

@jacobperron jacobperron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet