Skip to content

Add --cmake-args option for ros-ci-for-pr - #11

Merged
emersonknapp merged 2 commits into
ros-tooling:mainfrom
MichaelOrlov:add-cmake-args-to-ros-ci-for-pr
Jun 13, 2024
Merged

Add --cmake-args option for ros-ci-for-pr#11
emersonknapp merged 2 commits into
ros-tooling:mainfrom
MichaelOrlov:add-cmake-args-to-ros-ci-for-pr

Conversation

@MichaelOrlov

Copy link
Copy Markdown
Member
  • Add --cmake-args option for ros-ci-for-pr build script.
  • Will be useful when need to run CI with some specific cmake args or definitions.
  • For instance to run CI with enabled rosbag2 benchmarks --cmake-args -DBUILD_ROSBAG2_BENCHMARKS=1

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Comment thread ros_github_scripts/ci_for_pr.py Outdated
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@christophebedard

Copy link
Copy Markdown
Member

I haven't tested it (and apparently I don't have merge permissions), but it looks good to me.

@MichaelOrlov

Copy link
Copy Markdown
Member Author

@emersonknapp @clalancette, Could you please merge this PR? It has been reviewed.

@emersonknapp
emersonknapp merged commit d7de180 into ros-tooling:main Jun 13, 2024
@MichaelOrlov
MichaelOrlov deleted the add-cmake-args-to-ros-ci-for-pr branch June 13, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants