This repository was archived by the owner on May 31, 2025. It is now read-only.
Don't delete the temporary file before importing it #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added a commit
that referenced
this pull request
Jul 13, 2012
Don't delete the temporary file before importing it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've no idea how this actually worked on *nix. NamedTemporaryFile() has an argument variable 'delete' with default value of 'True'. This implies it should delete immediately as soon as the file is closed.
It didn't on linux, but did on windows and the subsequent import failed.
This just ensures we don't delete it. It will naturally disappear when the directory is deleted at exit (from the line above).