add nanoeigenpy on rolling

[nim65s]

Please Add This Package to be indexed in the rosdistro.

nanoeigenpy

This is the successor of eigenpy, rewritten from Boost::Python to nanobind

The source is here:

https://github.com/Simple-Robotics/nanoeigenpy

Checks

• All packages have a declared license in the package.xml
• This repository has a LICENSE file
• [x]This package is expected to build on the submitted rosdistro

[github-actions]

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

• ROS Distributions are created using REP-134 Standards Track as a guide.
• Your package name should comply to REP-144 ROS Package Naming
• Your package must build for all platforms and architectures on the ROS buildfarm. See REP-2000 ROS Releases and Supported Platforms for all supported platforms for your ROS Distro.
• Your package must contain an OSI approved license. Your package.xml file must also include that license in a machine readable format. See REP-149 Package Manifest Format Three Specification for additional details.
• A publicly available, open source, repository for your ROS package.
• While not required, we recommend that you create an account for ROS Discourse and subscribe to the appropriate release topic.
• If you would like, you may join our Discord Server and ask questions in the #infra-help channel.

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

• REP-2004 Package Quality Declaration-- The ROS 2 TSC has created a quality rating system for ROS packages. These ratings should serve as a guide for package developers. We recommend package developers achieve a quality level of three or higher.
• Documentation -- it is recommended that ROS packages include an extensive README.md file, and API level documentation using the Sphinx documentation system.
• Maintainer Responsibilities -- the ROS 2 documentation includes a guide to ROS package maintainer responsibilities that summarizes your responsibilities as an open source maintainer. While we do not enforce these requirements on package maintainers they should be considered best practices.
• We recommend that your package should strive to conform to the ROS 2 Developer Guide and the ROS 2 Style Guide.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.

---

For changes related to yamllint:

• ✅ All new lines of YAML pass linter checks

[christophebedard]

New package checklist:

• At least one of the following must be present
  • Top level license file: https://github.com/Simple-Robotics/nanoeigenpy/blob/main/LICENSE
  • Per package license files:
• License is OSI-approved: BSD-3
• License correctly listed in package.xmls
  • BSD-3 is correctly listed: https://github.com/Simple-Robotics/nanoeigenpy/blob/e02383cc9f56fefde84273a4a07972c92a6491fa/package.xml#L9
  • However, the repo/package has a submodule under the cmake/ directory that has LGPL-licensed code: https://github.com/jrl-umi3218/jrl-cmakemodules/tree/b1b4f05d50d60ea2bf2350b5a287c83499db0540
    • The LICENSE file for it is here, and it implies that some files may use other licenses: https://github.com/jrl-umi3218/jrl-cmakemodules/blob/b1b4f05d50d60ea2bf2350b5a287c83499db0540/LICENSE
    • Weird thing is that repo has a package.xml file and its license is listed as BSD-2: https://github.com/jrl-umi3218/jrl-cmakemodules/blob/b1b4f05d50d60ea2bf2350b5a287c83499db0540/package.xml#L11
    • The license for this should be clarified, and all of its licenses should be listed as <license> under your package, since you're including it as a submodule
• Public source repo: https://github.com/Simple-Robotics/nanoeigenpy
• Source repository contains ROS packages
• Each package meets REP-144 naming conventions
  • Successor to eigenpy using nanobind makes sense

Overall, the licensing needs to be clarified. I know the original package (eigenpy) does the same thing and has been released already, but I don't think it's a valid reason to do the same here unfortunately.

[nim65s]

Thanks for the review, we'll try to sort that out

[github-actions]

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

[nim65s]

@christophebedard do you mean we should update nanoeigenpy package.xml with something like:

  <license>BSD-2-Clause</license>
  <license>BSD-3-Clause</license>
  <license>GPL-3.0-or-later</license>
  <license>LGPL-3.0-or-later</license>
  <license>Apache-2.0</license>
  <license>MIT</license>

[christophebedard]

Yes, exactly. It would also be good to add XML comments (<!-- ... -->) on each line and describe what directory or files each <license> corresponds to. For example: https://github.com/ros2/rosbag2/blob/49384be8c9d870525728a85ecaf9c004570d37cf/liblz4_vendor/package.xml#L10-L12

[mjcarroll]

@nim65s friendly ping

[nim65s]

The package.xml now list all licenses used in the project