Skip to content

Port many graph introspection features from osrf fork #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 10, 2022
Merged

Port many graph introspection features from osrf fork #221

merged 9 commits into from
Aug 10, 2022

Conversation

@ivanpauno
Copy link
Contributor

@ivanpauno ivanpauno commented Jun 27, 2022 •
edited
Loading

ivanpauno added 2 commits June 27, 2022 15:07
@ivanpauno
Update qos profile -- take 2 (osrf#25)
fd2dd7b 
* Improve QoSProfile constructors
* Add documentation to QoSProfile class
* Add fromRCL method to QoSProfile
* Use fromRCL to create the built-in qos profiles.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add get topic names and type method to Node class (osrf#32)
d6c5085 
* Add NameAndTypes class
* Add getTopicNamesAndTypes method to Node

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno requested a review from jacobperron June 27, 2022 18:08
@ivanpauno ivanpauno self-assigned this Jun 27, 2022
ivanpauno added 5 commits June 27, 2022 15:48
@ivanpauno
Add getPublishersInfo method to Node (osrf#26)
2ece6fb 
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add get node names method to Node class (osrf#31)
dba9ea6 
* Add NodeNameInfo class
* Implement getNodeNames

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Use rcpputils::scope_exit in native getTopicNamesAndTypes Node method (…
d0c6d43 
…osrf#38)

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Add getSubscriptionsInfo to Node class (osrf#27)
22fd2cd 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Implement nativeGetServiceNamesAndTypes method (osrf#33)
710fc2a 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/port-from-osrf-fork-2 branch from ecd8a84 to 710fc2a Compare June 27, 2022 18:48
@ivanpauno
Copy link
Contributor Author

ivanpauno commented Jul 12, 2022

@jacobperron this is ready for review now

ivanpauno and others added 2 commits July 12, 2022 16:45
@ivanpauno
Do not use multiple message types in the same topic (osrf#61)
b0b30e4 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@jacobperron @ivanpauno
Add missing target dependency on rcpputils (osrf#90)
18faaa7 
Fixes a build issue with newer versions of ROS Rolling:

    fatal error: rcpputils/scope_exit.hpp: No such file or directory

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@ivanpauno ivanpauno force-pushed the ivanpauno/port-from-osrf-fork-2 branch from 37222ef to 18faaa7 Compare July 12, 2022 19:45
@ivanpauno
Copy link
Contributor Author

ivanpauno commented Aug 4, 2022

@jacobperron friendly ping

jacobperron
jacobperron approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay review.

LGTM!

@ivanpauno ivanpauno merged commit d0e4e95 into main Aug 10, 2022
@ivanpauno ivanpauno deleted the ivanpauno/port-from-osrf-fork-2 branch August 10, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@ivanpauno ivanpauno

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanpauno @jacobperron