Skip to content

Add getPublishersInfo method to Node #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2020
Merged

Add getPublishersInfo method to Node #26

merged 4 commits into from
Sep 11, 2020

Conversation

@ivanpauno
Copy link
Collaborator

@ivanpauno ivanpauno commented Sep 1, 2020 •
edited
Loading

Depends on #25.
Depends on #30.

This PR adds:

  • An EndpointInfo class, to describe the value return by getPublishersInfo and getSubscriptionsInfo (unimplemented).
  • Implements getPublishersInfo with proper unit testing.

@ivanpauno ivanpauno added the enhancement New feature or request label Sep 1, 2020
@ivanpauno ivanpauno self-assigned this Sep 1, 2020
This was referenced Sep 1, 2020
Merged
Merged
@ivanpauno ivanpauno force-pushed the ivanpauno/introspect-qos branch from 1903424 to 9c3036d Compare September 1, 2020 21:22
@ivanpauno ivanpauno mentioned this pull request Sep 3, 2020
Merged
@ivanpauno ivanpauno force-pushed the ivanpauno/update-qos-profile-take-2 branch from 6a7ef48 to 8201da2 Compare September 3, 2020 18:20
@ivanpauno ivanpauno force-pushed the ivanpauno/introspect-qos branch from 9c3036d to 74192f7 Compare September 3, 2020 18:22
@ivanpauno
Copy link
Collaborator Author

ivanpauno commented Sep 8, 2020

Converting to draft until #30 and #25 are merged.

@ivanpauno ivanpauno marked this pull request as draft September 8, 2020 14:22
@ivanpauno ivanpauno force-pushed the ivanpauno/update-qos-profile-take-2 branch from 8201da2 to 2648f10 Compare September 8, 2020 21:13
@ivanpauno ivanpauno force-pushed the ivanpauno/introspect-qos branch from 41f516f to 7bd6cc4 Compare September 8, 2020 21:17
@ivanpauno ivanpauno force-pushed the ivanpauno/update-qos-profile-take-2 branch from 2648f10 to 0a9fb5f Compare September 8, 2020 21:26
Base automatically changed from ivanpauno/update-qos-profile-take-2 to galactic-devel September 9, 2020 17:51
@ivanpauno ivanpauno force-pushed the ivanpauno/introspect-qos branch from 7bd6cc4 to 0c3bc7d Compare September 9, 2020 21:00
@ivanpauno ivanpauno marked this pull request as ready for review September 9, 2020 21:00
jacobperron
jacobperron reviewed Sep 10, 2020
View reviewed changes
@ivanpauno
* Add EndpointInfo class.
4c7c1be 
* Add getPublishersInfo method to Node.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno
Address peer review comments
0024d68 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno force-pushed the ivanpauno/introspect-qos branch from 0c3bc7d to 0024d68 Compare September 10, 2020 22:02
@ivanpauno
Use rcpputils scope_exit
111fab9 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
jacobperron approved these changes Sep 11, 2020
View reviewed changes
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment.

@ivanpauno
Address peer review comment
73fba78 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno merged commit 7e2b15e into galactic-devel Sep 11, 2020
@ivanpauno ivanpauno deleted the ivanpauno/introspect-qos branch September 11, 2020 19:18
@ivanpauno ivanpauno mentioned this pull request Sep 16, 2020
Merged
ivanpauno added a commit that referenced this pull request May 17, 2021
@ivanpauno
Add getPublishersInfo method to Node (#26)
40ef1df 
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
@ivanpauno @jacobperron
Add getPublishersInfo method to Node (osrf#26)
74db616 
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 13, 2022
@ivanpauno @jacobperron
Add getPublishersInfo method to Node (osrf#26)
533f764 
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 17, 2022
@ivanpauno @jacobperron
Add getPublishersInfo method to Node (osrf#26)
dfea329 
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Jun 27, 2022
@ivanpauno
Add getPublishersInfo method to Node (osrf#26)
9b326a3 
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno mentioned this pull request Jun 27, 2022
Merged
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Jun 27, 2022
@ivanpauno
Add getPublishersInfo method to Node (osrf#26)
2ece6fb 
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Aug 10, 2022
@ivanpauno
Add getPublishersInfo method to Node (osrf#26)
ece8300 
** Add EndpointInfo class.
* Add getPublishersInfo method to Node.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jacobperron jacobperron jacobperron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ivanpauno ivanpauno

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanpauno @jacobperron