Add get node names method to Node class #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Converting to draft until #30 is merged. |
Sounds good to me 👍 |
Base automatically changed from
ivanpauno/add-convenient-error-handling-macros
to
galactic-devel
September 8, 2020 21:22
ivanpauno
force-pushed
the
ivanpauno/get-node-names
branch
from
d80826c to
4faa768
Compare
* Implement getNodeNames Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
force-pushed
the
ivanpauno/get-node-names
branch
from
4faa768 to
927a23b
Compare
jacobperron
reviewed
Sep 15, 2020
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
approved these changes
Sep 16, 2020
ivanpauno
added a commit
that referenced
this pull request
May 17, 2021
* Add NodeNameInfo class * Implement getNodeNames Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 13, 2022
* Add NodeNameInfo class * Implement getNodeNames Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 13, 2022
* Add NodeNameInfo class * Implement getNodeNames Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 17, 2022
* Add NodeNameInfo class * Implement getNodeNames Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
added a commit
to ros2-java/ros2_java
that referenced
this pull request
Jun 27, 2022
* Add NodeNameInfo class * Implement getNodeNames Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
added a commit
to ros2-java/ros2_java
that referenced
this pull request
Jun 27, 2022
* Add NodeNameInfo class * Implement getNodeNames Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
added a commit
to ros2-java/ros2_java
that referenced
this pull request
Aug 10, 2022
* Add NodeNameInfo class * Implement getNodeNames Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #30.
Maybe we should target all PRs to galactic here, what do you think @jacobperron ?
We can later create PRs in all the branches that apply when contributing upstream.