Re-export traits from rosidl_runtime_rs #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
esteve
approved these changes
Oct 12, 2025
github-actions bot
pushed a commit
to knmcguire/ros2_rust
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
to knmcguire/ros2_rust
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
to knmcguire/ros2_rust
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
to knmcguire/ros2_rust
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively minor quality of life improvement, but for downstream packages that want to do generic programming based on message and service traits, this PR will allow those packages to not need an explicit dependency on
rosidl_runtime_rs. By re-exporting the traits inrclrs, downstream users can just refer to the trait definitions as though the traits are coming directly fromrclrs.Avoiding the need for an explicit dependency on
rclrs_runtime_rshelps reduce clutter in theCargo.tomlfiles of downstream users and reduces maintenance burden because downstream users won't need to keep their declared versions ofrclrsandrosidl_runtime_rsin sync.